Replace all calls to db_query [core/test/../Database]

Should not tests avoid using \Drupal and use $this->container instead?

-    $result = db_query('SELECT CONCAT(:a1, CONCAT(name, CONCAT(:a2, CONCAT(age, :a3)))) FROM {test} WHERE age = :age', [
+    $result = $this->database
+      ->query('SELECT CONCAT(:a1, CONCAT(name, CONCAT(:a2, CONCAT(age, :a3)))) FROM {test} WHERE age = :age', [
       ':a1' => 'The age of ',
       ':a2' => ' is ',
       ':a3' => '.',

The indentation is wrong. It should be the following one.

-    $result = db_query('SELECT CONCAT(:a1, CONCAT(name, CONCAT(:a2, CONCAT(age, :a3)))) FROM {test} WHERE age = :age', [
+    $result = $this->database
+      ->query('SELECT CONCAT(:a1, CONCAT(name, CONCAT(:a2, CONCAT(age, :a3)))) FROM {test} WHERE age = :age', [
+        ':a1' => 'The age of ',
+        ':a2' => ' is ',
+        ':a3' => '.',

For the rest the patch is fine.

If somebody else doesn't find other mistakes, the patch for me is ready to RTBC.

Blocker was committed, un-postponing

1. +++ b/core/tests/Drupal/KernelTests/Core/Database/BasicSyntaxTest.php
   @@ -125,7 +129,7 @@ public function testLikeBackslash() {
      public function testGetFullQualifiedTableName() {
   -    $database = \Drupal::database();
   +    $database = $this->connection;
        $num_matches = $database->select($database->getFullQualifiedTableName('test'), 't')
   

   I understand this should minimize impact, but it seems strange to initialise a local $database variable here. Can't we just use $this->connection?

2. +++ b/core/tests/Drupal/KernelTests/Core/Database/LoggingTest.php
   @@ -17,11 +17,20 @@ class LoggingTest extends DatabaseTestBase {
    
   -    db_query('SELECT name FROM {test} WHERE age > :age', [':age' => 25])->fetchCol();
   -    db_query('SELECT age FROM {test} WHERE name = :name', [':name' => 'Ringo'])->fetchCol();
   +    call_user_func_array(
   +      [$this->connection, 'query'],
   +      ['SELECT name FROM {test} WHERE age > :age', [':age' => 25]]
   +    )->fetchCol();
   +    call_user_func_array(
   +      [$this->connection, 'query'],
   +      ['SELECT age FROM {test} WHERE name = :name', [':name' => 'Ringo']]
   +    )->fetchCol();
   

   I don't think this is correct in this case - I'd just use $this->connection->query instead. The call_user_func_array is correct a few lines below because in that case we want to test a call that does not have a file in the backtrace.

3. +++ b/core/tests/Drupal/KernelTests/Core/Database/RegressionTest.php
   index e239098715..775af1d3de 100644
   --- a/core/tests/Drupal/KernelTests/Core/Database/SchemaTest.php
   
   --- a/core/tests/Drupal/KernelTests/Core/Database/SchemaTest.php
   +++ b/core/tests/Drupal/KernelTests/Core/Database/SchemaTest.php
   
   +++ b/core/tests/Drupal/KernelTests/Core/Database/SchemaTest.php
   +++ b/core/tests/Drupal/KernelTests/Core/Database/SchemaTest.php
   @@ -21,6 +21,22 @@ class SchemaTest extends KernelTestBase {
   
   @@ -21,6 +21,22 @@ class SchemaTest extends KernelTestBase {
       */
      protected $counter;
    
   +  /**
   +   * Database service.
   +   *
   +   * @var \Drupal\Core\Database\Connection
   +   */
   +  protected $database;
   +
   +  /**
   +   * {@inheritdoc}
   +   */
   +  protected function setUp() {
   +    parent::setUp();
   +    $this->database = $this->container->get('database');
   +  }
   +
   +
   

   Uhm is there a reason we extend from KernelTestBase here and not from DatabaseTestBase? In that case that would not be needed and we could just use $this->connection... here too.