Notice: Undefined variable: profile in core/modules/system/system.module:1054

Are we sure we need to fix this in core? Shouldn't this be fixed in drupal console?

Does #4 mean that we can close this issue?

Because I keep hearing things like #6, I would like to call attention to the release cycle overview. Under current policy, the prior minor release is end-of-life on the day a new minor is released. But note:

There will be a minimum of 1 month between the release of a new minor and public disclosure of any security issues that affect the previous minor, in order to ensure all sites have adequate time to upgrade.

> This is a core issue IMO, since the _system_rebuild_module_data() function (https://github.com/drupal/drupal/blob/8.5.x/core/modules/system/system.m...) is not instantiating an expected variable as it should.

Has this maybe already been fixed?

I've looked at both 8.5.x and 8.4.x, and in both cases, _system_rebuild_module_data() has this right near the top, about 5 lines in:

 $profile = drupal_get_profile();

@joachim: In 8.6.x, _system_rebuild_module_data() was deprecated and replaced with a call to \Drupal::service('extension.list.module')->reset()->getList() in #2208429: Extension System, Part III: ExtensionList, ModuleExtensionList and ProfileExtensionList.

Sure, but in 8.4.x and 8.5.x, I can't see the problem that this issue is about.

@joachim I totally agree. $profile is already set to something in that function before this occurs, so of course it is defined in scope.

To be sure, I just executed all the updates from 8.4.x to 8.5.x and there is not a notice.

$ vendor/bin/drupal update:execute
 Switch site into maintenance mode
 Executing required previous updates
 Executing update function "8501" of module "system"
 Executing update function "8400" of module "block_content"
 Executing update function "8500" of module "field"
 Executing update function "8500" of module "views"
 Executing update function "change_action_plugins" of module "system"
 Executing update function "field_formatter_entity_schema" of module "system"
 Executing update function "bulk_field_moved" of module "views"
 Executing update function "entity_link_url" of module "views"
 Executing update function "filter_placeholder_text" of module "views"
 Executing update function "table_display_cache_max_age" of module "views"
 Executing update function "views_data_table_dependencies" of module "views"
 Operating in maintenance mode off

 // update:entities
 Operating in maintenance mode on
 Starting the entity updates
 Finished the entity updates
 Operating in maintenance mode off
 // cache:rebuild

 Rebuilding cache(s), wait a moment please.


 [OK] Done clearing cache(s).

If we can get steps to reproduce this, let's reopen it. But since this function is deprecated, we shouldn't spend too much effort on it.

Thanks all!