Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Problem/Motivation
Getting the following deprecation error when running PHPUnit tests on Windows:
The Symfony\Component\ClassLoader\WinCacheClassLoader class is deprecated since Symfony 3.3 and will be removed in 4.0. Use `composer install --apcu-autoloader` instead.
Proposed resolution
Add the message to the list of silenced deprecatation messages in drupal/core/tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#10 | 2938369-10-D8.patch | 1.71 KB | mohit1604 |
#8 | 2938369-8-D8.patch | 1.57 KB | mohit1604 |
#4 | phpunit-deprecatedclass-12443421-4-D8.patch | 1.4 KB | ioana apetri |
Comments
Comment #2
mondrakeComment #3
ioana apetri CreditAttribution: ioana apetri at OPTASY commentedComment #4
ioana apetri CreditAttribution: ioana apetri at OPTASY commentedPlease review, Thanks:)
Comment #5
mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commentedPatch seems good , thanks @yo30 :)
Comment #6
alexpottCan this line go next to the related
'The Symfony\Component\ClassLoader\ApcClassLoader class is deprecated since Symfony 3.3 and will be removed in 4.0. Use `composer install --apcu-autoloader` instead.',
line to make life a bit simpler.Comment #7
mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commentedComment #8
mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commentedWorked as per comment #6. Please review , Thanks :)
Comment #9
alexpottThis is already present. The WinCacheClassLoader deprecation needs to be moved to be alongside.
Comment #10
mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commented@alexpott , did changes as per comment #9, please review it, Thank You :)
Comment #11
mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commentedComment #12
mondrakeThank you all!
Tested this patch, in combination with the patch in #2932715: PHPUnit testing fails on Windows since #2928249, in an Windows Appveyor build of the Imagemagick module.
Without the patch: https://ci.appveyor.com/project/mondrake/imagemagick/build/1.0.307
With the patch: https://ci.appveyor.com/project/mondrake/imagemagick/build/1.0.314
RTBC
Comment #13
alexpottCredited myself and @mondrakefor reviewing and testing the patch.
Comment #14
alexpottCommitted and pushed 044194047b to 8.6.x and 18ef80802a to 8.5.x. Thanks!