Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I have recently installed the FAQ field module and noticed that the fields are pushing outside the main container in the Seven theme.
https://www.drupal.org/project/faqfield
https://stackoverflow.com/questions/48319990/modifying-drupal-8-administ...
I'm not sure how to actually fix this here for this specific field, but I reckon if we used flexbox to layout that page instead of floating divs we'd solve it very quickly. Now that we don't support IE9 and IE10 we can do this.
Comment | File | Size | Author |
---|---|---|---|
#20 | After_patch.png | 25.13 KB | vikashsoni |
#20 | Before_patch.png | 28.72 KB | vikashsoni |
#17 | Claro After Patch.png | 33.72 KB | Lokender Singh2 |
#17 | Seven After Patch.png | 32.79 KB | Lokender Singh2 |
#17 | Seven Before Patch.png | 43.69 KB | Lokender Singh2 |
Comments
Comment #2
cilefen CreditAttribution: cilefen as a volunteer commentedComment #3
cilefen CreditAttribution: cilefen as a volunteer commentedComment #4
zeezack CreditAttribution: zeezack commentedComment #5
cilefen CreditAttribution: cilefen as a volunteer commentedDo not abuse the priority field. I’ve almost closed this as a duplicate of the issue you opened in the module’s queue. We don’t need two efforts to solve the same problem. It has not yet been shown this is a defect of Drupal core.
Comment #6
zeezack CreditAttribution: zeezack commentedI've made a subtheme for seven to fix this.
Comment #7
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedI'm not sure if this is an issue with Seven or not. It's happening because a table is being used with drag/drop handles making that field item wider than the available content space.
here's a screenshot:
Comment #8
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedFrom a quick playaround with flexbox, we'd end up with something like this:
FAQ Field (table field)
Standard body field:
Comment #9
kiran.kadam911Look like this is an issue in seven core I also checked by following steps to reproduce using seven as admin theme and table overlapping issue exists. Also, issue because of the input text size attribute which is 100.
Pls check the attached screenshot & feel free to add your opinion.
Comment #10
kiran.kadam911Kindly review the attached patch.
Even drupal 8.9.x dev having this issue. The best solution to solve this issue keeping width 100% of table form-element(Target every .form-element input that parent is a form-item of a table cell.) as per implementation in the claro theme.
Comment #11
priyanka.sahni CreditAttribution: priyanka.sahni at Srijan | A Material+ Company for Drupal India Association commentedComment #12
priyanka.sahni CreditAttribution: priyanka.sahni at Srijan | A Material+ Company for Drupal India Association commentedVerified by applying the patch #10.It was applied successfully for Drupal 8.0.x-dev.
But i was not able to test the issue fixed for Drupal 8.0.x-dev.Facing below issue.
@kiran.kadam911 Agree with you point.This issue exists for 8.9.x.It is working fine in Safari but the for chrome it exists.
Refer to the screenshots for Chrome and Safari for drupal 8.9.x.
Chrome_Seven
Chrome_Claro
Safari_Seven
Comment #13
priyanka.sahni CreditAttribution: priyanka.sahni at Srijan | A Material+ Company for Drupal India Association commentedComment #14
kiran.kadam911Comment #15
kiran.kadam911Hey @priyanka.sahni
As i am able to see in your screenshot(inspect element) of chrome_seven for that faq question input field(field inside table) not having new css as per added in patch. I tested patch again on my local chrome browser and it's working fine. Adding screenshot for your reference see the inspect element section and css at right side.
Thanks!
Comment #17
Lokender Singh2 CreditAttribution: Lokender Singh2 at Srijan | A Material+ Company for Drupal India Association commentedThanks all for working on this.
I have tested the patch in #10 on chrome and its is working as expected . This is RTBC from my side. Screenshots has been attached for Claro and Seven themes.
Comment #18
PasqualleComment #19
djsagar CreditAttribution: djsagar at OpenSense Labs commentedComment #20
vikashsoni CreditAttribution: vikashsoni as a volunteer and at Zyxware Technologies commentedApplied and verified patch #10 working fine for reference sharing screenshot .....
Comment #24
smustgrave CreditAttribution: smustgrave at Mobomo commentedThis appears to be specific to seven theme from what I can tell. Since seven is removed in D10 moving to the contrib module
Comment #25
djsagar CreditAttribution: djsagar at OpenSense Labs commented