content_translation_update_8400 causes syntax error

No data is lost according to the issue summary so this is not critical without further analysis.

The problem is, \Drupal::entityDefinitionUpdateManager()->getDataTable() somehow returns NULL instead of the table name for the entity.

The following patch does not intend to be a fix, but it does not make the problem worse.

The patch applies cleanly.

I think this is actually a problem which needs to be handled elsewhere, most likely for each individual site.

content_translation_update_8400() only loops over entity types which are managed by the content translation manager, which implies that your entity type is translatable. That, in turn, means that the entity type definition needs to provide a data_table in its annotation, at least until #2232465: Deprecate table names from entity definitions is fixed.

FYI, if we use the normal way, we get correctly the data table. It's just \Drupal::entityDefinitionUpdateManager()->getDataTable() that doesn't work here. I didn't try further, as the attached patch worked for this one-shot problem.

Hi, there is any custom entity without 'data_table', I solved this with a custom update:

/**
 * Implements hook_update_dependencies().
 */
function MY_MODULE_update_dependencies() {
  $dependencies = [];

  $dependencies['content_translation'][8400] = [
    'MY_MODULE' => 8001,
  ];

  return $dependencies;
}

/**
 * Update entity definition.
 */
function MY_MODULE_update_8001(&$sandbox) {
  $entity_schema_repository = \Drupal::getContainer()->get('entity.last_installed_schema.repository');
  $entity_type = $entity_schema_repository->getLastInstalledDefinition('MY_ENTITY_ID');
  $entity_type->set('data_table', 'MY_ENTITY_ID_field_data');
  $entity_schema_repository->setLastInstalledDefinition($entity_type);
}

@see https://www.drupal.org/project/drupal/issues/2328565

Is anyone still experiencing this problem?

The comment in #5 explains that a cause of this would be that an entity type definition is not providing a data_table in its annotation. And thus a solution would be to add the annotation. Also, another workaround using hooks is provided in #8.

Right now I think this could be changed to a support request and 'fixed'.

I'll check first.

Updating the IS. And for now changing to a support request.

If you are experiencing this problem, add a comment.

Adding update tag.