Postponed on #2922701: Migrate UI - refer to modules and add help text

Problem/Motivation

This is a followup to #2922701: Migrate UI - refer to modules and add help text, where in comment #28 it was pointed out that the paths used for the svg files in the migrate upgrade form are fragile.

This is a suitable novice task.

Proposed resolution

Change the paths to the 3 svg files, in core/migrate_drupal_ui/css/components/upgrade-analysis-report-tables.css, used in the migrate upgrade to start from core, eg, change

background-image: url(../../../../misc/icons/73b355/check.svg);
to
background-image: url(/core/misc/icons/73b355/check.svg);

Remaining tasks

Write a patch
Review
etc

CommentFileSizeAuthor
#4 2936399.patch972 byteslmirabile
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

quietone created an issue. See original summary.

quietone’s picture

Status: Active » Postponed

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lmirabile’s picture

FileSize
972 bytes

Patch fixes path as outlined above.

lmirabile’s picture

Status: Postponed » Needs review
Issue tags: +SprintWeekend2018, +SprintWeekendBOS
benjifisher’s picture

The changes look right, but it is hard to test without having a test migration to run. So reviewed, but not tested, by me.

quietone’s picture

Status: Needs review » Postponed

@lmirabile, thank you for the patch.

I installed that patch, navigated to /upgrade and proceeded to the review page where these icons are used. Head is currently using 'error' and and 'check' and those two displayed correctly. The third, 'warning' will not be used again until #2928147: Migrate UI - add 'incomplete' migration status is fixed. It was used before #2922701: Migrate UI - refer to modules and add help text was committed.

I'm all for RTBC here but it is probably best to postpone on #2928147: Migrate UI - add 'incomplete' migration status.