Problem/Motivation

Looking at the latest core run(attached) no TestSuites tests are being run. For example: Drupal/Tests/TestSuites/TestSuiteBaseTest. I've confirmed this running run-test locally. Specifying the class works fine and running tests from phpunit works fine so this is something specific to run-tests.sh

Proposed resolution

Fix simpletest discovery to put testsuite tests into the appropriate type to be run.

Remaining tasks

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neclimdul created an issue. See original summary.

neclimdul’s picture

Title: Run-test.sh missing some tests » Run-test.sh does not run TestSuite tests.
Issue summary: View changes
Status: Active » Needs review
FileSize
692 bytes

Looks like it is specific to the TestSuite directory and a hard coded list in simpletest.

alexpott’s picture

Status: Needs review » Needs work

Let's add something to \Drupal\Tests\simpletest\Unit\TestDiscoveryTest::providerTestGetPhpunitTestSuite() to test this.

neclimdul’s picture

Status: Needs work » Needs review
FileSize
4.6 KB
1.04 KB

Seems reasonable.

neclimdul’s picture

FileSize
1.71 KB

accidentally included #2934670: Escape site root in TestSuite resolution in the "passing" test

The last submitted patch, 4: 2935157-4-fail.patch, failed testing. View results

The last submitted patch, 4: 2935157-4.patch, failed testing. View results

alexpott’s picture

Status: Needs review » Needs work

Another option here is to move the test. Results in less code and less magically locations.

neclimdul’s picture

Status: Needs work » Needs review
FileSize
908 bytes

Cool. We don't really need a test for that then.

neclimdul’s picture

oh, the namespace was being used to pull in the other class and php -l didn't catch it.

The last submitted patch, 9: 2935157-9.patch, failed testing. View results

alexpott’s picture

Status: Needs review » Reviewed & tested by the community

So yeah it's not being run because of the --types option. Nice that it fails though - proves it's being run :)

neclimdul’s picture

right? I'll pretend I meant to do that.

Wim Leers’s picture

I'll pretend I meant to do that.

😂 👌

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: 2935157-10.patch, failed testing. View results

alexpott’s picture

Status: Needs work » Reviewed & tested by the community

Unrelated fail.

larowlan’s picture

Adding credit for @alexpott

  • larowlan committed a401973 on 8.6.x
    Issue #2935157 by neclimdul, alexpott: Run-test.sh does not run...

  • larowlan committed b8d3070 on 8.5.x
    Issue #2935157 by neclimdul, alexpott: Run-test.sh does not run...
larowlan’s picture

Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed as a401973 and pushed to 8.6.x

Cherry-picked as b8d3070 and pushed to 8.5.x

  • larowlan committed b3bf798 on 8.5.x
    Revert "Issue #2935157 by neclimdul, alexpott: Run-test.sh does not run...

  • larowlan committed 06fd53d on 8.6.x
    Revert "Issue #2935157 by neclimdul, alexpott: Run-test.sh does not run...
larowlan’s picture

Version: 8.5.x-dev » 8.6.x-dev
Status: Fixed » Needs work

This broke HEAD on php 5.

Reverted

  • alexpott committed 7e3e377 on 8.6.x
    Revert "Revert "Issue #2935157 by neclimdul, alexpott: Run-test.sh does...

  • alexpott committed 28de462 on 8.5.x
    Revert "Revert "Issue #2935157 by neclimdul, alexpott: Run-test.sh does...
alexpott’s picture

Status: Needs work » Fixed

It was #2932715: PHPUnit testing fails on Windows since #2928249 that broke PHP 5.5 - reverted that one and reverted the revert.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.