Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Problem/Motivation
Looking at the latest core run(attached) no TestSuites tests are being run. For example: Drupal/Tests/TestSuites/TestSuiteBaseTest
. I've confirmed this running run-test locally. Specifying the class works fine and running tests from phpunit works fine so this is something specific to run-tests.sh
Proposed resolution
Fix simpletest discovery to put testsuite tests into the appropriate type to be run.
Remaining tasks
User interface changes
n/a
API changes
n/a
Data model changes
n/a
Comment | File | Size | Author |
---|---|---|---|
#10 | 2935157-10.patch | 952 bytes | neclimdul |
#9 | 2935157-9.patch | 908 bytes | neclimdul |
#5 | 2935157-5.patch | 1.71 KB | neclimdul |
core_test_run.txt | 349.17 KB | neclimdul |
Comments
Comment #2
neclimdulLooks like it is specific to the TestSuite directory and a hard coded list in simpletest.
Comment #3
alexpottLet's add something to \Drupal\Tests\simpletest\Unit\TestDiscoveryTest::providerTestGetPhpunitTestSuite() to test this.
Comment #4
neclimdulSeems reasonable.
Comment #5
neclimdulaccidentally included #2934670: Escape site root in TestSuite resolution in the "passing" test
Comment #8
alexpottAnother option here is to move the test. Results in less code and less magically locations.
Comment #9
neclimdulCool. We don't really need a test for that then.
Comment #10
neclimduloh, the namespace was being used to pull in the other class and php -l didn't catch it.
Comment #12
alexpottSo yeah it's not being run because of the
--types
option. Nice that it fails though - proves it's being run :)Comment #13
neclimdulright? I'll pretend I meant to do that.
Comment #14
Wim Leers😂 👌
Comment #17
alexpottUnrelated fail.
Comment #18
larowlanAdding credit for @alexpott
Comment #21
larowlanCommitted as a401973 and pushed to 8.6.x
Cherry-picked as b8d3070 and pushed to 8.5.x
Comment #24
larowlanThis broke HEAD on php 5.
Reverted
Comment #27
alexpottIt was #2932715: PHPUnit testing fails on Windows since #2928249 that broke PHP 5.5 - reverted that one and reverted the revert.