Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It is never used or initialized. http://cgit.drupalcode.org/drupal/tree/core/modules/block/src/BlockForm....
/**
* The event dispatcher service.
*
* @var \Symfony\Component\EventDispatcher\EventDispatcherInterface
*/
protected $dispatcher;
Comment | File | Size | Author |
---|---|---|---|
#4 | Block_form_after.png | 36.08 KB | riddhi.addweb |
#4 | Block_form_Before.png | 41.54 KB | riddhi.addweb |
#2 | drupal-leftover_dispatcher_declared_blockform-2933280-2.patch | 503 bytes | facine |
Comments
Comment #2
facine CreditAttribution: facine as a volunteer and at Cambrico commentedAttached a patch for 8.3.x, 8.4.x and 8.5.x.
Comment #3
riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented@facine, Yes, your change is correctly implemented & identified. It is never used in file its better to remove it. I checked it manually & try to check it using pareview but not being able to test over pareview. Still it works correctly thanks!..
Comment #4
riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commentedComment #5
googletorp CreditAttribution: googletorp as a volunteer and at Reveal IT commentedThis looks RTBC imo.
Comment #7
Anonymous (not verified) CreditAttribution: Anonymous commentedI wanted to return the RTBC status after random fail. But I don't know, can we just remove protected property by BC policy? If not, than we can just mark this property like
@deprecated
. So, Needs review.Bit history:
$dispatcher
was added in #2339151: Conditions / context system does not allow for multiple configurable contexts, eg. language typesComment #15
longwaveFixed in #3006044: Unused property in BlockForm.php