It is never used or initialized. http://cgit.drupalcode.org/drupal/tree/core/modules/block/src/BlockForm....

 /**
   * The event dispatcher service.
   *
   * @var \Symfony\Component\EventDispatcher\EventDispatcherInterface
   */
  protected $dispatcher;
CommentFileSizeAuthor
#4 Block_form_after.png36.08 KBriddhi.addweb
#4 Block_form_Before.png41.54 KBriddhi.addweb
#2 drupal-leftover_dispatcher_declared_blockform-2933280-2.patch503 bytesfacine
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

facine created an issue. See original summary.

facine’s picture

facine CreditAttribution: facine as a volunteer and at Cambrico commented
Status: Active » Needs review
FileSize
drupal-leftover_dispatcher_declared_blockform-2933280-2.patch503 bytes

Attached a patch for 8.3.x, 8.4.x and 8.5.x.

riddhi.addweb’s picture

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs review » Reviewed & tested by the community

@facine, Yes, your change is correctly implemented & identified. It is never used in file its better to remove it. I checked it manually & try to check it using pareview but not being able to test over pareview. Still it works correctly thanks!..

riddhi.addweb’s picture

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
Block_form_Before.png41.54 KB
Block_form_after.png36.08 KB
googletorp’s picture

googletorp CreditAttribution: googletorp as a volunteer and at Reveal IT commented

This looks RTBC imo.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: drupal-leftover_dispatcher_declared_blockform-2933280-2.patch, failed testing. View results

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review

I wanted to return the RTBC status after random fail. But I don't know, can we just remove protected property by BC policy? If not, than we can just mark this property like @deprecated. So, Needs review.

Bit history:

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Closed (duplicate)

Fixed in #3006044: Unused property in BlockForm.php