Problem/Motivation
Using a custom dialog or using the system tray module and having Classy as base theme.
Having a modal opened and one of the options is set to resizable, the resize handlers are not accessible with a mouse.
Proposed resolution
The padding provide at .ui-dialog {} in dialog.css is overriding the padding provided in dialog.css by jQuery UI.
Setting the padding back to padding: .2em; or removing the padding override will enable the access to the handlers again.
Remaining tasks
Reviewing the patch
User interface changes
The handlers are accessible again with the mouse cursor.
API changes
none
Comment | File | Size | Author |
---|---|---|---|
#42 | interdiff_39-42.txt | 299 bytes | Akram Khan |
#42 | 2928531-42.patch | 828 bytes | Akram Khan |
| |||
#39 | reroll_diff_33_39.txt | 4.06 KB | sahil.goyal |
#39 | 2928531-39.patch | 429 bytes | sahil.goyal |
#38 | 2928531-nr-bot.txt | 146 bytes | needs-review-queue-bot |
Comments
Comment #2
Martijn de WitComment #3
Martijn de WitIt seems that not only dialog.css is setting the padding to zero, also the system tray theme css is setting the padding back to zero.
Updated the patch to remove the padding:0; in dialog.css and off-canvas.theme.css.
Comment #5
Martijn de Witnew patch for 8.5
Comment #6
Martijn de WitComment #7
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commentedThanks for tagging this as an acccessibility issue, I wasn't aware it had been filed.
Can you post screenshots of the difference that the patch makes?
Comment #8
Martijn de WitMaybe this is more a usability issue than an accessibility issue, not sure...
Here is a screenshot with the patch applied. As you can see the handler for resizing is now available. With out the patch the resize option is not accessible with the cursor and the whole resize feature can not be used. In code it is enabled.
Comment #9
Martijn de WitComment #10
Martijn de WitComment #11
Martijn de WitComment #12
Martijn de WitComment #13
Martijn de WitComment #14
Martijn de WitComment #15
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commentedComment #16
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commentedNeeds a re-roll because the off-canvas.theme.css moved from the settings tray module to core/misc/dialog/
The patch in #5 is changing the style of off-canvas dialogs in the module CSS, but it's changing the style of ALL dialogs in the Classy theme. That doesn't sound intentional. Note: the Classy theme doesn't yet have any custom styling for the off-canvas dialog, so perhaps we should add an off-canvas.css to Classy?
Comment #17
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commentedComment #19
visabhishek CreditAttribution: visabhishek as a volunteer and at Azri Solutions commentedJust re-rolled the patch.
Comment #20
gnuschichten CreditAttribution: gnuschichten at ETECTURE GmbH commentedI'm a bit confused.
For me, the Ui-Resizable-W handler is accessible, but only in the "ui-dialog-titlebar". There is a simple reason for that. The ui-front element has a z-index with the value "100". The Ui-size thumb has a z-index of „90“. Increasing the value to „100“ (in reziable-min.js) allows the handler to be accessed on the entire off-canvas element .
But maybe I misunderstand the issue?
Comment #21
gnuschichten CreditAttribution: gnuschichten at ETECTURE GmbH commentedComment #22
gnuschichten CreditAttribution: gnuschichten at ETECTURE GmbH commentedComment #27
djsagar CreditAttribution: djsagar at OpenSense Labs commentedJust re-rolled the patch for 9.2.x-dev.
Please review,
Thanks!
Comment #29
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commentedPatch attached.
Comment #30
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commentedComment #33
sagarchauhan CreditAttribution: sagarchauhan at Srijan | A Material+ Company for Drupal India Association commentedAdded patch to address failed test and also remove padding from Claro theme similar to others.
Comment #34
sagarchauhan CreditAttribution: sagarchauhan at Srijan | A Material+ Company for Drupal India Association commentedComment #38
needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #39
sahil.goyal CreditAttribution: sahil.goyal as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented#33 is not longer applies to the current version 10.1.x as such theme are no longer been available with the D10 rather than the claro with having dialog in. So reroll the patch and attaching reroll_diff.
Comment #40
Gauravvvv CreditAttribution: Gauravvvv at Axelerant for Drupal India Association commentedUpdated attributions
Comment #41
sahil.goyal CreditAttribution: sahil.goyal as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedNeed to built css, facing some issue with yarn, please built css using yarn and update it, Thanx.
Comment #42
Akram Khanadded updated patch fixed CCF #39 and address #41
Comment #43
Akram KhanComment #44
smustgrave CreditAttribution: smustgrave at Mobomo commentedThe issue summary should be updated as this mentions when classy was a base theme, but since classy has been removed from core how is it triggered now? Is this verified an issue in claro?
With a UI issue before/after screenshots will be needed.