Introduce a PHPUnit 6+ compatibility layer for Drupal\Tests\Listeners classes

Yep this is fine, however not yet enough to let tests pass on PHPUnit 6 :( - will report more in #2927806: Use PHPUnit 6 for testing when PHP version >= 7.2

Probably worth trying to cope with namespaces in all Listeners classes, patch coming soon.

Here listener classes all implement FC layers where possible.

So... with the patch in #6 plus others as indicated in #2927806-29: Use PHPUnit 6 for testing when PHP version >= 7.2, I can get a single test to run successfully on PHP 7.2 + PHPUnit 6.5.2

$ ../vendor/bin/phpunit tests/Drupal/KernelTests/Core/Batch/BatchKernelTest.php --verbose

PHPUnit 6.5.2 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.2.0
Configuration: /home/travis/drupal8/core/phpunit.xml.dist

Testing Drupal\KernelTests\Core\Batch\BatchKernelTest
.                                                                   1 / 1 (100%)

Time: 376 ms, Memory: 6.00MB

OK (1 test, 6 assertions)

See https://travis-ci.org/mondrake/imagemagick/jobs/311349139

Bingo!

But now, #6 breaks with PHPUnit 4.8.36 :( ... kinda catch22 situation here...

Aha - cool thanks @alexpott

So I ended up creating a sandbox on GitHub to do testing separate from the Imagemagick module repo I was using so far... so we do not get across the specifics of that module.

https://github.com/mondrake/d8-php72

This is running on TravisCI this script https://github.com/mondrake/d8-php72/blob/master/.travis.yml so we can test under PHP 5.5, 5.6, 7.0, 7.1 and 7.2 with several patches applied (see in the script), letting composer freely update PHPUnit to the highest version supported on each PHP release, then running tests for --group Database.

Results here https://travis-ci.org/mondrake/d8-php72/builds/311462660 :

• PHP 5.5 => PHPUnit 4.8.36 => test pass
• PHP 5.6 => PHPUnit 5.7.25 => 1 test failure
• PHP 7.0 / 7.1 / 7.2 => PHPUnit 6.5.2 => now all fail with PHP Fatal error: Class 'PHPUnit_Framework_TestSuite' not found in /home/travis/drupal8/core/tests/TestSuites/TestSuiteBase.php on line 10 (at least, no more with the listeners)

BTW - I think this is Critical too in the sense that it targets getting a passing test suite on PHP 7.2.

Tried with a single test phpunit tests/Drupal/KernelTests/Core/Batch/BatchKernelTest.php --verbose. All GREEN in all releases/all PHPUnit versions :)

https://travis-ci.org/mondrake/d8-php72/builds/311475324

Wow!

Added a draft CR @ https://www.drupal.org/node/2928884

I could only find this...

+++ b/core/tests/Drupal/Tests/Listeners/DrupalListener.php
@@ -0,0 +1,36 @@
+  /**
+   * Removes deprecations that we are yet to fix.
+   *
+   * @internal
+   */

Shouldn't this be "Listens to PHPUnit test runs." in this context?

#2927806-56: Use PHPUnit 6 for testing when PHP version >= 7.2 and #2923015-50: [PHP 7.2] Incompatible method declarations and #51 show how this patch is necessary to enable testing on PHP 7.2. My contribution in coding is really minor so I'll be bold and RTBC it.

random fail due to https://www.drupal.org/project/drupal/issues/2926309

This looks good to me, just a couple of minor docs nits

1. +++ b/core/tests/Drupal/Tests/Listeners/DrupalComponentTestListenerTrait.php
   @@ -5,20 +5,28 @@
   +   * @param $test
   

   nit: missing the parameter type here?

2. +++ b/core/tests/Drupal/Tests/Listeners/DrupalStandardsListenerTrait.php
   @@ -151,22 +154,58 @@ public function checkValidCoversForTest(TestCase $test) {
   +   * @param $test
   ...
   +   * @param $test
   ...
   +   * @param $test
   

   same?

Committed as 89e64c1 and pushed to 8.5.x

Doesn't apply on 8.4.x

Published change record

Change record versions will need to be updated after backport

I am not sure if this can (or makes sense anyway) be backported to 8.4.x without backporting #2870194: Ensure that process-isolated tests can use Symfony's PHPunit bridge to catch usages of deprecated code too?

I guess this works but its reliance on traits is weird and this isn't really extensible in a way that would help anyone else that ran into the problem as a sitedev or contrib developer. Why didn't we just provide a base class that picks the right phpunit class and call it a day?

Given #2932574: Indicate Drupal 8.4.x is not compatible with PHP7.2 I think the backport won't happen. Mark fixed?

Or they can wait for 2 more months or use current dev snapshot of 8.5.x.

+1 to not backport it.

It looks like this broke testing on Windows. Filed #2932715: PHPUnit testing fails on Windows since #2928249.

I give a try with cherry-pick as below, plus some fixes:

git fetch --all
git checkout 8.4.x
git pull
git checkout -b 2928249
git cherry-pick 89e64c1

Most likely changes for core/modules/simpletest/src/WebTestBase.php could be skipped.

Let's see if it could pass the test...

@alexpott thank you for pointing out the latest update ;-)

Thanks god that the official Release Note for Drupal 8.4.4 already updated as NOT recommend PHP 7.2 which I mainly concern with:
https://www.drupal.org/node/2934241/revisions/view/10777131/10778532