Postponed on #2936365: Migrate UI - allow modules to declare the state of their migrations

Problem/Motivation

This is a follow up to #2922701: Migrate UI - refer to modules and add help text which itself is a followup to #2914974: Migrate UI - handle sources that do not need an upgrade to work on improvements to the UI text. It started from a migrate meeting where it was decided to have 3 categories of module status on the page as well as improvements to the help text.

The Migrate UI 'Upgrade analysis report' lists modules is two categories, those with an available upgrade path and those that are missing an upgrade path. A module with one migration will be listed as having an available upgrade path even if the module really needs more than one migration. Because of that the use may expect a module to upgrade when in fact it won't. And contrib needs a way to inform migrate of its migration status. Using hooks or events was discussed but no decision was made.

Proposed resolution

Create a third category, Incomplete, to identify modules where some of the necessary migrations are working. And use the warning icons for these modules.
Do this in a way, so that contrib modules could override this status if they provide a migration path. This is being done in #2936365: Migrate UI - allow modules to declare the state of their migrations

Remaining tasks

Write a patch, review, commit

User interface changes

Yes, to the Migrate Drupal UI.

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#3 2928147-3.patch7.98 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

Issue summary: View changes
quietone’s picture

Status: Active » Needs review
FileSize
7.98 KB

Here is a start. It still needs tests but is lacking a way to add modules to the new 'incompleteUpgradePaths' list. It works find locally if I add modules to that array in MigrateUpgradeForm. Setting to NR so see if this breaks anything.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

quietone’s picture

Issue summary: View changes
Issue tags: +Needs tests

Tagging and update IS to show that an issue exists for one of the propopals.

quietone’s picture

Issue summary: View changes
Status: Needs review » Postponed

Discussed in migrate meeting. This will be simpler to test when #2932652: Migrate UI - handle extensions that can't be automatically upgraded is resolved.
Postponing

masipila’s picture

Issue summary: View changes

Changed the issue this is postponed on.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

quietone’s picture

Status: Postponed » Closed (outdated)

The work being done in #2936365: Migrate UI - allow modules to declare the state of their migrations has moved away from having three sections in the Review Page. So, closing this as outdated.