Problem/Motivation

As part of #2850973: ConfigEntityInterface::onDependencyRemoval() called with incorrect dependency list we decided to use dependency as a noun and dependent as an adjective for clarity in \Drupal\Core\Config\ConfigManager::getConfigEntitiesToChangeOnDependencyRemoval().

Proposed resolution

Rename method and deprecate old method.

Remaining tasks

User interface changes

None

API changes

Renamed method.

Data model changes

None

Issue fork drupal-2926729

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

bircher made their first commit to this issue’s fork.

bircher opened merge request !977

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and at Nuvole commented
Status: Postponed » Needs review

I don't know what this is postponed on, we can deprecate methods In minor versions.

joachim’s picture

joachim CreditAttribution: joachim at Factorial GmbH commented
Status: Needs review » Needs work

Needs work as CI is failing. Looks good otherwise!

vsujeetkumar made their first commit to this issue’s fork.

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and at Nuvole commented
Status: Needs work » Needs review

ah when using \Drupal::service() static analyzers fail.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Needs work
Issue tags: +Novice

Just one nitpick.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Novice

Changed the comment myself.

As it was only a very small comment changed, I feel free to do a review.
All code changes look good.
The 2 methods are deprecated and have deprecation message testing.
The 2 replacement methods have been added.
The testbot does not return any deprecation messages, therefor all instances of use have been replaced.
All references to the 2 replaced methods in comment have been changed.
The IS and the CR are in order.
For me it is RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Committed 4988dcf and pushed to 9.3.x. Thanks!

  • alexpott committed 4988dcf on 9.3.x 
    Issue #2926729 by bircher, daffie, vsujeetkumar: Rename ConfigManager::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.