#2883680: Force all route filters and route enhancers to be non-lazy deprecated RouteEnhancerInterface and RouteFilterInterface.

@jonathan1055 pointed out in #2883680-108: Force all route filters and route enhancers to be non-lazy that the deprecation message says it's deprecated in 8.4.0, but it's really deprecated in 8.5.0.

So let's fix that.

CommentFileSizeAuthor
#2 2926412-2.patch2.11 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Active » Needs review
FileSize
2926412-2.patch2.11 KB
jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented
Issue summary: View changes

Thanks for raising this issue.

I also noticed that there is an error in the Change Record. For the after example of the 'use' statement the class Drupal\Core\Routing\Enhancer\EnhancerInterface does not exist. I think it should be Drupal\Core\Routing\EnhancerInterface which does exist and allows my 3rd-party tests to pass at 8.5. Same goes for the RouteFilterInterface example.

I added this as a comment on the CR but it has not been noticed/actioned yet, so this issue seems a good place to raise it.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Fixed! You should be able to edit change records too btw :)

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thanks for fixing the CR. Sorry I didn't know I could edit CRs that I had not created.

RTBC for the patch in #2 - this should be committed to 8.6 and 8.5, it is an important correction and a trivial change.

Jonathan

  • larowlan committed 2eaceaa on 8.6.x 
    Issue #2926412 by Wim Leers: Follow-up for #2883680: deprecation message...

  • larowlan committed 9e76e61 on 8.5.x 
    Issue #2926412 by Wim Leers: Follow-up for #2883680: deprecation message...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 2eaceaa and pushed to 8.6.x

Cherrypicked as 9e76e61 and pushed to 8.5.x

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

Thank you Larowlan.