Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Follow-up #2922786-21: Add plach to MAINTAINERS.txt as a provisional framework manager.
Proposed resolution
- Fix indentations in PHPUnit Initiative
- Remove 'Provisional membership: None at this time.' lines
- Fix distance between groups, and align '------' by group name
- Fix distance between group name and subdescription
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#4 | 2923491-4-sign.patch | 2.1 KB | Anonymous (not verified) |
#4 | 2923491-4.patch | 1.7 KB | Anonymous (not verified) |
#2 | 2923491-2.patch | 2.08 KB | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedvaplas created an issue. See original summary.
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #3
xjmWhen we added these sections, we did so deliberately, so that contributors reading the file would know there was an opportunity to become provisional maintainers for those areas. So I don't think it makes sense to remove them here.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commented@xjm, thank you for the explanation! Now the meaning of these lines (and their individual appearance) became more cle
it is special remove line, because we already have 1 empty line in other cases.ar to me. Reverted.
Also, if now 'full' and 'provisional' maintainers can be in same list, maybe it is possible use '- ?' sing for target groups instead?
I do not know the exact groups, so I added just to the last. Specify, please, the desired groups, if this approach is good.
Comment #6
amietpatial CreditAttribution: amietpatial as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented#4 after applying your patch desired result seems good
Comment #7
Anonymous (not verified) CreditAttribution: Anonymous commentedEven six months ago, when I was creating the patch, I asked myself one question: "PHPUnit Initiative" list is really actual? Now this question is only intensifies. What about next version:
@Lendude as provisional maintainer for more than six months now, and he is doing a fantastic job! So, let's remove 'provisional' label.
Unfortunately, @michielnugter is not involved in this process now. I do not know why. All respect to the amount of work that he has done before. But let's refresh actual info.
Comment #8
Gábor HojtsyAgreed with @xjm on keeping the provisional membership item. As for making the list up to date that would not be a formatting issue anymore AFAIS.
Comment #11
Gábor HojtsyCommitted to 8.6.x and cherry-picked to 8.5.x. Thanks!