Problem/Motivation

Follow-up #2922786-21: Add plach to MAINTAINERS.txt as a provisional framework manager.

Proposed resolution

  • Fix indentations in PHPUnit Initiative
  • Remove 'Provisional membership: None at this time.' lines
  • Fix distance between groups, and align '------' by group name
  • Fix distance between group name and subdescription

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 2923491-4-sign.patch2.1 KBAnonymous (not verified)
#4 2923491-4.patch1.7 KBAnonymous (not verified)
#2 2923491-2.patch2.08 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

vaplas created an issue. See original summary.

Anonymous’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
2.08 KB
xjm’s picture

Status: Needs review » Needs work
+++ b/core/MAINTAINERS.txt
@@ -443,10 +443,9 @@ Usability
 - Roy Scholten 'yoroy' https://www.drupal.org/u/yoroy
 - Bojhan Somers 'Bojhan' https://www.drupal.org/u/bojhan
 
-Provisional membership: None at this time.

When we added these sections, we did so deliberately, so that contributors reading the file would know there was an opportunity to become provisional maintainers for those areas. So I don't think it makes sense to remove them here.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
1.7 KB
2.1 KB

@xjm, thank you for the explanation! Now the meaning of these lines (and their individual appearance) became more cle

+++ b/core/MAINTAINERS.txt
@@ -479,18 +481,17 @@ Media Initiative
-
 Provisional membership: None at this time.

it is special remove line, because we already have 1 empty line in other cases.ar to me. Reverted.

Also, if now 'full' and 'provisional' maintainers can be in same list, maybe it is possible use '- ?' sing for target groups instead?

+++ b/core/MAINTAINERS.txt
@@ -442,11 +442,11 @@ Testing
+- ?

@@ -479,18 +480,16 @@ Media Initiative
+- ?

I do not know the exact groups, so I added just to the last. Specify, please, the desired groups, if this approach is good.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

amietpatial’s picture

Status: Needs review » Reviewed & tested by the community

#4 after applying your patch desired result seems good

Anonymous’s picture

Even six months ago, when I was creating the patch, I asked myself one question: "PHPUnit Initiative" list is really actual? Now this question is only intensifies. What about next version:

 PHPUnit Initiative
 - Daniel Wehner 'dawehner' https://www.drupal.org/u/dawehner
 - Len Swaneveld 'Lendude' https://www.drupal.org/u/lendude

@Lendude as provisional maintainer for more than six months now, and he is doing a fantastic job! So, let's remove 'provisional' label.

Unfortunately, @michielnugter is not involved in this process now. I do not know why. All respect to the amount of work that he has done before. But let's refresh actual info.

Gábor Hojtsy’s picture

Agreed with @xjm on keeping the provisional membership item. As for making the list up to date that would not be a formatting issue anymore AFAIS.

  • Gábor Hojtsy committed ebe0eb3 on 8.6.x
    Issue #2923491 by vaplas, xjm: Clean up the MAINTAINERS.txt
    

  • Gábor Hojtsy committed f5f2b3d on 8.5.x
    Issue #2923491 by vaplas, xjm: Clean up the MAINTAINERS.txt
    
    (cherry...
Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.6.x and cherry-picked to 8.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.