Problem/Motivation

Most sites have some sort of a "content admin" or "content manager" role. The list of available permissions for all available workflow transitions can get quite large (similar to that of per node-type operation permissions).

Proposed resolution

Add a single permission that grants access to available transitions.

The access check in StateTransitionValidation::getValidTransitions() can check for this permission and skip the individual permission checks.

Remaining tasks

Write a patch.

CommentFileSizeAuthor
#11 2922266-10.patch2.28 KBbhanuprakashnani
#9 2922266-7.patch2.46 KBbhanuprakashnani
#5 2922266-5.patch66.98 KBbhanuprakashnani
#3 permission-access-all-transitions-2922266-1.patch2.18 KBscott_euser
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mstef created an issue. See original summary.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

scott_euser’s picture

scott_euser CreditAttribution: scott_euser as a volunteer and at Fat Beehive commented
FileSize
permission-access-all-transitions-2922266-1.patch2.18 KB

This is going to fail tests of course, but is this what you're looking for?

New permission "WORKFLOWNAME workflow: Use all transitions."

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented

There seems to be a lot of concern about too many permissions in core, I'm not sure we really want to add another one for each workflow.

Maybe this would be a good thing for a contrib module to add?

bhanuprakashnani’s picture

bhanuprakashnani CreditAttribution: bhanuprakashnani at Google Summer of Code commented
Assigned: Unassigned » bhanuprakashnani
Status: Active » Needs review
FileSize
2922266-5.patch66.98 KB

I have made the changes shown in the above patch. I hope it shows green.

Status: Needs review » Needs work

The last submitted patch, 5: 2922266-5.patch, failed testing. View results

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented 
  1. +++ b/composer.json
@@ -5,7 +5,8 @@
+        "drupal/console": "~1.0"

    I don't think we need drupal/console in core. 

  2. +++ b/core/modules/content_moderation/src/Permissions.php
@@ -23,12 +23,22 @@ public function transitionPermissions() {
+         ¶

    Extra white space.

bhanuprakashnani’s picture

bhanuprakashnani CreditAttribution: bhanuprakashnani at Google Summer of Code commented
Status: Needs work » Needs review
bhanuprakashnani’s picture

bhanuprakashnani CreditAttribution: bhanuprakashnani at Google Summer of Code commented
FileSize
2922266-7.patch2.46 KB

Status: Needs review » Needs work

The last submitted patch, 9: 2922266-7.patch, failed testing. View results

bhanuprakashnani’s picture

bhanuprakashnani CreditAttribution: bhanuprakashnani at Google Summer of Code commented
Status: Needs work » Needs review
FileSize
2922266-10.patch2.28 KB

Please review.

Status: Needs review » Needs work

The last submitted patch, 11: 2922266-10.patch, failed testing. View results

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.