In \Drupal\simpletest\NodeCreationTrait there is 

 * @deprecated in Drupal 8.4.x. Will be removed before Drupal 9.0.0. Use
 *   Drupal\Tests\NodeCreationTrait instead.
 *
 * @see https://www.drupal.org/node/2884454
 */

but there is no class "Drupal\Tests\NodeCreationTrait" it should probably reference \Drupal\Tests\node\Traits\NodeCreationTrait instead.

CommentFileSizeAuthor
#3 drupal-update_comment_namespace-2921860-3.patch575 byteslaughnan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tedbow created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented
Issue tags: +Novice
laughnan’s picture

laughnan
he/him/his
CreditAttribution: laughnan at acreative commented
FileSize
drupal-update_comment_namespace-2921860-3.patch575 bytes

Were you thinking something like this @tedbow?

ikit-claw’s picture

ikit-claw CreditAttribution: ikit-claw as a volunteer commented
Status: Active » Needs review

@laughnan I was just about to upload the same thing. Looks good.

ikit-claw’s picture

ikit-claw CreditAttribution: ikit-claw as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Applied the patch no issues found.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented

I also checked out the patch and it looks good. Thanks to @ikit-claw and @laughnan!

laughnan’s picture

laughnan
he/him/his
CreditAttribution: laughnan at acreative commented

Thanks for checking @ikit-claw and @tedbow!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed ab172aa and pushed to 8.5.x. Thanks!

  • catch committed ab172aa on 8.5.x 
    Issue #2921860 by laughnan, tedbow: \Drupal\simpletest\NodeCreationTrait...
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Fixed » Needs work

Cool, thanks for fixing my typo. :-)

The problem's still in 8.4.x, though.

In fact.. Many of those traits' deprecation messages are incorrect: http://cgit.drupalcode.org/drupal/commit/?h=8.4.x&id=71e5829354208d40c08...

UserCreationTrait, NodeCreationTrait, ContentTypeCreationTrait, BlockCreationTrait are all wrong, in 8.4.x and the unfixed ones in 8.5.x.

Fix in a follow-up or rescope here? Edit: Never mind.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs work » Fixed

Follow-up: #2922371: Numerous deprecation messages for test traits do not reference the correct replacement

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.