Split off from #2873881: [meta] Add Change Record to @deprecated for common.inc because these types of issues need to scoped by change record not file.

To determine how to complete this issue see #2873705: Add change records to all @deprecated code

Related change record: https://www.drupal.org/node/1876852

CommentFileSizeAuthor
#3 2920009-3.patch801 bytesshashikant_chauhan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tedbow created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented
Related issues: +#2873881: [meta] Add Change Record to @deprecated for common.inc
shashikant_chauhan’s picture

shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer and at Iksula commented
Status: Active » Needs review
FileSize
2920009-3.patch801 bytes

Adding patch.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented
Status: Needs review » Reviewed & tested by the community

@shashikant_chauhan thanks again for the patch!

I looked through all commits in the issues related to the CR: https://www.drupal.org/node/1876852

In the commits there were no @deprecated tags added.

So then I look to see where the @deprecated tag for format_date was added. I found #2221771: Mark all simple wrappers in bootstrap.inc and common.inc as deprecated

This was a follow up. there were 3 @deprecated tags added in this issue but they weren't all related to the same changes. So I think the others should be covered in another issue.

This looks good.

xjm credited dinarcon.

xjm credited kwhite.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Adding issue credit. Thanks!

  • catch committed 72c6aff on 8.5.x 
    Issue #2920009 by shashikant_chauhan, tedbow, dinarcon, kwhite: Add...

  • catch committed 49a9136 on 8.4.x 
    Issue #2920009 by shashikant_chauhan, tedbow, dinarcon, kwhite: Add...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kay_v’s picture

kay_v CreditAttribution: kay_v as a volunteer commented
Parent issue: #2873705: Add change records to all @deprecated code »

Removing parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children