When editing shortcut sets it not directly evident what set you are editing. There is literally nothing on the page to tell you what set you are in, and only the url displays the set name.

Screenshot

It would help if the last item in the breadcrumb would be something like Edit myset set, perhaps even in the page title?

CommentFileSizeAuthor
#7 Screenshot at 17-32-13.png68.67 KBmkdok
#2 shortcut_forms_page_title-2918790-2.patch1.8 KBmkdok
Capture.PNG21.61 KBNeograph734
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Neograph734 created an issue. See original summary.

mkdok’s picture

mkdok CreditAttribution: mkdok as a volunteer and at Drupal Ukraine Community for Drupal Ukraine Community commented
FileSize
shortcut_forms_page_title-2918790-2.patch1.8 KB

Hello Neograph734,

Could you apply my patch and test if all works fine? If so I will merge it to dev branch and possibly create a stable release after that.

Thanks.

mkdok’s picture

mkdok CreditAttribution: mkdok as a volunteer and at Drupal Ukraine Community for Drupal Ukraine Community commented
Status: Active » Needs review
Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented

Thanks for the quick response. My laptop broke down hours ago, so I can test once I have a replacement.

Hopefully by the end of this week. I will review once I can.

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented

Hi mkdok,

For what version did you create the patch? It failed to apply for both 8.x-1.0-rc1 and 8.x-1.x-dev.

mkdok’s picture

mkdok CreditAttribution: mkdok as a volunteer and at Drupal Ukraine Community for Drupal Ukraine Community commented

Hello Neograph734,

Hm... It is strange. It was created for version 8.x-1.x-dev. I will check it appliance tomorrow.

mkdok’s picture

mkdok CreditAttribution: mkdok as a volunteer and at Drupal Ukraine Community for Drupal Ukraine Community commented
FileSize
Screenshot at 17-32-13.png68.67 KB

Hello Neograph734,

I've just tried to apply patch. No problems with applying to 8.x.-1.x-dev (please check screenshot). Could you provide more information about you problem to apply, please?

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented

Hmm, it works when using git directly.

I tried it with composer as explained here:

composer update
Gathering patches for root package.
> DrupalProject\composer\ScriptHandler::checkComposerVersion
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing drupal/shortcutperrole (dev-1.x c8a20b6): Cloning c8a20b6ff7 from cache
  - Applying patches for drupal/shortcutperrole
    https://www.drupal.org/files/issues/shortcut_forms_page_title-2918790-2.patch (Breadcrumb)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/shortcut_forms_page_title-2918790-2.patch

I will get to reviewing. Thanks for the fast reply.

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented
Title: Show the current set in the breadcrumb? » Show the current shortcut set in the breadcrumb/title during editing
Project: Shortcut per Role » Drupal core
Version: 8.x-1.x-dev » 8.5.x-dev
Component: User interface » shortcut.module
Issue summary: View changes
Status: Needs review » Active

This works great. However, I came to realize that this is not an issue of this module. Out of the box, Drupal core allows the creation of different shortcut sets. The UI problem is there.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.