Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
For now, the CKEditorIntegrationTest for the DrupalImageCaption plugin doesn't exists.
I would suggest a new method for testDrupalImageCaptionDialog into the CKEditorIntegrationTest
which will check the basic behaviours of DrupalImageCaption CKEditor Plugin.
Proposed resolution
Add a new testDrupalImageCaptionDialog
method.
Should checks for:
- Caption's checkbox is visible when the
filter_caption
is enable - Caption's checkbox is not visible when the
filter_caption
is disable
Remaining tasks
Review & Improve
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#15 | 2916589-15.patch | 2.63 KB | Wim Leers |
#15 | interdiff.txt | 2.99 KB | Wim Leers |
#10 | 2916589-10_110x.patch | 2.78 KB | wengerk |
| |||
#10 | 2916589-10.patch | 2.24 KB | wengerk |
#8 | 2916589-08_110x.patch | 2.76 KB | wengerk |
Comments
Comment #2
wengerkFirst draft for a patch, let's test it with testbot.
Comment #3
wengerkThe patch in #2 works but I use some features scheduled for removal in Drupal 9.0.0 e.g.
assertElementNotPresent
from traitDrupal\FunctionalTests\AssertLegacyTrait
.I switch to the
Drupal\Tests\WebAssert
methods as recommended inDrupal\FunctionalTests\AssertLegacyTrait
.Comment #4
wengerkComment #5
Wim LeersLet's wait for #2912399: Extend the CKEditorIntegrationTest for DrupalImage to land first, so we can adopt the same pattern as that one used.
Comment #8
wengerkRefactoring code following suggestion on #2912399.
Add a patch variante with same tests x110 to detect random fail.
Let's test them.
Comment #9
wengerkNow that the parent isssu 2912399 is merged, let's work on this one.
Comment #10
wengerkHere is the rerolled patch, let's try it with testbot !
PS: Added a patch variante with same tests x110 to detect random fail (as we did for the parent issue #2912399).
Comment #11
wengerkComment #12
wengerkComment #13
Wim Leers@wengerk++
@wengerk++
@wengerk++
WELL DONE!
Sadly, it seems like you found a random failure :( Retesting to see if we can reproduce it.
Comment #14
wengerkI also relaunch twice, to be sure it pass. Let's see
Comment #15
Wim LeersPassed 3 times out of 4, with 110 test runs each. LGTM!
Time for a review.
My main remark:
$this->filtered_html_format
is not actually an object property. Fixed that.Nit: s/filter caption/caption filter/
Nit: 80 cols.
Nit: s/enable/enabled/
Fixed all my feedback. All minor. So going to RTBC right away :)
Thanks again!
Comment #16
alexpottCommitted and pushed 7254e79e8e to 8.7.x and 9d30c1a795 to 8.6.x. Thanks!