PHP 7.1 introduced Warning about invalid strings in arithmetic. And, yes, there is such "dirty" code in Drupal\Core\Menu\LocalTaskManager->getDefinitions() on line 187 ($definition['weight'] contains numeric string):

public function getDefinitions() {
  $definitions = parent::getDefinitions();
  $count = 0;
  foreach ($definitions as &$definition) {
    if (isset($definition['weight'])) {

      // Add some micro weight.
      $definition['weight'] += $count++ * 1.0E-6;
    }
  }
  return $definitions;
}

This is throwing errors on every page load and flooding my database with them!
Also makes the error-log unreadable.

Caused by a typo in a custom_module.links.task.yml file
I put a ; after weight: 10
weight: 10;

CommentFileSizeAuthor
#9 numeric_value_encountered_localtaskmanager-2916464-9.patch630 byteslalit774
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jodan created an issue. See original summary.

Pascal-’s picture

Pascal- CreditAttribution: Pascal- commented
Version: 8.3.7 » 8.4.x-dev

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Pascal-’s picture

Pascal- CreditAttribution: Pascal- commented

After looking through core/lib/Drupal/Core/Menu/LocalTaskManager.php I feel like one of my menu's is causing this, though I'm not sure.
I have no idea where to start looking ...

Notice: A non well formed numeric value encountered in Drupal\Core\Menu\LocalTaskManager->getDefinitions() (line 187 of core/lib/Drupal/Core/Menu/LocalTaskManager.php).
Drupal\Core\Menu\LocalTaskManager->getDefinitions() (Line: 206)
Drupal\Core\Menu\LocalTaskManager->getLocalTasksForRoute('system.status') (Line: 290)
Drupal\Core\Menu\LocalTaskManager->getTasksBuild('system.status', Object) (Line: 358)
Drupal\Core\Menu\LocalTaskManager->getLocalTasks('system.status', 0) (Line: 94)
Drupal\Core\Menu\Plugin\Block\LocalTasksBlock->build() (Line: 203)
Drupal\block\BlockViewBuilder::preRender(Array)
call_user_func('Drupal\block\BlockViewBuilder::preRender', Array) (Line: 378)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 450)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array) (Line: 490)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 47)
__TwigTemplate_f8a17f041581af9829850fd45db45c2b69d8b3a60b80408d416da5d23dbccb61->doDisplay(Array, Array) (Line: 432)
Twig_Template->displayWithErrorHandling(Array, Array) (Line: 403)
Twig_Template->display(Array) (Line: 411)
Twig_Template->render(Array) (Line: 64)
twig_render_template('core/themes/seven/templates/page.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('page', Array) (Line: 437)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array) (Line: 490)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 90)
__TwigTemplate_be8c7bbb9c824f2826368d7c8da984c6279779db72a67fd8056a00bb23b816f2->doDisplay(Array, Array) (Line: 432)
Twig_Template->displayWithErrorHandling(Array, Array) (Line: 403)
Twig_Template->display(Array) (Line: 411)
Twig_Template->render(Array) (Line: 64)
twig_render_template('core/themes/classy/templates/layout/html.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('html', Array) (Line: 437)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array) (Line: 147)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 582)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 148)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object) (Line: 108)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.view', Object) (Line: 158)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 72)
Drupal\shield\ShieldMiddleware->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 657)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Pascal-’s picture

Pascal- CreditAttribution: Pascal- commented
Title: PHP 7.1 - Notice: A non well formed numeric value encountered in Drupal\Core\Menu\LocalTaskManager->getDefinitions() line 187 of core/lib/Drupal/Core/Menu/LocalTaskManager.php » PHP 7.1 - Notice: A non well formed numeric value encountered in Drupal\Core\Menu\LocalTaskManager->getDefinitions() line 187 of core/lib/Drupal/Core/Menu/LocalTaskManager.php caused by syntax error in custom links.task.yml
Issue summary: View changes

This was caused by a typo in a custom_module.links.task.yml file
I put a ; after weight: 10
weight: 10;

Pascal-’s picture

Pascal- CreditAttribution: Pascal- commented
Issue tags: +php7.1
Pascal-’s picture

Pascal- CreditAttribution: Pascal- commented

Would a patch for core/lib/Drupal/Core/Menu/LocalTaskManager.php to check if the value is numeric be enough to solve this?
Also what kind of error should it show / throw / return? (Haven't done any core contrib so far)

Or is this a deeper issue?

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Either we just cast it to int/float or could do an assert() that it is not a string.

lalit774’s picture

lalit774 CreditAttribution: lalit774 as a volunteer commented
FileSize
numeric_value_encountered_localtaskmanager-2916464-9.patch630 bytes
lalit774’s picture

lalit774 CreditAttribution: lalit774 as a volunteer commented
Status: Active » Needs review

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

littlepixiez’s picture

littlepixiez CreditAttribution: littlepixiez as a volunteer and commented

#9 fixes it for me (PHP 7.2).

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Issue tags: -php7.1 +PHP 7.1

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Postponed (maintainer needs more info)
Issue tags: +Needs Review Queue Initiative

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge require as a guide.

With Drupal 9.4 dropping php7.3 and D10 requiring php8.1 wonder if this is still an issue? Could someone please confirm

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Postponed (maintainer needs more info) » Closed (outdated)
Issue tags: +Bug Smash Initiative

Thanks for the report and working to improve Drupal.

There has been no discussion of the problem here for 5 years. As #20 points out, we dropped support for PHP 7.1 some time ago. Therefor, I am closing this as outdated.

Thanks