Since @yched stepped down in 2016, the batch system hasn't had a dedicated subsystem maintainer.
I would like to be considered for this role.
As far as the batch system is concerned, I have put considerable work into #2401797: Introduce a batch builder class to make the batch API easier to use which is the first step into changing the system into using object oriented code.
One that is complete the next step would be #2875151: [META] Implement Batch API as a service.
From there, there is a series of issues attached to #2401797: Introduce a batch builder class to make the batch API easier to use as child / related issues that can be worked on.
Another issue that I've been involved with is #2744663: Batch missing title on screen, which was committed to core in October 2017.
Some other issues I've worked on
- I worked with @rachel_norfolk on #2847651: Improve timezones selector with optgroups to improve the UI.
- I've done manual testing on #2846428: Views add dialog filter searches on label instead of title and #2888189: Update hook_help and DO docs for Inline Form Errors among others.
- I assisted with accessibility testing on #2691971: "Update Notifications" #title repeated for drupal 8 installation in configure site page
Other (non-code) contributions
I volunteer as a mentor at the DrupalCon Mentored Sprints that I attend
I help run the local user group - Drupal Yorkshire
Task | Novice task? | Contributor instructions | Complete? |
---|---|---|---|
Create a patch | Novice | Instructions A patch needs to be created to add John Cook (http://www.drupal.org/u/john-cook) as a maintainer. |
Completed |
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions | ||
Issue to be reviewed by at least one core maintainer | Core Maintainer | ||
Issue to be reviewed by BDFL | BDFL |
Comment | File | Size | Author |
---|---|---|---|
#8 | 2916084-batch-8.patch | 392 bytes | tim.plunkett |
Comments
Comment #2
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commentedThanks @John Cook for applying for this role! It's great that you are offering to fill a vacant position.
John has been a sprint mentor at several DrupalCons, and a keen promoter of the global sprint weekends.
He has carried out reviews in a number of accessibility issues, and I can vouch that he understands the core process well.
@John Could you update the issue summary, so it just lists issues with the square-brackets-hash shortcode syntax? Instead of prose style embedded links. I think that would help other reviewers understand your contributions to the Batch API.
Comment #3
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commentedminor edit, more direct title. bump status.
Comment #4
John Cook CreditAttribution: John Cook at Creode commentedAs requested by @andrewmacpherson I’ve updated the links to use the shortcut markup.
Comment #5
borisson_This should be active, because there's no patch yet.
In any case, @John Cook should comment on the issue confirming that he's read and is comfortable with the core maintainer handbook:
https://www.drupal.org/contribute/core/maintainers#maintainer-definition
and particularly the subsystem maintainer responsibilities:
https://www.drupal.org/contribute/core/maintainers#subsystem
Usually before a new maintainer is added we ask the other subsystem maintainers to approve changes like this, but there's no other maintainers for batch api. So I'm not sure what the next steps are.
Comment #6
John Cook CreditAttribution: John Cook at Creode commentedHi @borisson_.
I have indeed read https://www.drupal.org/contribute/core/maintainers, including the section on "What's the proper way to add myself as a maintainer?" - which prompted me to open this issue.
If I understand the situation, where the batch API currently does not have any other subsystem maintainers, this issue would then move up to the core maintainers, possibly framework maintainers as I believe that the work on this subsystem would be mostly under their purview. I also believe that the BDFL would also need to sign-off this issue as it would need a change to the MAINTAINERS.txt file.
I've added some tasks to the summary, including to create a patch. Also, I've added a novice tag for the that task. Sign-off tasks are also present for core committers and BDFL so that the remaining process is outlined in the summary.
Comment #7
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commentedStill needs an actual patch!
From the Drupal core maintainers governance page.
Let's bat this to the framework managers.
Comment #8
tim.plunkettHere's a patch!
Comment #9
John Cook CreditAttribution: John Cook at Creode commentedThanks for the patch @tim.plunkett.
I’ve updated the summary and tags appropriately.
Comment #10
dawehnerI have worked with @John Cook on #2401797: Introduce a batch builder class to make the batch API easier to use and had a conversation at Drupalcon about it. He has a vision.
Comment #11
rachel_norfolkHaving worked with John on a number of occasions and being aware of his skills, I would feel very happy to know he was maintaining this essential part of Drupal core.
Fab to see you volunteer, John!
Comment #13
catchI've seen some of the recent batch API activity and it's been encouraging. Need to check exactly what the situation is to get this committed, but putting RTBC so other committers see it.
Comment #14
larowlan+1
Comment #15
cilefen CreditAttribution: cilefen at Institute for Advanced Study commentedComment #18
cilefen CreditAttribution: cilefen as a volunteer commentedCommitted and pushed to 8.6.x and 8.5.x. Also, I did the following:
Thank you!