Problem/Motivation

When creating a view with the revision table as the base, the entity links are not available. This means you cannot provide a link to edit the entity.

This is kind of disruptive especially now that the revision table must be the base table for a view if you want to display the latest revision, which is a common use case for administration views + content moderation.

Proposed resolution

Add the same entity links to views using revisions as a base.

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Status: Active » Needs review
Issue tags: +Needs tests
FileSize
581 bytes

Simple fix for a lot of benefit IMO.

Sam152’s picture

Status: Needs review » Needs work

NW for some tests.

Sam152’s picture

Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
2.54 KB

Added tests and updated IS with some of the motivations.

Sam152’s picture

Issue tags: +Workflow Initiative
Manuel Garcia’s picture

Tested the patch manually by setting up a view on my local installation, works as advertised.
+1 to rtbc from me

Sam152’s picture

Status: Needs review » Reviewed & tested by the community

That's good enough for me :)

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2914287-4.patch, failed testing. View results

Sam152’s picture

Status: Needs work » Reviewed & tested by the community

Botfluke, back to RTBC :)

larowlan’s picture

Crediting @Manuel Garcia for taking the time to manually test this

  • larowlan committed 4bd5cab on 8.6.x
    Issue #2914287 by Sam152, Manuel Garcia: Entity links aren't added to...
larowlan’s picture

Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 4bd5cab and pushed to 8.6.x

Cherry-picked as 7d7e37b and pushed to 8.5.x.

  • larowlan committed 7d7e37b on 8.5.x
    Issue #2914287 by Sam152, Manuel Garcia: Entity links aren't added to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.