Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
There's the following call in system_update_8007():
if ($database->driver() == 'mysql') {
$database_schema->changeField($table_name, $field_name, $field_name, $schema_copy[$item_name][$table_name]['fields'][$field_name]);
}
However, the update test in LangcodeToAsciiUpdateTest has
if (Database::getConnection()->databaseType() !== 'mysql') {
$this->pass('This test can only run on MySQL');
return;
}
i.e. uses the databaseType() method instead of the driver() method.
This lets the test fail on a driver that is not 'mysql' but implements for the 'mysql' database.
Proposed resolution
Use the same method both in runtime and test code. In this case, make the test follow the runtime code.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2912973-2.patch | 790 bytes | mondrake |
Comments
Comment #2
mondrakeComment #3
mondrakeComment #8
mondrake