Part of #2909364: [meta] Fix 'Drupal.Commenting.VariableComment' coding standard.

See parent issue for instructions.

CommentFileSizeAuthor
#16 2909369-16.patch10.71 KBlongwave
#12 2909369-12.patch10.26 KBalexpott

Issue fork drupal-2909369

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mfernea created an issue. See original summary.

mfernea’s picture

mfernea CreditAttribution: mfernea at AmeXio commented
Status: Active » Postponed

I opened #2909393: Find missing comments for member variables to clarify the purpose of this sniff.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Unity Technologies commented
Status: Postponed » Active

Coder patch got in.

mfernea’s picture

mfernea CreditAttribution: mfernea at AmeXio commented

How can we use it before it's a part of a release?

zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Unity Technologies commented

Upgrading locally to dev release of drupal/coder.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Unity Technologies commented
Issue tags: +DevDaysTransylvania

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

nginex’s picture

nginex CreditAttribution: nginex at Drupal Ukraine Community commented
Issue tags: +LutskGCW20

Tagging for Drupal Global Contribution Weekend

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Version: 8.9.x-dev » 9.0.x-dev
Status: Active » Needs review
FileSize
2909369-12.patch10.26 KB

Here's a patch. After applying this patch running composer run phpcs -- ./core -ps shows that everywhere this is fixed.

Edit: nope there's more to fix...
Edit: I was wrong this patch does fix this sniff completely.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented

Actually there's no more error introduced by this but there is for #3112829: Fix fails due to Generic.CodeAnalysis.EmptyPHPStatement.SemicolonWithoutCodeDetected due to recent dependency updates - these are issues with HEAD.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 9.0.x-dev » 8.8.x-dev

We backport docs cleanups to all active branches so that cherry-picks keep working where possible. However, enabling a new PHPCS rule is minor-only. The current patch is the 9.1.x version at this point, and then we'd need versions without the change to phpcs.xml.dist for 9.0.x, 8.9.x, and 8.8.x. Thanks!

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Version: 8.9.x-dev » 9.2.x-dev
FileSize
2909369-16.patch10.71 KB

Rerolled for 9.2.x.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented

Tested rerolled for 9.2.x on 9.2.x 😇

Spokje opened merge request !534

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Status: Needs review » Reviewed & tested by the community

The MR is the same as 2909369-16.patch (except for -1 line offset in core/phpcs.xml.dist caused by a commit, made since the patch-file was made).

- Looked at all changes and they make sense to me
- Testbot is green.

RTBC for me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Needs work
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Assigned: Unassigned » Spokje
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented

Created #3208225: Do less unnecessary work in FieldHelpTest

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented

Rebased MR on 9.3.x.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Status: Needs work » Needs review

TestBot likes it, all threads resolved -> Needs Review

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

All review points addressed, this looks OK to me, so RTBC.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Assigned: Spokje » Unassigned

  • catch committed 3502198 on 9.3.x 
    Issue #2909369 by Spokje, alexpott, longwave, mfernea: Fix 'Drupal....

  • catch committed 85022d0 on 9.2.x 
    Issue #2909369 by Spokje, alexpott, longwave, mfernea: Fix 'Drupal....
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

Spokje closed merge request !534

Spokje reopened merge request !534

Spokje closed merge request !534

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.