Problem/Motivation

When working on a View that has many displays with overridden sections, it can be extremely difficult to notice / remember which sections are overridden on which displays. The current style changes for an overridden section is to apply an italic font style to that section. With the default font, an italic style is way too subtle to be noticed easily.

Proposed resolution

We should highlight the entire section so that the overridden section is much more obvious at a glance. For color-blind accessibility reasons, changing the background color would not be sufficient alone. Instead we should supply both a color and a symbol.

User interface changes

In this patch I've added a colored border around the overridden section. Since the affected element does not currently have a border, the new border can act as the symbol which denotes overridden, and the color is helpful to draw the user focus to that area.

This patch adjusts both the views_ui module css, as well as the Stable theme views_ui css since the Stable theme itself overrides the views_ui css. If it is inappropriate for a patch to affect both components, please let me know. I'm happy to submit multiple patches, or otherwise adjust as needed.

Example of change:
example of overridden section with color border

Greyscale:
greyscale version of the overridden section with border

CommentFileSizeAuthor
#17 after_patch.png57.38 KBsmustgrave
#17 before_patch.png56.93 KBsmustgrave
#14 diff_reroll_2908862_3-14.txt1.3 KBankithashetty
#14 2908862-14.patch1.07 KBankithashetty
#3 views-ui-overridden-style.patch1.06 KBdaggerhart
views-admin-css-greyscale.png34.98 KBdaggerhart
views-admin-css.png117.22 KBdaggerhart
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daggerhart created an issue. See original summary.

daggerhart’s picture

daggerhart CreditAttribution: daggerhart commented
Issue summary: View changes
daggerhart’s picture

daggerhart CreditAttribution: daggerhart commented
FileSize
views-ui-overridden-style.patch1.06 KB

Not sure why I never uploaded this patch. Here it is for all you composers out there.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

kerasai’s picture

kerasai CreditAttribution: kerasai at Kerasai commented
Status: Active » Reviewed & tested by the community

Looks great.

Thanks for your contribution!

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Issue tags: +Usability

This would be great issue to discuss during one of our UX calls.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Reviewed & tested by the community » Needs work

The patch does not apply to Drupal 9.3.x.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
CreditAttribution: ankithashetty as a volunteer and at Specbee commented
Status: Needs work » Needs review
FileSize
2908862-14.patch1.07 KB
diff_reroll_2908862_3-14.txt1.3 KB

Re-rolled the patch in #3, thanks!

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Reviewed & tested by the community
FileSize
before_patch.png56.93 KB
after_patch.png57.38 KB

Tested on 9.5 and seems to work fine.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs usability review

The usability review hinted at in #12 has not taken place yet. And the patch does not apply to 10.x since stable has been removed.

I'd also like to see how this looks on a view with lots and lots of things overridden. I have a feeling this will get very very heavy.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.