What are the steps required to reproduce the bug?
Open a "dialog" which contains an iframe which overflows the height of the dialog using iOS 8+ Safari (replicated in iOS 10 on an iPad Pro).

This issue was originally noticed when using Entity Browser (see https://www.drupal.org/node/2781873). This uses an iframe inside a dialog which, on iOS, is not scrollable. You therefore can't view all the items in the browser or use the submit buttons at the bottom.

What behavior were you expecting? To be able to scroll the dialog iframe as you would on a desktop device.

What happened instead? Could not scroll the iFrame (although if you select the very edge of the dialog you can scroll), whole page attempts to scroll instead.

---

Adding -webkit-overflow-scrolling: touch; to the dialog content fixes this issue. It also enables iOS's momentum scrolling for that element (patch to follow).

CommentFileSizeAuthor
#23 2908476-23.patch303 bytesmac501
#13 2908476-13.patch427 bytesvacho
#10 2908476-10.patch427 bytesjohnchque
#7 2908476-7.patch421 bytesmarcoscano
#2 seven-ios-dialog-iframe-scrolling-2908476-2.patch424 bytesa.hover
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

a.hover created an issue. See original summary.

a.hover’s picture

a.hover CreditAttribution: a.hover at CTI Digital commented
FileSize
seven-ios-dialog-iframe-scrolling-2908476-2.patch424 bytes

Here is the patch for this CSS change.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Active » Needs review
a.hover’s picture

a.hover CreditAttribution: a.hover at CTI Digital commented

@cilifen Hmm, I am not sure this does fix the issue after all - I was using an iPad emulator alongside Safari inspector and at first it seems to be working, but it turns out the elmulator was being glitchy.

cilefen’s picture

cilefen CreditAttribution: cilefen commented

Fair enough! The "needs review" is just housekeeping so we get patches tested ASAP. Carry on!

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano at MD Systems GmbH commented
FileSize
2908476-7.patch421 bytes

Just a re-roll, once the previous patch doesn't seem to apply.

I can confirm the bug is reproducible and the patch seems to solve it for me. I've successfully tested it with mobile iOS (emulator) on the following devices:
- iPhone X (11)
- iPhone 8 Plus (11)
- iPhone 7 (10)
- iPad 5th (11)

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

paulpopus’s picture

paulpopus CreditAttribution: paulpopus as a volunteer commented
Status: Needs review » Active

Tested this patch on the iPad Pro iOS 12 but it doesn't fix the scrolling issue when using the actual device. Testing on BrowserStack works fine though.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Active » Needs review
FileSize
2908476-10.patch427 bytes

Rebasing on 8.7.x :)

@paulpopus, when a patch is not fixing a problem the correct status for the issue is Needs work.

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
vacho’s picture

vacho CreditAttribution: vacho at Skilld commented
Version: 8.6.x-dev » 8.8.x-dev
vacho’s picture

vacho CreditAttribution: vacho at Skilld commented
Issue tags: -Needs reroll
FileSize
2908476-13.patch427 bytes

Patch rerolled

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar as a volunteer and at QED42 commented
Status: Needs work » Needs review

Setting back to Needs Review & Triggering bots.

volkerk’s picture

volkerk CreditAttribution: volkerk at Thunder commented

+

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Project: Drupal core » Seven
Version: 9.5.x-dev » 1.0.0-alpha1
Component: Seven theme » Code

The Seven theme has been removed from Drupal 10 core. This issue only appears to affect Seven, so I am moving this to the contributed Seven project.

mac501’s picture

mac501 CreditAttribution: mac501 at NDP commented
FileSize
2908476-23.patch303 bytes