Follow-up to #2278383: Create an injectible service for drupal_set_message()
Postponed on this #2760167: Add \Drupal\Core\Messenger\Messenger
Please add @znerol and @Wim Leers to the commit credit for there detective work.

Problem/Motivation

Remove killswitch from LegacyMessenger. See #2760167-17: Add \Drupal\Core\Messenger\Messenger and onward.

Proposed resolution

From #2760167-25: Add \Drupal\Core\Messenger\Messenger

D/C/Render/Element/StatusMessages::renderMessages() does not specify any cache metadata. Even though it is lazy-loaded, it is still supposed to return the session cache context

Remaining tasks

Make the patch green.

User interface changes

None

API changes

Kill switch will be removed from the LegacyMessenger. LegacyMessenger is internal so removing the constuctor param doesn't break BC.

Data model changes

None

CommentFileSizeAuthor
#10 remove_killswitch_from-2908026-10.patch41.97 KBjibran
#10 interdiff-d1b82a.txt12.11 KBjibran
#8 remove_killswitch_from-2908026-8.patch31.35 KBjibran
#8 interdiff-e2dcd9.txt14.43 KBjibran
#6 remove_killswitch_from-2908026-6.patch19.73 KBjibran
#6 interdiff-d7b1e6.txt1.44 KBjibran
#4 remove_killswitch_from-2908026-4.patch19.69 KBjibran
#4 interdiff-a627e8.txt2.26 KBjibran
#2 remove_killswitch_from-2908026-2.patch17.69 KBjibran
#2 interdiff-8a85b2.txt16.12 KBjibran
2760167-26-PoC.patch2.38 KBjibran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Active » Needs review
FileSize
interdiff-8a85b2.txt16.12 KB
remove_killswitch_from-2908026-2.patch17.69 KB

Fixed some trivial fails.

Status: Needs review » Needs work

The last submitted patch, 2: remove_killswitch_from-2908026-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff-a627e8.txt2.26 KB
remove_killswitch_from-2908026-4.patch19.69 KB

Some more test fixes.

Status: Needs review » Needs work

The last submitted patch, 4: remove_killswitch_from-2908026-4.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff-d7b1e6.txt1.44 KB
remove_killswitch_from-2908026-6.patch19.73 KB

Here is a reroll. I hope #2881348: SessionCacheContext calls getId() on null will fix some fails.

Status: Needs review » Needs work

The last submitted patch, 6: remove_killswitch_from-2908026-6.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff-e2dcd9.txt14.43 KB
remove_killswitch_from-2908026-8.patch31.35 KB

Some more fixes.

Status: Needs review » Needs work

The last submitted patch, 8: remove_killswitch_from-2908026-8.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff-d1b82a.txt12.11 KB
remove_killswitch_from-2908026-10.patch41.97 KB

Some more fixes.

Status: Needs review » Needs work

The last submitted patch, 10: remove_killswitch_from-2908026-10.patch, failed testing. View results

larowlan credited Wim Leers.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.