Installation profiles do not support project:module format for dependencies (backport to D7)

The same patch again with a fixed typo.

… and fix another set of typos in the original patch.

For me the test case (and the problem) is a bit different than in the original ticket description. Having modules with project:module dependencies in as dependency of the installation profile works fine. The problem is having project:module dependencies in the installation profile itself.

In my case I’m always starting with the minimal profile and I have metatag-7.x-1.21 (a module with project:module dependencies) plus its dependencies in the drupal tree.

Without the patch

1. Adding dependencies[] = metatag to minimal.info works.
2. Adding dependencies[] = metatag (=7.x-1.21) to minimal.info fails.
3. Adding dependencies[] = metatag:metatag to minimal.info fails.

With the patch

1. Adding dependencies[] = metatag to minimal.info works.
2. Adding dependencies[] = metatag (=7.x-1.21) to minimal.info works.
3. Adding dependencies[] = metatag:metatag to minimal.info works.

It seems that only the direct dependencies of the profile are a problem.

Note that with Panopoly it also becomes a problem if direct dependencies of the profile use new-style dependencies. Thus the OP. It’s due to this code in Panopoly:

/**
 * Task handler to load our install profile and enhance the dependency information
 */
function panopoly_core_install_load_profile(&$install_state) {

  // Loading the install profile normally
  install_load_profile($install_state);

  // Include any dependencies that we might have missed...
  $dependencies = $install_state['profile_info']['dependencies'];
  foreach ($dependencies as $module) {
    $module_info = drupal_parse_info_file(drupal_get_path('module', $module) . '/' . $module . '.info');
    if (!empty($module_info['dependencies'])) {
      foreach ($module_info['dependencies'] as $dependency) {
        $parts = explode(' (', $dependency, 2);
        $dependencies[] = array_shift($parts);
      }
    }
  }
  $install_state['profile_info']['dependencies'] = array_unique($dependencies);
}

Also the current patch does not actually make the installation profiles support complex dependencies it just removes them before they are being interpreted. The actual fix would perhaps be in #820054: Add support for recommends[] and fix install profile dependency special casing. In the meanwhile this is a viable workaround.

I think this is what the title is supposed to be? Correct me if I'm wrong.