Part of #2847582: Out of The Box experience initiative.

This issue is about creating the theme that implements the designs shown in #2900720: Designs for the Out of the Box experience intiative

How to contribute?

  • Join us in our #out-of-the-box Slack channel. This is where we are meeting to discuss what we are working on and how we want to create the new theme.
  • The theme is now being created as a standard Drupal core theme and we are styling the features and content provided by the accompanying umami demo installation profile. This installation profile is being developed in parallel to the theme.
  • Tasks for the theme continue to be defined as issues in the GitHub theme repository. Note that previous efforts to produce the theme as a living styleguide have been deferred until support exists in Drupal core for such an approach but we continue to use the styleguide issues (#2881910: Create living styleguide for Umami) as our basis for theme production.
  • Designs are attached to the summary of #2900720: Designs for the Out of the Box experience intiative and are also available in InVision.
  • A styleguide pdf is being maintained to detail the designs for implementation as a theme and to track the custom assets that must be created for the demo. Find the latest version attached to the style guide issue in #16
  • Code contributions should be created as Pull Requests on GitHub.
  • There is a Google Drive folder with shared files (documents, assets etc.)
  • We are working on creating an alpha version that will be ready for initial review as soon as possible with the goal of including an alpha version of the demo in Drupal 8.5
  • If you would like to get involved but need some help getting started then please do ask in the Slack channel
CommentFileSizeAuthor
#62 interdiff--2904243-60-62.txt3.12 KBmarkconroy
#62 add-umami-theme-to-drupal-core--no-images-in-theme--2904243-62.patch539.84 KBmarkconroy
#60 add-umami-theme-to-drupal-core--with-images-in-theme--2904243-60.patch590.64 KBmarkconroy
#60 add-umami-theme-to-drupal-core--no-images-in-theme--2904243-60.patch539.36 KBmarkconroy
#57 add-umami-theme-to-drupal-core--with-images-in-theme--2904243-57.patch584.03 KBmarkconroy
#57 add-umami-theme-to-drupal-core--no-images-in-theme--2904243-57.patch532.74 KBmarkconroy
#56 Screen Shot 2018-01-12 at 17.35.14.png31.3 KBlauriii
#56 Screen Shot 2018-01-12 at 17.35.19.png4.68 KBlauriii
#56 Screen Shot 2018-01-12 at 17.35.54.png8.1 KBlauriii
#56 Screen Shot 2018-01-12 at 17.36.02.png9.06 KBlauriii
#51 add-umami-theme-to-drupal-core--with-images-in-theme--2904243-51.patch2.02 MBmarkconroy
#51 add-umami-theme-to-drupal-core--no-images-in-theme--2904243-51.patch526.37 KBmarkconroy
#43 add-umami-theme-to-drupal-core--no-images-in-theme--2904243-43.patch531.12 KBmarkconroy
#43 add-umami-theme-to-drupal-core--with-images-in-theme--2904243-43.patch2.02 MBmarkconroy
#41 add-umami-theme-to-drupal-core--no-images-in-theme--2904243-41.patch530.98 KBmarkconroy
#41 add-umami-theme-to-drupal-core--with-images-in-theme--2904243-41.patch2.02 MBmarkconroy
#37 add-umami-theme-to-drupal-core--no-images-in-theme--2904243-37.patch531.13 KBmarkconroy
#37 add-umami-theme-to-drupal-core--with-images-in-theme--2904243-37.patch2.02 MBmarkconroy
#35 add-umami-theme-to-drupal-core--with-images-in-theme--2904243-35.patch2.02 MBmarkconroy
#35 add-umami-theme-to-drupal-core--no-images-in-theme--2904243-35.patch529.97 KBmarkconroy
#6 theme-progress.png2.14 MBkjay
#11 add-umami-theme-to-drupal-core-2925055-2.patch728.32 KBmarkconroy
#18 add-umami-theme-to-drupal-core-2904243-18.patch1.64 MBmarkconroy
#22 add-umami-theme-to-drupal-core--no-images-in-theme--2904243-22.patch141.02 KBmarkconroy
#22 add-umami-theme-to-drupal-core--with-images-in-theme--2904243-22.patch1.64 MBmarkconroy
#24 screenshot.png151.83 KBmarkconroy
#25 screencapture-du660-ply-st-spaghetti-carbonara-1515019341247 (1).png431.07 KBkattekrab
#25 screencapture-du660-ply-st-taxonomy-term-4-1515030293014.png189.8 KBkattekrab
#25 screencapture-du660-ply-st-search-node-1515031824539.png160.63 KBkattekrab
#25 Articles _ drupal 8 5.x.jpg96.58 KBkattekrab
#25 du660-tablet-home-breadcrumb.jpg183.24 KBkattekrab
#26 Screen Shot 2018-01-04 at 11.59.55.png14.28 KBlauriii
#26 Screen Shot 2018-01-04 at 12.00.03.png25.64 KBlauriii
#26 Screen Shot 2018-01-04 at 12.00.23.png23.06 KBlauriii
#28 add-umami-theme-to-drupal-core--no-images-in-theme--2904243-28.patch692.48 KBmarkconroy
#28 add-umami-theme-to-drupal-core--with-images-in-theme--2904243-28.patch2.18 MBmarkconroy
#29 add-umami-theme-to-drupal-core--with-images-in-theme--2904243-29.patch2.02 MBmarkconroy
#29 add-umami-theme-to-drupal-core--no-images-in-theme--2904243-29.patch527.83 KBmarkconroy
#31 Point No 13 Configure site Timezone Drupal.png448.56 KBTarun Lewis
#31 Point No 12 b.png855.07 KBTarun Lewis
#31 Point No 12 a.png138.81 KBTarun Lewis
#31 Point No 11 (Article padding).png1.18 MBTarun Lewis
#31 Point No 10 (RSS Feed).png812.75 KBTarun Lewis
#31 Point No 9 (Accessibility Issue, New Tab).png357.66 KBTarun Lewis
#31 Point No 8 (Status Messages).png796.22 KBTarun Lewis
#31 Point No 7 (Preview button, Captcha) .png258.61 KBTarun Lewis
#31 Point No 7 (Contact not responsive and breadcrumb missing).png104.44 KBTarun Lewis
#31 Point No 6.png1.07 MBTarun Lewis
#31 Point No 5.png252.03 KBTarun Lewis
#31 Point No 4.png1.53 MBTarun Lewis
#31 Point No 3.png1.24 MBTarun Lewis
#31 Point No 2 (Search result not responsive).png288.54 KBTarun Lewis
#31 Point no 1 (Search not responsive and no result behaviour).png311.71 KBTarun Lewis
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

yoroy created an issue. See original summary.

ckrina’s picture

webchick’s picture

Tagging it up.

thamas’s picture

Issue summary: View changes
yoroy’s picture

Ping! What's the current status? How much of the work is done vs. still left to do? Any blockers, help needed?

kjay’s picture

Issue summary: View changes
FileSize
2.14 MB

I've updated the issue summary a little as we are progressing the theme. See the attached screenshot of a local installation I am currently working on to theme the recipe content type. This is what the theme looks like after the simple process of installing Drupal using the umami demo installation profile, adding a few stub links to the navigation and creating a recipe node.

Header, navigation, search and user menus have basic layout theming in place and a number of other theme issues have been taken care of under our previous process of creating the theme as a living styleguide. This should mean that as those features, such as icons, links, view modes start to get dropped into the installation profile, they will already be partially or fully themed.

Custom icon assets have been created including those shown on the front page and recipe page of the design.

Layouts for the listing grids are well under way.

We were starting to hit blockers with our attempts to implement the theme as a living styleguide, a decision made at DrupalCon in an effort to follow current best practices. In order to accelerate our work, we've switched to producing a standard core theme instead. Though we are doing what we can to set the theme up in a way that should lend itself to adaption at a later stage when core support is available for components.

We are currently focusing our efforts on the recipe content type and recipe listings in order to have one part of the theme that is closer to completion and to demonstrate the theme components that are already in place.

webchick’s picture

It might be good to hit the core queue at some point soon with an "in progress" patch of the work so far, both for the profile and the theme. It's a lot easier to review when it's smaller vs. a completed thing.

kjay’s picture

The Umami theme is progressing well and is working alongside the installation profile which is now installing sample content for us to theme against. I have just given an update for the installation profile work over at https://www.drupal.org/project/ideas/issues/2809635#comment-12345549

Our focus for the theme has been on the recipe listing page and the recipe content type.

Done so far:

  1. General theme-wide styles are in place
  2. Initial work on header, brand and navigation
  3. Tabs
  4. Card View Modes for the recipes
  5. General layout and styling of the recipe content type
  6. General layout and styling of the recipes listing
  7. Integration of custom icons

Field Layout

We are currently discussing switching to a setup that uses the experimental field_layout module. To achieve the more detailed layout of the recipe content type, the theme currently places each of the fields inside of node--recipe--full.html.twig. The problem with this approach is that fields become locked to their themed positions, even if updates are made in the content type's Manage Display settings. For a demo, this could be confusing for users who begin experimenting with how things are pieced together. And of course it is not flexible.

We have an experimental branch of the theme that uses the field_layout module for the recipe content type and if we are to be using the module instead, it would be better to switch now.

Our code and related issues are in github here: https://github.com/lauriii/umami

A project page has been started here: https://www.drupal.org/project/umami

We are currently establishing a workflow for collaboration between the theme and the profile. Documentation for this has been drafted and we plan to update the initiative's main issue page with these details.

thamas’s picture

@kjay I think the Field Layout decision have to be based on more factors:

  • Is Field Layout stable enough to use by the profile?
  • What do we want to demonstrate: twig theming possibilities or sitebuilding possibilities.
  • If we let users to change the layout eg. a recipe will be our desing / theme felxible enough to provide a nice (or at least not so bad result)?

Maybe the third is the hardest point. I think it is easier and quicker to go wit the current solution (and maybe add a note to the recipe content type fields ui in a block about the hardcoded structure) and enhance the profile with field layout in a following phase.

kjay’s picture

@thamas. You have summed this up really well. These are the points we need to discuss and we'll need some feedback soon because this was a point raised at DrupalCon Vienna as being quite important by @lauriii and @ckrina because we are working as a core theme.

It will slow us down if we have switch to this and so this is a conversation around what alpha first version looks like perhaps. Especially since any classes could be switched around at a later date.

markconroy’s picture

Adding patch to add Umami theme to Drupal core.

andrewmacpherson’s picture

Issue tags: +accessibility

Incomplete accessibility review of stylguide v2 PDF (from #2881910-27: Create living styleguide for Umami and the work-in-progress patch in #11 here. I skimmed the CSS, looking for bad accessibility smells by CSS keyword.

Brain-dump, grabbed from the #out-of-the-box Slack channel.

  1. H5 and H6 are indistinguishable visually
  2. Link styles need work, for consistency and clarity. I'm not keen on the dotted link underline. A solid underline is a clearer indication of a link; dotted underlines are variously used for , , keywords, and who knows what else. The difference between dotted underline and solid underline my be lost on users with blurry vision, which in turn makes the focus style a borderline failure of use of colour. I should file an issue for this in Bartik too.
    • Elsewhere, links inside sentences have different styles. In the status messages, there is no underline, and the links are presented in italics. Technically this does not rely on colour alone to distinguish the links, but an underline would be clearer. Itallics are a _different_ shape, but an underline is an _additional_ shape. A reader with colourblindness and dyslexia may have trouble perceiving links in the status messages.
    • In the styleguide, I'd like to see examples of links in all of the specimen blocks of text. Example: blockquotes have a beige background. What if a block quote has a link inside, will it have sufficient contrast? Likewise links inside photo credits, recipe steps, etc.
  3. Still need focus styles for buttons, currently rely on colour change only. (Can't recall whether the styles sheets are suppressing user agent defaults or not.)
  4. A text input focus style would be nice, e.g for the search form block.
  5. The message status (error, warning, info) are currently distinguished by colour alone. Icons would be the easiest solution here. I really like the full-width background, that could help draw attention to the message area.
  6. The way the main nav uses tansparent bottom borders, is likely to break in windows high contrast mode. color: transparent is overridden, so all items will be underlined. I should test that for real.
    • On a positive note, there are very few instances of the transparent keyword in the CSS, so we're off to a good start here with Windows High Contrast themes :-)
  7. Icons may need text alternatives, but it depends where they get used.
  8. The SVGs in the patch have elements. Note text alternatives should be translatable. For standalone SVGs which can be reused, isn't the best approach for text alternatives, which need to vary in context.
  9. Something really confusing: there's a form_alter which adds `.visually-hidden` to the search form submit button. For a sighted keyboard user the button will be operable, but not perceivable. Could also cause difficulty for touch screen users, speech control, or users who input text with something other than a keyboard. A visible button is safer.
  10. The burger-menu clearly needs work; I can see the button is commented-out in the template just now. The menu button is probably best created by JS, because it's serves no purpose without JS.
andrewmacpherson’s picture

Over at #2900720-24: Designs for the Out of the Box experience intiative webchick and I agreed that accessibility sign-off would be be handled by ongoing review in #2881910: Create living styleguide for Umami. However since that one is now postponed, I'll treat this issue as the main target for accessibility sign-off.

I think the goal for accessibility sign-off here should be (roughly), that we have covered as broad an accessibility base as we can at the design and theming level. Something like:

  • Typography
  • Colour contrast, and not relying on colour
  • Links and other interactive components, esp. focus styles and form styles
  • Markup, and other semantics (e.g. aria).
  • ARIA Landmark regions (other aspects of page layout and document outline may be beyond the scope of this issue)
  • Use of icons (clarify purpose and use-cases, text alternatives)
  • A first pass at screen reader testing.
  • Mobile design aspects, e.g. button size, link-list spacing (specific components like mobile nav menu can have a separate follow-up)
  • Avoid doing too much customization of core components, beyond visual CSS styling. I'm thinking of the basic fixtures like form elements, primary/secondary tabs, pagers, breadcrumbs, etc.. If there's a need to customize those in a significant way, separate follow-up issues would be keep accessibility more managable.
  • ... anything else that occurs to us before committing this.

I'm also proposing that we try to address as many of the new success criteria form WCAG 2.1 as we can. it's still a W3C working draft, it's far enough on that we can get started, and reduce the need to retrofit it later. The timing is right, I think - see comment #33 in #2847582-33: Out of The Box experience initiative

There can of course be follow-up issues, accessibility aspects we miss (or deliberately postpone) first time around, which can be tracked as part of the parent issue for the whole initiative.

Thoughts? We haven't done design as big as this since the Seven and Bartik themes, and it's exciting stuff.

andrewmacpherson’s picture

yoroy’s picture

Thanks for the review @andrewmacpherson. It would be good to make a distinction between must, should, could issues here, especially regarding the new WCAG success criteria. We need to strike a balance: on the one hand we want this to have exemplary accessibility, on the other hand, we should probably not introduce as yet unfinished standards as possibly delaying factors towards a first shippable version of this. I think you're already pointing that out in #13 though :).

Maybe the team can chime in on whether they prefer an accessibility meta issue on d.o. that tracks individual tasks.

andrewmacpherson’s picture

Re: #15

It would be good to make a distinction between must, should, could issues here, especially regarding the new WCAG success criteria.

Historically, WCAG 1.0 used must/should/could to refer to A, AA & AAA respectively, but WCAG 2.0 removed this engineering-style language. Our accessibility gate says AA, so we'll certainly treat AAA as "could". Many regional regulations are converging on a requirement for WCAG AA, to the extent that it's becoming more like "AA = must, AAA = could". Meh, I preferred it when we could treat it as three levels.

From my list in #13, I'd prioritize the issues around colour, focus styles, and link styles.

As for WCAG 2.0 vs WCAG 2.1...

we should probably not introduce as yet unfinished standards as possibly delaying factors towards a first shippable version of this. I think you're already pointing that out in #13 though

Kind of, but I'm leaning the other way; the current state of WCAG 2.1 is something we can design for now. Retrofitting design changes after shipping is usually awkward. Clients are typically very resistant to colour changes in particular. (I'm not saying the Drupal project is a typical client, but, you know...). Strong focus styles are also best done early (because WCAG 2.0 addresses focus styles poorly, and WCAG 2.1's UI components contrast is about fixing this).

From everything I've read, the WCAG 2.1 working group seems to think it is well on schedule, and their timeline is intentionally fast. The definitions of the new Success Criteria are considered stable; several controversial success criteria have been shelved in the interests of getting this WCAG update finalized. The remaining work is about consistency, and fleshing out the supplementary documents. It's currently a Working Draft (~alpha). The timeline for WCAG 2.1 expects a Candidate Release (~beta) in Jan 2018, and a Recommendation (~stable) in July 2018. How does this compare with an alpha/beta/stable timeline for the Out-of-the-Box initiative? It seems likely that WCAG 2.1 will be at the Candidate Recommendation stage by the time 8.5.0 is released, and hopefully a final Recommendation before Drupal 8.6.0.

Maybe the team can chime in on whether they prefer an accessibility meta issue on d.o. that tracks individual tasks

The target issue for accessibility review has already moved twice :-) With GitHub in the mix too, I'm finding it hard to keep track of where I'm supposed to be commenting. I'd welcome an a11y tracker issue, and it's a place to direct other a11y contributors towards.

andrewmacpherson’s picture

There are a few combinations which have a ratio of 3:1, which is the special exception threshold for big text. The text sizes aren't big enough though. Buttons pass in their resting state, but fail on hover.

The icons could do with some hints in the styleguide about size, and where they'll be used.

The magnifiying glass icon for the top search looks about the same height as regular text, but Portland Orange on white is just 3:1 contrast ratio. Since it's acting as the visible form label, I'd interpret this as failing the new Graphics Contrast SC in WCAG 2.1. (In v1 of the styleguide the magnifiying glass was Pine Green which has contrast 4.5:1 on white.)

markconroy’s picture

Hi All,

Here's an updated patch with more work done. The theme is nearing completion and could really do with some independent code reviewers. This is quite close to the version of the theme we hope to commit to 8.5.x-alpha1 on January 15th, so thoughts on they work would be very much appreciated so we can make any amends that are needed before 8.5.0 is released in early March.

webchick’s picture

Status: Active » Needs review

Marking "needs review"... yay! :D

Status: Needs review » Needs work

The last submitted patch, 18: add-umami-theme-to-drupal-core-2904243-18.patch, failed testing. View results

vijaycs85’s picture

Few minor review comments.

  1. +++ b/themes/umami/composer.json
    @@ -0,0 +1,5 @@
    +    "description": "The theme used for the out of the box initiative."
    

    Missing license property. Should be same as core?
    "license": "GPL-2.0+",

    Minor: Also shouldn't we say something about the theme on description?

  2. +++ b/themes/umami/composer.json
    @@ -0,0 +1,5 @@
    \ No newline at end of file
    

    Minor: Missing empty line at EOD

  3. +++ b/themes/umami/umami.info.yml
    @@ -0,0 +1,26 @@
    +  banner_top: Banner Top
    ...
    +  page_title: Page Title
    

    Minor: Missing quotes

markconroy’s picture

Hi Vijay,

Thanks for those comments.

I haven't added a licence, since this is going to be part of core it will be covered under core's licence.

I have now added a new line at the end of the composer.json file - but I presume this file will be removed before we commit this to core.

I have added quote marks around multi-word region names.

---

Also, I am uploading two versions of the patch here:

  1. Patch with no images from the theme - except the logo.svg - should make it easier for opening/code review
  2. Patch with images from the theme - to be used if you want to actually install it and see how things work/use simplytest.me
jibran’s picture

The theme is missing the screenshot as per https://du6uz.ply.st/admin/appearance.

markconroy’s picture

Issue summary: View changes
FileSize
151.83 KB

Hi Jibran,

Thanks for that info. I have created a screenshot now, it will be in the next commit/patch.
screenshot for umami theme

kattekrab’s picture

I've been having a play via simplytest.me - this is amazing work, and definitely hits the mark as a better "out of the box" experience for Drupal.

I like that it shows how the same content can be displayed in different ways, and exposing different fields.
I like that it's using term references, definitely a great core feature.

Well done everyone.

Nitpick: update copyright date in footer from 2017 to 2018, perhaps even make do "$this_year"? Is that even possible in an install profile?

Here's thoughts off the top of my head as I roam around this install. If there's any consensus around these, I'll spin them out into seperate tickets for followups.

For testing: I created a new recipe - spaghetti carbonara! Visible temporarily here:
https://du660.ply.st/spaghetti-carbonara and a screenshot attached.

Clicking a term ref link leads to a page that looks un-styled and the search pages seem a bit undercooked too.

Mobile and desktop breakpoints seem to work well, but intermediate widths seem less polished.

On the articles page: Should "View Recipe" say "View Article" ?

On tablet and mobile (both ios) I'm getting a stray "home" link above the Recipes section on the homepage, that I can't replicate on macos/chrome. Is it the breadcrumb?

lauriii’s picture

Great work everyone! The design looks great and it feels great to see it being turned into an actual Drupal theme.

I will do another more thorough review but here's my feedback so far. Please approach if any of the feedback feels cumbersome so we can try to evaluate if that could be postponed to an issue that could be worked on later.

  1. +++ b/core/themes/umami/README.md
    @@ -0,0 +1,94 @@
    +# Umami
    

    We most likely should just remove the README from the core version of the theme. All the relevant parts should be moved to https://www.drupal.org/documentation.

  2. +++ b/core/themes/umami/composer.json
    @@ -0,0 +1,5 @@
    +{
    

    We should remove this since other core themes don't have a composer.json as well

  3. +++ b/core/themes/umami/css/components/blocks/branding/branding.css
    @@ -0,0 +1,17 @@
    +a.site-logo {
    
    +++ b/core/themes/umami/css/components/blocks/search/search.css
    @@ -0,0 +1,49 @@
    +div.form-type-search {
    
    +++ b/core/themes/umami/css/components/navigation/menu-account/menu-account.css
    @@ -0,0 +1,20 @@
    +a.menu-account__link {
    
    +++ b/core/themes/umami/css/components/navigation/menu-main/menu-main.css
    @@ -0,0 +1,89 @@
    +a.menu-main__link {
    ...
    +a.menu-main__link:hover,
    +a.menu-main__link.is-active:hover,
    +a.menu-main__link:focus {
    ...
    +a.menu-main__link:active,
    +a.menu-main__link.is-active {
    
    +++ b/core/themes/umami/css/components/navigation/tabs/tabs.css
    @@ -0,0 +1,35 @@
    +ul.tabs {
    ...
    +.tabs li.is-active {
    

    We should remove all references to html elements where possible. It makes both refactoring and writing CSS using SMACSS more difficult since it affects the weights.

  4. +++ b/core/themes/umami/css/components/blocks/footer-promo/footer-promo.css
    @@ -0,0 +1,47 @@
    +.footer-promo__text a {
    ...
    +.footer-promo__text a:after {
    
    +++ b/core/themes/umami/css/components/navigation/tabs/tabs.css
    @@ -0,0 +1,35 @@
    +.tabs li {
    ...
    +.tabs a {
    ...
    +.tabs a.is-active {
    ...
    +.tabs a:focus,
    +.tabs a:hover {
    

    Please go through the CSS selectors using elements. We should try convert as many of them to classes as we can since it will make future changes easier for us.

  5. +++ b/core/themes/umami/css/components/content-types/recipe/recipe.css
    @@ -0,0 +1,239 @@
    + * This file is used to style the recipe using the 'full' view mode.
    ...
    +.page-node-type-recipe .node.node--view-mode-full .field--name-field-recipe-category {
    

    The CSS selector doesn't reflect the comment. This CSS only affects recipe views in full view mode rendered using default route. We should probably change the selector not to rely on the .page-node-type-recipe class.

  6. +++ b/core/themes/umami/css/components/content-types/recipe/recipe.css
    @@ -0,0 +1,239 @@
    + .page-node-type-recipe .node.node--view-mode-full .field--name-field-recipe-category {
    
    +++ b/core/themes/umami/css/components/content/full/node-full.css
    @@ -0,0 +1,63 @@
    +.node.node--view-mode-full {
    

    According to BEM we can trust that element with .node--view-mode-full class will always contain .node class, hence it can be removed from the selector.

  7. +++ b/core/themes/umami/css/components/views/promoted-items.css
    @@ -0,0 +1,157 @@
    +.view-promoted-items--single > .view-content .views-row {
    +  ¶
    +}
    ...
    +.view-promoted-items--single > .view-content .views-row .node__content {
    +  ¶
    +}
    ...
    +.view-promoted-items--single > .view-content .views-row .node__meta {
    +  ¶
    +}
    ...
    +.view-promoted-items--single > .attachment-after {
    +  ¶
    +}
    ...
    +.view-promoted-items--single .attachment-after .views-element-container {
    +  ¶
    +}
    ...
    +.view-promoted-items--single .attachment-after .view-promoted-items--double {
    +  ¶
    +}
    ...
    +.view-promoted-items--double {
    +  ¶
    +}
    ...
    +.view-promoted-items--double .view-content {
    +  ¶
    +}
    ...
    +.view-promoted-items--double .views-row {
    +  ¶
    +}
    

    There are some empty selectors. Are these kept intentionally?

  8. +++ b/core/themes/umami/css/layout/layout.css
    --- /dev/null
    +++ b/core/themes/umami/js/components/navigation/menu-main/menu-main.js
    

    We have to create ES6 version of this file. More info: https://www.drupal.org/node/2815083

  9. +++ b/core/themes/umami/templates/components/banner-block/block--bundle--banner-block.html.twig
    @@ -0,0 +1,54 @@
    +{# TODO: todo: Discuss this approach of inline image plus background image #}
    

    There's multiple todo's in the code. We should remove as many of them as we can, and if there are some difficult problems we should create issues for those and they should be referenced in the todo comments.

  10. +++ b/core/themes/umami/umami.theme
    @@ -0,0 +1,64 @@
    + * @param $variables
    + * @param $hook
    

    Nit: hook functions don't have to document their parameters.

  11. +++ b/core/themes/umami/umami.theme
    @@ -0,0 +1,64 @@
    +function umami_form_alter(&$form, FormStateInterface $form_state, $form_id) {
    +  if ($form['#id'] == 'search-block-form') {
    

    Any reason not to use https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21fo... instead?


  12. Some CSS is leaking to the admin menu

  13. Page layout breaks when the admin menu is in vertical mode.

  14. Should we add some horizontal spacing to the header?

"

kjay’s picture

@kattekrab thank you for the review. I've created corresponding issues for your feedback in #25 in GitHub.

markconroy’s picture

Hi All,

Here are two more patches for the theme - one with images (needed to install the theme to see things correctly) and one without images (for use when doing code reviews).

markconroy’s picture

Two more patches - especially for you @lauriii! - one with images, one without.

I've attended as much as possible to items 1 - 10 from your review.

ES6 version of menu.js code now has an issue here - https://github.com/lauriii/umami/issues/130

andrewmacpherson’s picture

Re: #26.11

Any reason not to use https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21fo... instead?

We won't need this form_alter at all, as the reason for it is going away. At the moment it's just making the search button invisible, but this is an a11y problem and we need to keep a visible search button. There's a design already in github issue #119 More accessible search in header

Re: #29

ES6 version of menu.js code now has an issue here

I've added an a11y plan to that issue.

Tarun Lewis’s picture

Hi All,

Great initiative with OOTB! Keep up the good work! I have reviewed it, and have observed the following. I have attached screenshots for each point as well.

1. Search on mobile - result content listing not responsive.

2. Search is not responsive and no result behavior - spacing & segregation

3. Spacing between 22 and minutes & 20 and minutes.

4. Difficulty: middle (middle should be clickable)

5. Some of the content is not getting converted properly (&#189)

6. Breadcrumbs missing in Category & Tag pages

7. Contact Form is not responsive, Captcha is missing, Preview should not be there, Breadcrumb missing.

8. Contact Form status messages not aligned properly.

9. Accessibility Issue & Find Out More link should open to new tab.

10. Clicking on Category or Tag gives an RSS feed icon. Nowhere else is the RSS icon present. RSS icon is also very tiny and easy to miss.

11. Articles heading padding is not proper.

12. Clicking on Baked Camembert:
a. button on banner points to Page not found.
b. Title, description and button that appears on the banner in desktop, appears below the banner in mobile (android).

13. Default Timezone should be dependent on Default Country.

kjay’s picture

@Tarun Lewis thank you for taking the time to provide a review. We will feed this review into the issue tracking we are managing on Github.

markconroy’s picture

Hi @Tarun,

Thanks a lot for this review. I'm going to start tackling those now (or at least the ones that are in contention for MVP). just a few very quick thoughts on them to give you some pointers on ones I may not fix just now:

1. Search on mobile - result content listing not responsive.

2. Search is not responsive and no result behavior - spacing & segregation

We have not done any work on search pages yet, so I'll see about what we can do as a minimum to get this looking acceptable.

3. Spacing between 22 and minutes & 20 and minutes.
Well spotted - thanks.

4. Difficulty: middle (middle should be clickable)
This is not clickable because it is not a taxonomy/entity field. It's just a simple select list.

5. Some of the content is not getting converted properly (&#189)
Well spotted - thanks.

6. Breadcrumbs missing in Category & Tag pages
We have no designs for breadcrumbs. They are part of a wider discussion, but I'll see what I can do.
-- update - we have the 'Home' breadcrumb on those pages, which is all we have because the url is using the /taxonomy/term/tid rather than something like recipe-type/vegetarian (but that would mean we'd also need a /recipe-type/ page)

7. Contact Form is not responsive, Captcha is missing, Preview should not be there, Breadcrumb missing.

8. Contact Form status messages not aligned properly.

We also have no design for a contact form (I don't think), but it's in the spec, so I'll try fix that up now as well. There will be no captcha on the form since Drupal does not have a captcha in core.

9. Accessibility Issue & Find Out More link should open to new tab.
As far as I know all our links will open in the same tab. This is an accessibility best practice.

10. Clicking on Category or Tag gives an RSS feed icon. Nowhere else is the RSS icon present. RSS icon is also very tiny and easy to miss.
We haven't done any work on this yet - that's just the default view for those features.

11. Articles heading padding is not proper.
Yes, that's on my todo list. Thanks.

12. Clicking on Baked Camembert:
a. button on banner points to Page not found.
b. Title, description and button that appears on the banner in desktop, appears below the banner in mobile (android).

For a. this is hardcoded just for now, so we can get theming done on it. It'll be fixed later.
I'll look at b. on this. I'm not sure what we can do given the nature of small screens.

13. Default Timezone should be dependent on Default Country.
Correct. I'll get that fixed.
-- update - The most generic timezone is UTC. It's either we set it as UTC or set it as a specific country. We have the site set up so that users can change their timezones themselves.

Like I say, thanks a lot for that review - hopefully you'll continue to review patches as we make them available. A lot of our reviews so far are people reviewing the coding standards (which is great) but not many actually installing the site - so THANKS.

Petr Illek’s picture

Hi all,
I’m glad this initiative exist. It is highly needed. I’ve watched it only occasionally and most probably I missed the key discussions. Thats why some of my notes may sound negative or completly off at this point.

Anyway I’m happy I can contribute back at least with review and few notes.

For start I must admit I like the design. Its modern looking and calm –> good fit for the recipe website.

I’ve spin up a local site and done a quick visual review. I’ve used the patches mentioned in https://www.drupal.org/project/drupal/issues/2809635#comment-12403030 in case there was some more progress done in between.

Styling issues

Layout

  • Missing side padding for various element on smaller screens (from 800–1200px)

Header area:

  • Search field not intuitive, can the magnifying glass be made clickable to send the form?
  • Account menu – lacks visual clue for activity (hover)

Typography

  • Usage of fake bold. – I know it will make the user to load more fonts, but it will be nicer. :)

Responsive Menu

  • Hamburger icon sums when hovering over, because of the border around.
  • Switch hamburger with search button (I believe majority of people hold phone mostly in right hand – the hamburger will be easily reachable for thumb there)
  • Menu item has a display: block; – it will stretch to full width, so I don’t need to aim directly on the word.
  • Menu item some padding top and bottom – easily touchable

Contact page

  • Inputs on small screen too large (width: 100%)
  • Email address is validated client side – only red glow around the field without any visible description. After while small message appears with description whats wrong.

Recipes view list

  • Last row is weird with justify-content: space-between

Notest

As this should serve as an Out of box experience showcase I think it is partially failing in current implementation.
I will provide few posible example use cases:

1) I’m a manager evaluating new CMS option for company.

  • Can it be nice – OK Umami is nice
  • Can it solve all my needs – OK there is thousand of modules on D.O.
  • Oh I can see lots of examples at http://www.drupal.com/, I don’t want to spin up this Umami and go inside. –> FAIL. Do we need to include it in Drupal for these people?

2) I’m a general website developer with some experience.

  • I spin up Umami
  • Drupal is known for being field-able –> nice, here are the fields. Oh cool manage display and view modes, I will reorder the field and see what happened –> Nothing. << BIG BIG confusion here.
  • OH finally found it in the theme in the templates (node--recipe--full.html.twig < cool they use Twig). Still little bit confused why the Manage display is not working.
  • Hmm why are these SVG’s here? Can they be in CSS, if they cannot be uploaded somehow directly in UI?

3) I’m a newbie website developer who was told Drupal is awesome.

  • I spin up Umami
  • Drupal is known for being field-able –> nice, here are the fields. Oh cool manage display and view modes, I will reorder the field and see what happened –> Nothing. << BIG BIG BIG confusion here.

Template

As can be seen my main concern is about the templates. I can see this approach (with completely bypassing Manage display screen) can have its place on project with multiple content types sharing similar view modes.
But I consider it as an advanced approach. I believe this shouldn’t be part of the out of box experience – dive deep into template, Kint through variables and print the required field.

Also there was a big hype about Layout discovery in core few months ago – its not used here. I don’t see anything so special in the template which cannot be done in the UI.
Why the “What you'll need and how to make this dish” is inside the template? Why not use custom block and reference it with default value in the content?

Basically I don’t know who is the target audience here, but as I said in the beginning I I missed the key discussions, so these are only my consideration. Maybe I did not understand what this profile is for. ;)

Additional content

If you are still looking for content I can offer a few Drupal related recipes I’ve done over the years for our demo pages. I do have the original files if needed different crop etc.

Have a nice weekend
Cheers Petr

markconroy’s picture

Hi Petr,

Thanks for those comments. I'll try get around to them on Sunday or Monday (or Tuesday).

Attaching another set of patches here which some small improvements - notably, breadcrumbs now place the current page title as the final breadcrumb (we should have that available in core).

Tarun Lewis’s picture

Hi @markconroy,

Thank you for the quick reply. I had forgotten to mention in point no. 9, the accessibility issue referred to the color that the contact link takes after being clicked. Against the gray background the green color of the link is lost. In fact because of the high power my eyes have, I had almost missed it.

Will add on the patches you have given and check them out during the course of the day.

markconroy’s picture

New patches with some fixes to Drupal-ci's coding standards, and new work on the search block in the header.

thamas’s picture

The new search in the header mentioned by Mark in the previous comment is still work in progress, it is not finished yet!

markconroy’s picture

oops ... silly me. I thought I saw a commit for it when I merged the last round of code.

I'm sure it will be very welcome. Thanks Thamas.

thamas’s picture

Hi Petr Illek,

Thanks for the review. I won't answer every point but I will create some issues based on your review.

About layout discovery: we discussed it at some point, but decided not to go with that because of the close deadlines and the status of field layout which would be needed too. But Umami may switch in later version.

Your notes about the use cases can be relevant but could be better discussed in the parent issue: https://www.drupal.org/project/ideas/issues/2847582

And thanks for the recipes offer! I mentioned it to @kjay who deals with them and he will contact you!

ok_lyndsey’s picture

Petr's three points on evaluation raise good immediate examples of expectation and purpose. I'll start some documentation (as offered in slack) but this is something that needs to be clear to users. It fits with the themes that were raised by the commerce team - an expectation is going to be that people can choose this profile, modify it and have a pretty site fast.

I've started writing up things that a tester can play with and can start to move around and change - but the relationship to the theme will mean we need some specific examples of what people can add - or it will break. My doc I've started is here - note I've written it for my purposes and I'll adapt to standard - but if people have comments/ideas go for it https://docs.google.com/document/d/16IsrfsffnW3zvBTA3EUErGG6TimoubrEPnuHxh3PU8A/edit?usp=sharing

TBH when the theme was initially raised I thought an aim was to produce something closer to complete for people that struggled with the learning curve of theme design.

markconroy’s picture

kreynen’s picture

Status: Needs review » Needs work

If the Umami theme is only intended to be used with the Umami profile, it does not belong in core. It belongs in the profile.

markconroy’s picture

Status: Needs work » Needs review

Hi @krenyen

I agree. I made that point on slack this evening.

However that'll make the review even larger on the other thread to create a new demo installation profile, so I'm going to leave it in core/themes until we are ready to commit, so it's easier for people to review this item as a standalone item.

andrewmacpherson’s picture

Re: #44 - I think I asked about that a while back., but it might have been in a Slack channel. I agree, the demo theme should be in the demo profile. Otherwise, a site builder can reasonably be expected to use it on a real website.

At the moment, the profile and theme patches are on separate issues. We could move the theme in a trivial follow-up task, or prepare a combined theme + profile patch before it gets committed.

The last submitted patch, 29: add-umami-theme-to-drupal-core--no-images-in-theme--2904243-29.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 28: add-umami-theme-to-drupal-core--no-images-in-theme--2904243-28.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 22: add-umami-theme-to-drupal-core--no-images-in-theme--2904243-22.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

markconroy’s picture

Andrew,
I'll probably create a mega patch on Saturday or Sunday when we are ready to commit, with the profile code and the theme inside that.

markconroy’s picture

Some more patches (I think we're getting close now!).

One without images for code review purposes and one with images for installing to test.

These patches also have the composer.json, README.md, and .gitignore removed since they will not be in the final version.

webchick’s picture

So over in #2809635-91: Create experimental installation profile, I attempted to test the profile just on its own, and it turns out you can't, because it has a dependency on this theme. Which puts us in kind of an "interesting" place in terms of how to get these things committed.

I noticed this patch is adding the theme to core/themes and not core/profiles/umami_demo, and marking it hidden = true; presumably because of this chicken/egg problem. But that's creating quite some stuff to clean up later. :\

If we add the theme at core/profiles/umami_demo in this patch, does this accomplish the same goal of hiding the profile (because umami_demo.profile doesn't exist), but without requiring some fancy git mv magic later on? Was that already tried and failed, or?

markconroy’s picture

Hi webchick

We are keeping the two patches separate at the moment to make it easier for each to be reviewed separately.

Soon (hopefully Saturday or Sunday) I'll create a patch that merges the two, with the theme inside the profile.

https://www.drupal.org/project/drupal/issues/2904243#comment-12415635

webchick’s picture

Sorry, separate patches totally makes sense. Probably even leading up to commit.

I'm asking if in this patch, instead of putting it in core/themes and marking it hidden, we can instead put it where it's meant to go (core/profiles/umami_demo/themes). As in the proper directory.

markconroy’s picture

I guess so, but it'll be tomorrow at this stage (I'm in bed).

lauriii’s picture

Good work everyone. The patch is starting to look quite nice. Here's final remarks from me:

  1. +++ b/core/themes/umami/css/base.css
    @@ -0,0 +1,227 @@
    +ol {
    +  margin-bottom: 1.28rem;
    +}
    +ol ol,
    +ol ul {
    +  margin-bottom: 0;
    +  margin-top: 0;
    +}
    +ul {
    +  margin-bottom: 1.28rem;
    +}
    +ul ul,
    +ul ol {
    +  margin-bottom: 0;
    +  margin-top: 0;
    +}
    

    Would grouping these selectors make sense?

  2. +++ b/core/themes/umami/css/components/blocks/banner/banner.css
    @@ -0,0 +1,76 @@
    +  /* todo: Discuss this approach of inline image plus background image */
    
    +++ b/core/themes/umami/css/components/content/full/node-full.css
    @@ -0,0 +1,66 @@
    +/* TODO: How do we want to handle margin-bottom on images for content area? */
    +/* TODO: This is too generic - we need to set it to the specific field (body?) */
    
    +++ b/core/themes/umami/templates/components/banner-block/block--bundle--banner-block.html.twig
    @@ -0,0 +1,54 @@
    +{# TODO: todo: Discuss this approach of inline image plus background image #}
    
    +++ b/core/themes/umami/templates/components/navigation/menu--main.html.twig
    @@ -0,0 +1,90 @@
    +  @TODO extend menu.html.twig instead of duplicating it.
    +  See: https://github.com/lauriii/umami/issues/149
    
    +++ b/core/themes/umami/templates/content/node--recipe--full.html.twig
    @@ -0,0 +1,134 @@
    +  {# TODO: If the above <header> tag is the right approach, change middle to top since we no longer have a top #}
    

    Remaining @todo comments should have link for a Drupal.org issue where they get solved or should be removed

  3. +++ b/core/themes/umami/css/components/navigation/more-link/more-link.css
    @@ -0,0 +1,32 @@
    +.read-more a {
    ...
    +.read-more a:focus,
    +.read-more a:hover {
    ...
    +.read-more a::before {
    

    We should set a class for the link element. Something like read-more__link would work.

  4. +++ b/core/themes/umami/css/components/navigation/tabs/tabs.css
    @@ -0,0 +1,35 @@
    +ul.tabs {
    

    Can we remove ul from the selector?

  5. +++ b/core/themes/umami/css/components/navigation/tabs/tabs.css
    @@ -0,0 +1,35 @@
    +.tabs li {
    

    Can we add class for the li element so we don't have to use a nested selector?

  6. +++ b/core/themes/umami/js/components/navigation/menu-main/menu-main.js
    @@ -0,0 +1,19 @@
    +  var toggler = document.querySelector('[data-drupal-selector="menu-main__toggle"]');
    

    The data selector doesn't have to follow BEM. This could be just menu-main-toggle.

  7. +++ b/core/themes/umami/templates/components/navigation/block--system-menu-block--footer.html.twig
    @@ -0,0 +1,25 @@
    +    'menu-footer__wrapper',
    
    +++ b/core/themes/umami/templates/components/navigation/block--umami-main-menu.html.twig
    @@ -0,0 +1,64 @@
    +    'menu-' ~ derivative_plugin_id|clean_class ~ '__wrapper',
    

    This isn't following BEM. According to BEM this class can be only used inside menu-[menu-name] element.

  8. +++ b/core/themes/umami/templates/components/navigation/block--umami-main-menu.html.twig
    @@ -0,0 +1,64 @@
    +  <button type="button" name="menu_toggle" class="menu-main__toggle"
    +    data-drupal-selector="menu-main__toggle" aria-label="Toggle the menu">
    

    1. It is a bit strange the split the html element into two rows like this. Do we have an example of this elsewhere in core?

  9. +++ b/core/themes/umami/templates/components/search/block--search-form-block.html.twig
    @@ -0,0 +1,52 @@
    +<div class="search__iconwrap">
    +  <a class="search__link" title="{{ 'Go to the search page'|t }}" href="{{ path('search.view') }}">
    

    These classes are not following BEM since search doesn't exist

  10. +++ b/core/themes/umami/umami.theme
    @@ -0,0 +1,73 @@
    +  // Since we are printing the 'Current Page Title', we don't cache breadcrumbs.
    +  // If we do, then we might end up with something like Home >> Articles on the
    +  // Recipes page, which should read Home >> Recipes.
    +  $variables['#cache']['contexts'][] = 'url';
    

    This comment is slightly wrong since the breadcrumb is actually cached, it is just cached per URL because of the cache context.


  11. The spacing on the contact form is a bit odd (more spacing between the form elements than after the form).

  12. The contact form has some overflow on mobile resolutions.

  13. Breadcrumb on the search page has as duplicate title

  14. The search page elements don't have any horizontal padding on small resolutions.
markconroy’s picture

Latest patches.

All items above attended to, except the search page items. That needs a bit more work - hopefully I'll get to it this evening.

lauriii’s picture

Status: Needs review » Needs work
  1. +++ b/core/themes/umami/css/components/blocks/search/search-results.css
    @@ -0,0 +1,113 @@
    +.search-form #edit-basic {
    ...
    +.search-form #edit-basic {
    ...
    +.search-form #edit-basic .button {
    ...
    +.search-form #edit-advanced {
    

    Couldn't we use something else as a selector than the id?

  2. +++ b/core/themes/umami/css/components/blocks/search/search-results.css
    @@ -0,0 +1,113 @@
    +.search-form .search-advanced {
    ...
    +.search-form .search-advanced .details-wrapper {
    ...
    +.search-form .search-advanced .details-wrapper fieldset {
    ...
    +.search-form .search-advanced .action {
    ...
    +.search-form .search-advanced .form-text {
    

    Is it really possible that .search-advanced would exist outside .search-form?

  3. +++ b/core/themes/umami/css/components/blocks/search/search-results.css
    @@ -0,0 +1,113 @@
    +.search-results li {
    

    Could we create a class for the li element?

  4. +++ b/core/themes/umami/css/components/blocks/search/search-results.css
    @@ -0,0 +1,113 @@
    +.search-results .search-result__snippet {
    ...
    +.search-results .search-result__info {
    

    According to BEM, we shouldn't nest selectors like this. Because of BEM, we can already trust that .search-result__info is always inside .search-results

  5. +++ b/core/themes/umami/css/components/fields/buttons.css
    @@ -0,0 +1,31 @@
    +.form-submit:hover, ¶
    

    Space in the end of the line

  6. +++ b/core/themes/umami/css/components/messages/messages.css
    @@ -0,0 +1,56 @@
    +.messages .messages__content {
    

    We don't have to nest this selector since we can trust that .messages__content is always wrapped with .messages

  7. +++ b/core/themes/umami/css/components/navigation/menu-main/menu-main.css
    @@ -0,0 +1,124 @@
    +.menu-main.menu-main--active {
    

    We shouldn't have to include the menu-main class on this selector.

  8. +++ b/core/themes/umami/css/components/navigation/more-link/more-link.css
    @@ -0,0 +1,32 @@
    +.read-more .read-more__link {
    ...
    +.read-more .read-more__link:focus,
    +.read-more .read-more__link:hover {
    ...
    +.read-more .read-more__link:before {
    

    .read-more__link will always be inside .read-more, so no need to include .read-more in the selector.

  9. +++ b/core/themes/umami/templates/components/navigation/breadcrumb.html.twig
    --- /dev/null
    +++ b/core/themes/umami/templates/components/navigation/menu--main.html.twig
    
    +++ b/core/themes/umami/templates/components/navigation/menu-local-task.html.twig
    --- /dev/null
    +++ b/core/themes/umami/templates/components/navigation/menu.html.twig
    

    These files are almost identical. Should we try to do the small override without overriding the whole template?

lauriii’s picture

markconroy’s picture

New patches.

I'll attend to the search items as soon as I can (maybe tomorrow).

thamas’s picture

@laurii you mentioned more time it is sure that BEM element will be inside a BEM block in the HTML if it is done right. But I think that you are not right.

As I know a BEM element means that it belongs to the BEM block (the component) and (in this role) it is not a component itself just the part of one. But BEM structure doesn't have to follow HTML structure. (You may remember to John Albinn's flower example.)

And it comes from this: we don't write .bem .bem__element not because we know that .bem__element is inside .bem but because we know that .bem__element belongs to .bem and we don't want to increase specificity.

markconroy’s picture

lauriii’s picture

Status: Needs review » Needs work

From the existing feedback not fixed yet: #26.4, #56.14#58.1, #58.2-4 and #58.9.

  1. +++ b/core/themes/umami/css/components/navigation/menu-footer/menu-footer.css
    @@ -0,0 +1,41 @@
    +.menu-footer .menu-footer__link {
    ...
    +.menu-footer .menu-footer__link:active,
    +.menu-footer .menu-footer__link:focus,
    +.menu-footer .menu-footer__link:hover {
    

    We shouldn't have to nest the classes here

  2. +++ b/core/themes/umami/css/components/navigation/tabs/tabs.css
    @@ -0,0 +1,35 @@
    +.tabs .tab {
    ...
    +.tabs .tab.is-active {
    

    Can a .tab be outside of .tabs? If cannot, can we remove the nesting?

Since the installation profile this will be included is beta level code, we agreed with @catch that none of the remaining feedback is blocking this from being committed. To keep track of these issue, a d.o issue must be opened for each feedback point that haven't been addressed so it can be addressed later.

tim.plunkett’s picture

  1. +++ b/core/themes/umami/umami.theme
    @@ -0,0 +1,83 @@
    +use Symfony\Cmf\Component\Routing\RouteObjectInterface;
    ...
    +  $request = \Drupal::request();
    +  if ($route = $request->attributes->get(RouteObjectInterface::ROUTE_OBJECT)) {
    ...
    +    if (($entity = $request->attributes->get('entity')) && $entity->getEntityType()->id() == 'search_page') {
    

    This should use RouteMatchInterface (\Drupal::routeMatch())

  2. +++ b/core/themes/umami/umami.theme
    @@ -0,0 +1,83 @@
    +  // We are creating a variable for the Current Page Title, to allow us to print
    +  // it after the breadcrumbs loop has run.
    

    It's not clear how this prevents PathBasedBreadcrumbBuilder from printing the current page title itself?

  3. +++ b/core/themes/umami/umami.theme
    @@ -0,0 +1,83 @@
    +    // Search page titles aren't resolved using the title_resolver service - it
    +    // will always return 'Search' instead of 'Search for [term]', which would
    +    // give us a breadcrumb of Home >> Search >> Search.
    +    // @see https://www.drupal.org/project/drupal/issues/2359901
    +    // @see https://www.drupal.org/project/drupal/issues/2403359
    +    if (($entity = $request->attributes->get('entity')) && $entity->getEntityType()->id() == 'search_page') {
    +      $variables['current_page_title'] = $entity->getPlugin()->suggestedTitle();
    +    }
    

    This code should be provided by the search module.
    Also inline @see's don't work. Are those supposed to be @todos?

markconroy’s picture

Title: Implement the Out of the Box designs as a core theme » Implement the Out of the Box designs as a theme for demo_umami

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

markconroy’s picture

Status: Needs work » Fixed

Closing. This was fixed by being added to the demo_umami profile here https://www.drupal.org/project/drupal/issues/2809635

David_Rothstein’s picture

Note: For the "Manage Display" bugs hinted at via comments such as #8 and #34 above, I created an issue which tracks that (among other things): #2938911: Umami theme hardcodes too many assumptions about the install profile and site configuration

markconroy’s picture

Thanks David,

We are hoping to be able to fix those issues once layouts/layout_builder/etc are stable in core.

I've tested briefly on simplytest using our installation and then those modules and it seems to be fine.

David_Rothstein’s picture

Right, but the layout modules are all optional, so even if the profile wants to use them by default, the theme still has to deal with the possibility that they can be turned off.

However, I guess it's possible that the solution for that is to simply get rid of the hardcoding in the templates and fall back on the standard field presentation (where Manage Display will work correctly) in the case where the layout modules are turned off.

markconroy’s picture

I don’t think the layout being an optional module should worry us.

We’ll just be using the manage display page to set the fields we want in the regions we want. If there is no layout being used, they’ll just be listed one after the other (same as they would now if we just printed `{{ content }}`)

What we might need to do is create some extra layouts so we have one that allows us to have a 33% + 66% region to place the ingredients on the left and the procedure on the right, but that’s easy - and we could contribute that into core as part of the layout module so anyone can use it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.