Part of meta-issue #2571965: [meta] Fix PHP coding standards in core

Step 1: Preparation

Open the file core/phpcs.xml.dist and add a line for the sniff of this ticket. The sniff name is in the issue title. Make sure your patch will include the addition of this line.

Step 2: Install & configure PHPCS

Install PHP CodeSniffer and the ruleset from the Coder module:

$ composer install
$ ./vendor/bin/phpcs --config-set installed_paths ../../drupal/coder/coder_sniffer

Once you have installed the phpcs package, you can list all the sniffs available to you like this:

$ ./vendor/bin/phpcs --standard=Drupal -e

This will give you a big list of sniffs, and the Drupal-based ones should be present.

Step 3: Prepare the phpcs.xml file

To speed up the testing you should make a copy of the file phpcs.xml.dist (in the core/ folder) and save it as phpcs.xml. This is the configuration file for PHP CodeSniffer.

We only want this phpcs.xml file to specify the sniff we're interested in. So we need to remove all the rule items, and add only our own sniff's rule. Rule items look like this:

<rule ref="Drupal.Classes.UnusedUseStatement"/>

Remove all of them, and add only the sniff from this issue title. This will make sure that our tests run quickly, and are not going to contain any output from unrelated sniffs.

Step 4: Run the test

Now you are ready to run the test! From within the core/ folder, run the following command to launch the test:

$ cd core/
$ ../vendor/bin/phpcs -p

This takes a couple of minutes. The -p flag shows the progress, so you have a bunch of nice dots to look at while it is running.

Step 5: Fix the failures

When the test is complete it will present you a list of all the files that contain violations of your sniff, and the line numbers where the violations occur. You could fix all of these manually, but thankfully phpcbf can fix many of them. You can call phpcbf like this:

$ ../vendor/bin/phpcbf

This will fix the errors in place. You can then make a diff of the changes using git. You can also re-run the test with phpcs and determine if that fixed all of them.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mfernea created an issue. See original summary.

mfernea’s picture

Here is the patch.

mfernea’s picture

Status: Active » Needs review

Status change.

mfernea’s picture

I updated the patch.

andriyun’s picture

Looks good to me.
+1 RTBC

mfernea’s picture

Let's update the status if you think the patch is good. Do you want someone else to review it too?

andriyun’s picture

Status: Needs review » Reviewed & tested by the community
xjm’s picture

Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Needs work

Great work @mfernea. Loving to see these standards get cleaned up.

It looks like there are more violations in language.module:

FILE: /Users/xjm/git/maintainer/core/modules/language/language.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 51 | WARNING | Avoid backslash escaping in translatable strings when
    |         | possible, use "" quotes instead
 54 | WARNING | Avoid backslash escaping in translatable strings when
    |         | possible, use "" quotes instead
----------------------------------------------------------------------

When reviewing/RTBCing let's be sure to run the check on all of core to ensure all instances are fixed and no new ones have been introduced.

As a coding standards cleanup, this is eligible for backport during RC, to keep the branches in sync.

mfernea’s picture

Status: Needs work » Needs review

Thanks @xjm! I tested the patch with both 8.4 and 8.5 branches and no cs issues are present (of course testing with the full phpcs.xml.dist).
Also, the testbots don't report any cs issues.
So, I'm a bit confused on how those errors could have been thrown.
Looking at the latest from both 8.5.x and 8.4.x, the lines 51 and 54 are fixed by the patch.

jofitz’s picture

Status: Needs review » Reviewed & tested by the community

I have run through the tests and do not get any errors, including those in #8 (unless I remove the corrections to those lines). Setting back to RTBC.

  • xjm committed da9c5ba on 8.5.x
    Issue #2902728 by mfernea: Fix 'Drupal.Semantics.FunctionT....
xjm’s picture

Status: Reviewed & tested by the community » Fixed

Huh. I tried again and was able to commit it this time. I did do a composer install which I haven't done for awhile on my maintainer repo so maybe I had an older version of composer there. Anyway all good now. Thanks everyone!

I backported this during RC as a coding standards change, to keep the two branches in sync.

mfernea’s picture

Is this committed on 8.4.x too? I don't see the commit on that branch.

  • xjm committed d8f493f on 8.4.x
    Issue #2902728 by mfernea: Fix 'Drupal.Semantics.FunctionT....
xjm’s picture

It was and I failed to push it earlier. Good catch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.