Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When off-canvas dialog is opened on a smaller screen, there's no bottom padding. I thought it should add bottom padding to #drupal-off-canvas
to keep it more consistent.
Comment | File | Size | Author |
---|---|---|---|
#23 | after_patch_is_applied.png | 430.33 KB | shardulagg |
#23 | before_patch_is_applied.png | 160.65 KB | shardulagg |
#17 | after-patch-is-applied.jpg | 230.93 KB | Purencool |
#17 | before-patch-is-applied.jpg | 195.19 KB | Purencool |
#14 | add_bottom_padding_to-2902310-14.patch | 942 bytes | kiruba karan |
Comments
Comment #2
droplet CreditAttribution: droplet commentedComment #3
tedbow@droplet good catch should fix. Changing to minor though
Comment #4
Wim LeersComment #5
Wim LeersComment #6
tedbowChanging to new settings_tray.module component. @drpal thanks for script help! :)
Comment #7
Daylan CreditAttribution: Daylan commentedComment #8
nyph1337 CreditAttribution: nyph1337 as a volunteer commentedI added padding bottom to off-canvas dialog.
Comment #10
tedbow@nyph1337 thanks for the patch. Now that https://www.drupal.org/node/2784443 has been committed the off-canvas.css file has moved.
Actually you need to update 2 files:
core/misc/dialog/off-canvas.css
core/themes/stable/css/core/dialog/off-canvas.css
Comment #11
yogeshmpawarComment #12
yogeshmpawar@tedbow - I have added CSS change in both the files core/misc/dialog/off-canvas.css & core/themes/stable/css/core/dialog/off-canvas.css
Comment #13
kiruba karan CreditAttribution: kiruba karan at DrupalPartners for Innoppl Technologies Pvt. Ltd commentedA patch applied cleanly. But still CSS not reflecting in the interface. Because of CSS order precedence, .ui-dialog-off-canvas .ui-dialog-content styles override by .ui-dialog-off-canvas #drupal-off-canvas. Here I attached the screenshot for the reference.
Comment #14
kiruba karan CreditAttribution: kiruba karan at DrupalPartners for Innoppl Technologies Pvt. Ltd commentedI have added the padding-bottom to .ui-dialog-off-canvas #drupal-off-canvas selector. Please review.
Comment #16
Sparrow_1601 CreditAttribution: Sparrow_1601 commentedI have tested the patch and it appears to function properly.
Comment #17
Purencool CreditAttribution: Purencool commentedThis patch works fine in chrome. The steps that were taken to review the patch. See attached images above
Comment #18
xjmGood find! I've noticed this before. It's much easier to read with this patch.
Adding credit for the testing as well -- thanks @Purencool for the screenshots.
Having the change in Stable is a BC break. In most cases, even for bugfixes, we should only make changes to the module CSS and the internal themes (Bartik, Seven). Tagging for frontend framework manager review for this point.
Thanks!
Comment #19
lauriiiThis could potentially affect someones custom design for the off canvas so we should create a small change record for this. I think it's better to make this change even though there is a small risk involved since this is something that is mainly shown on custom themes, and the bug fix wouldn't be effective if it would be only done for the product themes.
Comment #20
mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commentedComment #21
mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commentedComment #22
Eric115 CreditAttribution: Eric115 at PreviousNext commentedCreated a draft change record here: https://www.drupal.org/node/2945251
Comment #23
shardulagg CreditAttribution: shardulagg as a volunteer commentedpatch works well.
Given below are the steps i followed to review the patch. Please see the attached images
1. Installed latest version of drupal 8.6.x-dev with Umami Food Magazine profile
2. Installed Settings Tray
3. Applied patch
4. Cleared browser's cache
5. viewed element on different screen sizes
Comment #24
shardulagg CreditAttribution: shardulagg as a volunteer commentedComment #25
Eric115 CreditAttribution: Eric115 at PreviousNext commented@shardulagg, please do not repost other's images and test results and claim it as your own, it is not productive in helping us progress this issue.
Comment #26
jds1Looks great on 8.6.x! Live from the Nashville 2018 sprint!
Comment #27
lauriiiThanks for creating the change record. This still looks good for me. Committed 0da3a9c and pushed to 8.6.x. Thanks everyone!