We should apply position to a single parent node, not each child elements.

In current CORE design, we have no problem. But if custom code modifies the trigger area a bit, it may not work. And with applying to parent, we stripped few more lines and KISS.

CommentFileSizeAuthor
#12 apply-position-on-parent-element-2902308-12.patch3.7 KBRamya Balasubramanian
#9 2902308-9.patch2.35 KBkomalk
#3 after-patch-button.png1.51 MBmsankhala
#3 after-patch-parent-div.png1.47 MBmsankhala
#3 before-patch-button.png1.5 MBmsankhala
#3 before-patch-parent-div.png1.47 MBmsankhala
contextual.patch2.29 KBdroplet
contexual.png5.11 KBdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

droplet created an issue. See original summary.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Status: Needs review » Reviewed & tested by the community
FileSize
before-patch-parent-div.png1.47 MB
before-patch-button.png1.5 MB
after-patch-parent-div.png1.47 MB
after-patch-button.png1.51 MB

This patch applies cleanly. Steps I followed:
Even though the provided patch is for 8.5.x but this cleanly applies to 8.6.x as well.

  1. Installed fresh drupal installation version 8.6.x.
  2. On homepage Inspect contextual links of Frontpage content block and verify that position values left/right/top is applied to the contextual button wrapper.
  3. Verify that position values right is also applied to actual contextual button.
  4. Verify that contextunlal link works as expected.
  5. Apply the patch and clear caches.
  6. On homepage Inspect contextual links of Frontpage content block and verify that position values left/right/top/top is only applied to the contextual button wrapper. No position values are applied to actual button.
  7. Verify that contextual links works as expected.

Before:
Before patch parent div
Before patch button

After:
After patch parent div
After patch button

Status: Reviewed & tested by the community » Needs work

The last submitted patch, contextual.patch, failed testing. View results

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

komalk’s picture

komalk CreditAttribution: komalk at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
2902308-9.patch2.35 KB

Patched #2 failed to apply on 9.1.x-dev. Rerolled the patch and fixed the failed tests.

Status: Needs review » Needs work

The last submitted patch, 9: 2902308-9.patch, failed testing. View results

Ramya Balasubramanian’s picture

Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » Ramya Balasubramanian
Ramya Balasubramanian’s picture

Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
apply-position-on-parent-element-2902308-12.patch3.7 KB

Fixing the test cases. uploaded a patch again

Status: Needs review » Needs work

The last submitted patch, 12: apply-position-on-parent-element-2902308-12.patch, failed testing. View results

Ramya Balasubramanian’s picture

Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Ramya Balasubramanian » Unassigned

I have tried this, but can't able to fix this and also I have checked here they have already mentioned about the chrome issue https://git.drupalcode.org/project/drupal/-/blob/9.1.x/core/modules/layo.... Not sure about whether this is a known issue or not. So I am unassigning this ticket.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer and at PreviousNext commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +Needs issue summary update

I'm not sure why we're making this change

Can we get an issue summary update here detailing what the change is and why it's needed?

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

If still a valid task please reopen updating issue summary per #18

Thanks!