If we create more groups with different conditions, the condition label apper next to field is incorrect. Please check attached screenshot.

Error1

Error 2

Attached the patch file.

Steps to reproduce:
1. Install view conditional module
2. Create a new view for contents.
3. Add multiple filters using 'And' and 'OR' options.

CommentFileSizeAuthor
#18 Screenshot 2019-10-11 at 3.40.22 PM.png199.4 KBnaresh_bavaskar
#13 2897644_#13_view_conditional_js_error_fix.patch1.43 KBnikunj.shah
#11 2897644_#10_view_conditional_js_error_fix.patch1.42 KBsathish.redcrackle
#8 2897644_view_conditional_js_error_fix_2.patch771 bytessathish.redcrackle
#7 2897644_view_conditional_js_error_fix.patch771 bytessathish.redcrackle
view conditional js error fix.patch905 bytessathish.redcrackle
screenshot2.png128.75 KBsathish.redcrackle
screenshot1.png131.85 KBsathish.redcrackle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sathish.redcrackle created an issue. See original summary.

sathish.redcrackle’s picture

sathish.redcrackle CreditAttribution: sathish.redcrackle at Red Crackle commented
Status: Active » Needs review

Please review.

anand.toshniwal93’s picture

anand.toshniwal93 CreditAttribution: anand.toshniwal93 as a volunteer and at QED42 commented
Status: Needs review » Postponed (maintainer needs more info)

@sathish.redcrackle,

please verify the patch you have uploaded, it's meant for Drupal core.

sathish.redcrackle’s picture

sathish.redcrackle CreditAttribution: sathish.redcrackle at Red Crackle commented
Project: Views Conditional » Views (for Drupal 7)
Version: 8.x-1.x-dev » 8.x-3.x-dev
Status: Postponed (maintainer needs more info) » Needs review
sathish.redcrackle’s picture

sathish.redcrackle CreditAttribution: sathish.redcrackle at Red Crackle commented
Issue summary: View changes
Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at Dx Experts commented
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.6.x-dev
Component: Code » views_ui.module

Moving to the right queue.

sathish.redcrackle’s picture

sathish.redcrackle CreditAttribution: sathish.redcrackle at Red Crackle commented
FileSize
2897644_view_conditional_js_error_fix.patch771 bytes

Attached the patch for drupal 8.5 version.

sathish.redcrackle’s picture

sathish.redcrackle CreditAttribution: sathish.redcrackle at Red Crackle commented
FileSize
2897644_view_conditional_js_error_fix_2.patch771 bytes

Added patch for version drupal 8.6.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at Dx Experts commented
Status: Needs review » Needs work
Issue tags: +Needs tests

@sathish.redcrackle thanks for looking at this. When making changes to javascript files we now need to modify the es6 file and then compile the js. See https://www.drupal.org/node/2815083 for steps to do this.

We will also need a test for this.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

sathish.redcrackle’s picture

sathish.redcrackle CreditAttribution: sathish.redcrackle at Red Crackle commented
FileSize
2897644_#10_view_conditional_js_error_fix.patch1.42 KB

Attached the patch file with .es6 file changes.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

nikunj.shah’s picture

nikunj.shah CreditAttribution: nikunj.shah at QED42 commented
FileSize
2897644_#13_view_conditional_js_error_fix.patch1.43 KB

Hi Sathish, I have created a patch for Drupal core 8.8.x. This patch is solving the error.

Thank you.

nikunj.shah’s picture

nikunj.shah CreditAttribution: nikunj.shah at QED42 commented
Status: Needs work » Needs review
ambuj_gupta’s picture

ambuj_gupta CreditAttribution: ambuj_gupta at QED42 commented
Assigned: Unassigned » ambuj_gupta

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
CreditAttribution: naresh_bavaskar as a volunteer and at QED42 commented
Assigned: ambuj_gupta » naresh_bavaskar
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
CreditAttribution: naresh_bavaskar as a volunteer and at QED42 commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screenshot 2019-10-11 at 3.40.22 PM.png199.4 KB

@nikunj.shah
The Patch attached in #13 is worked for me. Please find the attached screenshot. Tested on Drupal version 8.9.x.

Thanks

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
CreditAttribution: naresh_bavaskar as a volunteer and at QED42 commented
Assigned: naresh_bavaskar » Unassigned
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Needs work

Moving back to needs work to add some test coverage for this bug fix.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.