Unofficial content_moderation 8.3.7 to 8.4.0 upgrade path

I think we should at least mention this upgrade path in the release notes.

I updated a site to 8.4.x and saw some errors. I think we should document on d.o how to fix it manually.

@jibran, can you be more specific?

+++ b/core/modules/content_moderation/content_moderation.install
@@ -0,0 +1,29 @@
+    $workflow->set('type_settings.states', $states);
+    $workflow->set('type_settings.transitions', $workflow->get('transitions'));

As seen in the upgrade path that we have to set the states and transitions names after the upgrade.

Thanks, for the update. FWIW, I was talking about machine name.

Ok, let me clarify. After updating to rc1 states were missing the labels and I have to re-add all the transitions.

Yes.

Hey, I'm trying to use this patch to go from 8.3.7 to 8.4, and I'm having trouble applying the patch. So far I've tried placing the patch in the drupal root directory and using patch -p0 < 2896630-13.patch or -p1 with no success. It just says "can't find file to patch at input line 5". It looks like there is no .install file in 8.3.7 for content moderation to start with, not sure if that makes any difference? I've also tried using git apply but it fails silently, and there shouldn't be much different between that and the patch command?

Any help is much appreciated!

One more thing you can maybe help with. The above worked, however for the longest time now I've been having this other issue, possibly it seems related to a previous patch I didn't apply.

On the status page I see this:

ENTITY/FIELD DEFINITIONS
Mismatched entity and/or field definitions
The following changes were detected in the entity type and field definitions.
Content moderation state

The Content moderation state entity type needs to be updated.

Then running drush entity-updates I get this output:
The following updates are pending:

content_moderation_state entity type :
The Content moderation state entity type needs to be updated.
Do you wish to run all pending updates? (y/n): y
Drupal\Core\Entity\EntityStorageException: Exception thrown while performing a schema update. SQLSTATE[42000]: Syntax [error]
error or access violation: 1071 Specified key was too long; max key length is 767 bytes: ALTER TABLE
{content_moderation_state_field_data} ADD UNIQUE KEY `content_moderation_state__lookup` (`content_entity_type_id`,
`content_entity_id`, `content_entity_revision_id`, `workflow`, `langcode`); Array
(
)
in Drupal\Core\Entity\Sql\SqlContentEntityStorage->wrapSchemaException() (line 1513 of
/vagrant/src/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
Failed: Drupal\Core\Entity\EntityStorageException: !message in [error]
Drupal\Core\Entity\Sql\SqlContentEntityStorage->wrapSchemaException() (line 1513 of
/vagrant/src/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
Cache rebuild complete. [ok]
Finished performing updates. [ok]

I'm wondering if there's something quick I can do to fix this? Is it just a matter of changing the column size in the db?

I Applied patch as suggested yet I keep getting these warnings:

Warning: array_keys() expects parameter 1 to be array, null given in Drupal\workflows\Plugin\WorkflowTypeBase->getTransitions() (line 258 of core/modules/workflows/src/Plugin/WorkflowTypeBase.php).
Warning: array_map(): Argument #2 should be an array in Drupal\workflows\Plugin\WorkflowTypeBase->getTransitions() (line 261 of core/modules/workflows/src/Plugin/WorkflowTypeBase.php).
Warning: array_combine() expects parameter 1 to be array, null given in Drupal\workflows\Plugin\WorkflowTypeBase->getTransitions() (line 261 of core/modules/workflows/src/Plugin/WorkflowTypeBase.php).
Warning: Invalid argument supplied for foreach() in Drupal\content_moderation\Permissions->transitionPermissions() (line 27 of core/modules/content_moderation/src/Permissions.php).

updated to 8.4.4 after patching

@Sam152
I am not sure actually. I did (try to) follow the steps and I did run updb. But it is possible that I messed up since I had trouble in my git setup with branch differences and configuration diffenrences. ...I know..

The question is how can I either revert applied updates or check/revert my schemaversion without getting really messy, since updates have been added after the patch updates.
Or maybe the question is, can I manually fix the above issues?

Sorry for bothering you with my clumbsy questions.

Ah..ok. Not too familiar with the update version system..
Cool I'll give it a try.

Getting error after applying the patch and running update.php

An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /update.php/start?id=2740&op=do_nojs&op=do
StatusText: Internal Server Error
ResponseText:

Nothing is saved to the watchdog table.

Running via drush gives:

Error: Class 'NestedArray' not found in
/home/devboxco/public_html/asada/core/modules/content_moderation/content_moderation.install, line 28

$states = NestedArray::mergeDeep($workflow->get('states'), $workflow->get('type_settings.states'));

My bad... I missed the new code at the top.

use Drupal\Component\Utility\NestedArray;

mhh...still having trouble with this.

All my workflow transitions are gone and I cannot recreate them.

When I run update_8402 I get:

Invalid argument supplied for foreach() NestedArray.php:327

but I guess that's because there are null transitions,

Trying to add a new transition results in:

TypeError: Argument 1 passed to Drupal\workflows\Plugin\WorkflowTypeBase::getNextWeight() must be of the type array, null given

Also trying to import the older config file fails, because the entity allready exist, yet I cannot delete it because it's being used by some of my nodes.

So I am not sure what to do.

Thank you sam for that reference!

I think I've managed to get everything back in order. I have my state transitions and no errors.

I did, like Stephen https://www.drupal.org/project/drupal/issues/2937527#comment-12433588
just manually edit the blob from a backup.
I compared it with the new string and found that (besides all transition) that the uuid was NULL
a:10:{s:4:"uuid";N;s:8:"langcode";s:2:"en";...

So all I did was replace the uuid in the old file with 'N' and then pasted that into the updated database. That gave me only the default transitions back, and all of the state-labels where empty.
After that I ran the 8401 update, this restored all the labels and transitions. Hooray!

The only thing that worries me is, should the workflow not have an uuid?

I agree, it is not the most elegant or safest way to fix things. And I suppose not having that id is not ok.
It is not a recommended solution,

Het is vallen en opstaan :-)

Applied the patch and it works well! thank you :)

So, I tried the patch and everything seems to have gone smoothly, but then I noticed on reports that it says the moderation entity is out of date. So, I tried drush entity-updates.

Any ideas?

```
The following updates are pending:

content_moderation_state entity type :
The Content moderation state entity type needs to be updated.
Do you wish to run all pending updates? (y/n): y
Drupal\Core\Entity\EntityStorageException: Exception thrown while [error]
performing a schema update. SQLSTATE[HY000]: General error: 1709
Index column size too large. The maximum column size is 767 bytes.:
ALTER TABLE {content_moderation_state_field_data} ADD UNIQUE KEY
`content_moderation_state__lookup` (`content_entity_type_id`,
`content_entity_id`, `content_entity_revision_id`, `workflow`,
`langcode`); Array
(
)
in
Drupal\Core\Entity\Sql\SqlContentEntityStorage->wrapSchemaException()
(line 1513 of
/mnt/www/html/shatterproofdev/docroot/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
```

Thanks Sam!

For anybody still fixing a broken site, here's a sandbox with Sam152's 8.3.2->8.3.3 patches (see #30 and #50) rolled up into a module you can just install.

https://www.drupal.org/sandbox/wturrell/3000331

git clone --branch master git@git.drupal.org:sandbox/wturrell-3000331 content_moderation_patch