Problem/Motivation

If you add a feed (or various) and you go to aggregator/sources/ you will see a pagination but it doesn't works. You can see the problem at: http://sb1.adricida.training.forcontu.com/aggregator/sources/

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#16 2893914-16.patch2.26 KBranjith_kumar_k_u
#14 2893914-14.patch2.28 KBranjith_kumar_k_u
#5 fix_aggregator_pager-2893914-5.patch2.24 KBLOBsTerr
#3 fix_aggregator_pager-2893914-3.patch1.99 KBLOBsTerr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

adriancid created an issue. See original summary.

LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr commented

I debugged the code for a while and found the problematic part. The value $pager_total for this view is overridden, because we also extract aggregator_item for each aggregator source in FeedViewBuilder.php (line 61)

$items = $this->entityManager
          ->getStorage('aggregator_item')
          ->loadByFeed($entity->id(), $limit);

 $build[$id]['items'] = $this->entityManager
          ->getViewBuilder('aggregator_item')
          ->viewMultiple($items, $view_mode, $entity->language()->getId());

loadByFeed calls eventually pager_default_initialize, which resets the value for $pager_total.

Unfortunately, I'm not so experienced to find a solution by myself. I'm asking for some advice or at least direction.

p.s. Honestly, I don't think we need aggregator items on this page.

LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr commented
Version: 8.3.x-dev » 8.4.x-dev
Status: Active » Needs review
FileSize
fix_aggregator_pager-2893914-3.patch1.99 KB

Finally, I have found the issue to distinguish the pagers of feed aggregator and feed items which belong to this feed aggregator. We need to assign unique element for the pager. For element of the pager I used aggregator_item, which can be considered as a unique one on the current page.

Status: Needs review » Needs work

The last submitted patch, 3: fix_aggregator_pager-2893914-3.patch, failed testing. View results

LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr commented
Status: Needs work » Needs review
FileSize
fix_aggregator_pager-2893914-5.patch2.24 KB

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented
FileSize
2893914-14.patch2.28 KB

Re-rolled the last patch for 9.3

Status: Needs review » Needs work

The last submitted patch, 14: 2893914-14.patch, failed testing. View results

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented
FileSize
2893914-16.patch2.26 KB

Updated

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented
Status: Needs work » Needs review

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Project: Drupal core » Aggregator
Version: 9.4.x-dev » 1.x-dev
Component: aggregator.module » Code

The aggregator module has been removed from Core in 10.0.x-dev and now lives on as a contrib module. Issues in the Core queue about the aggregator module, like this one, have been moved to the contrib module queue.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Issue tags: +Needs tests

This needs some test coverage

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Needs work
LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr commented
Status: Needs work » Closed (won't fix)

I have checked and I can't reproduce the bug anymore. Let's close it

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Thanks for following up @LOBsTerr