Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There is an edge case when exiting the filter dialog that causes the guidelines text not to be displayed.
Steps to recreate (on 8.x-3.x)
1) when editing a filtered text area with multiple filters, that has one or more options that filter html
2) change the filter select box to an option that restricts the HTML tags available. (Full HTML to Basic HTML)
- the guidelines text will be removed or changed to the relevant content type or removed (if none)
3) in the resulting "Change text format?" dialog, hit cancel.
- this will result in the select option being changed back to the initial value
- the guidelines text, will not be updated, (will remain that of what was changed to in 2)
This issue happens because the guidelines region is updated by .change(), which is not triggered when simply updating the value of a select with .val().
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | 2884943-nr-bot.txt | 144 bytes | needs-review-queue-bot |
| #11 | 2884943-11.patch | 810 bytes | Lendude |
| |||
Issue fork drupal-2884943
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #10
LendudeI can still reproduce this on a clean Umami install by switching to 'Restricted HTML' on existing content
Comment #11
LendudeThe problem seems to be in the editor module, so moving it there.
The editor module is the one that controls the behaviour of the popup and that is what needs to be tweaked.
Checked if there was any existing test coverage for the popup, because that should be easy to expand, but there doesn't seem to be any test coverage for this functionality at all :(
This fixes the issue for me, but there might be a better way, dunno, this just triggers the change again on the select element to reset the description
Comment #13
smustgrave CreditAttribution: smustgrave at Mobomo commented@Vighneshh did not see any commit message.
@lendude should this be tagged for needs tests?
Comment #15
needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.