The build() method of a breadcrumb builder gets given a $route_match parameter, presumably to use to create the breadcrumb.

However, PathBasedBreadcrumbBuilder completely ignores that and instead gets the actual current path from the context:

    $path = trim($this->context->getPathInfo(), '/');

This means that PathBasedBreadcrumbBuilder can't be used in any other contexts, for example to create the breadcrumb for another route to use as the basis for another breadcrumb builder.

CommentFileSizeAuthor
#9 interdiff-6-9.txt1.11 KBidebr
#9 2884217-9.patch4.11 KBidebr
#6 interdiff-4-6.txt3.83 KBseanB
#6 2884217-6.patch4.14 KBseanB
#4 2884217-4.patch930 bytesseanB
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

seanB’s picture

seanB
Primary language Dutch
Location Netherlands
CreditAttribution: seanB commented

Found this stackexchange link that could be used as a workaround. Would be nice to get this fixed though.
https://drupal.stackexchange.com/questions/191548/how-do-i-build-breadcr...

I'll see if I can work on a patch.

seanB’s picture

seanB
Primary language Dutch
Location Netherlands
CreditAttribution: seanB commented
Status: Active » Needs review
FileSize
2884217-4.patch930 bytes

Please review!

Status: Needs review » Needs work

The last submitted patch, 4: 2884217-4.patch, failed testing. View results

seanB’s picture

seanB
Primary language Dutch
Location Netherlands
CreditAttribution: seanB commented
Status: Needs work » Needs review
FileSize
2884217-6.patch4.14 KB
interdiff-4-6.txt3.83 KB

Fixed the tests and added extra test coverage for the custom route match.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Needs work 
+++ b/core/modules/system/tests/src/Unit/Breadcrumbs/PathBasedBreadcrumbBuilderTest.php
@@ -378,6 +379,65 @@ public function testBuildWithUserPath() {
+      ->will($this->returnValue('/example/baz'));

I don't think the ->will is needed, because nothing can get returned if this is supposed to never be called.

Otherwise I think this testcoverage is sufficient and I'm really sorry about bumping this back after months of inactivity with such a small nitpick.

idebr’s picture

idebr CreditAttribution: idebr at iO commented
Status: Needs work » Needs review
FileSize
2884217-9.patch4.11 KB
interdiff-6-9.txt1.11 KB

#8 Removed the ->will method, as it does not get called.

Also replaced the call to the deprecated ->getMock() method, see #2795317: Allow PHPUnit 6+ support for object mocking

Status: Needs review » Needs work

The last submitted patch, 9: 2884217-9.patch, failed testing. View results

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges at Makina Corpus commented
Related issues: +#3064004: PathBasedBreadcrumbBuilder take path from request context, but not from RouteMatch

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.