Views row plugin to render entity revisions

I'm in the process of trying to upgrade from 8.4 to 8.5+ (security update scheduled for today). I'm running into this error on a site that uses the above patch:

2018/08/01 16:42:37 [error] 2436#0: *174 FastCGI sent in stderr: "PHP message: Uncaught PHP Exception Drupal\Component\Plugin\Exception\PluginNotFoundException: "The "entity_revision:paragraph_revision" plugin does not exist." at /vagrant/web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php line 52" while reading response header from upstream, client: 10.0.2.2, server: localhost, request: "GET / HTTP/1.1", upstream: "fastcgi://unix:/var/run/php-fpm.sock:", host: "localhost:8081"

So it looks like it is failing to find a plugin definition for the generated plugin name.

Silly me, I was running into this error because I forgot to re-apply this patch. Re-applying seems to fix the issue.

Thanks for the patch! It works well with 8.6.2, we'll need some test coverage to RTBC it though.

Used the patch with success.
Got the same error as bburg due to misconfiguration in the view while trying lots of different approaches before I found this issue. A config import and cache rebuild fixed the issue.

One code remark, the label should be translated:
'title' => $entity_type->getLabel() .' Revision',
should become
'title' => $entity_type->getLabel() . ' ' . t('revision'),

Kind regards

Matthias

Patch no longer applies as of Drupal 8.8.x-alpha1. This needs to be rerolled against 8.9.x, reviewed, and then hopefully committed.

Rerolled the patch against 8.9.x, applied remark from #9.

Fixed coding standard messages. Ignored deprecation notices as they aren't introduced by this patch.

Rerolled patch. I'm not too sure where DeprecatedServicePropertyTrait came from in the previous patch file. It's not present in 9.2.5.

Anyway. This patch will work on 9.2.5.

Ok, with that last patch, I'm getting this:

Fatal error: Uncaught Error: Call to a member function hasHandler() on null in /var/www/html/web/core/modules/views/src/Plugin/Derivative/ViewsEntityRow.php:105
Stack trace:
#0 /var/www/html/web/core/lib/Drupal/Component/Plugin/Discovery/DerivativeDiscoveryDecorator.php(101): Drupal\views\Plugin\Derivative\ViewsEntityRow->getDerivativeDefinitions(Array)
#1 /var/www/html/web/core/lib/Drupal/Component/Plugin/Discovery/DerivativeDiscoveryDecorator.php(87): Drupal\Component\Plugin\Discovery\DerivativeDiscoveryDecorator->getDerivatives(Array)
#2 /var/www/html/web/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php(284): Drupal\Component\Plugin\Discovery\DerivativeDiscoveryDecorator->getDefinitions()
#3 /var/www/html/web/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php(175): Drupal\Core\Plugin\DefaultPluginManager->findDefinitions()
#4 /var/www/html/web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryCachedTrait.php(22): Drupal\Core\Plugin\DefaultPluginManager->getDefinitions()
#5 /var/www/html/web/core/lib/Drupal/Core in /var/www/html/web/core/modules/views/src/Plugin/Derivative/ViewsEntityRow.php on line 105

This patch should fix the errors in the previous comment.

@bburg Your patch seems to work fine for row plugin, but it does not seem to cover basic cases for paragraphs.

Imagine you have a page using a revision field for paragraphs. Those paragraphs also use a revision field to another paragraph.

With such common case, we need to be able to render a paragraph revision as a field, so we can have :

• an argument "revision ID" for the parent paragraph
• a relationship from the parent paragraph to the child paragraphs
• a field "rendered entity revision" for the child paragraphs

With the row plugin only, we could use an inverse relationship, but this no more work as soon as we reuse paragraph entities, for example when working with paragraphs library module.

Do you think you could add such a feature in your patch?

Fixed Drupal CS issue of patch #22.

Tweaked TranslationLanguageRenderer to key the build array by revision ID when type is revisionable. Otherwise, the row plugin renders the first (or initial) revision in each revision row instead of the loaded revision.

Removed unnecessary debug typehint.

Re-rolled for 9.5.x.

Unfortunately this patch no longer applies as of Drupal 9.5.1

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Patch in #30 still applies cleanly on 9.5.9.

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Re-rolled.

Fixed patch filename.

Was previously tagged for tests which are still needed.

Also issue summary appears incomplete.

Tried to fix failures in #37.