SharedTempStoreFactory and PrivateTempStoreFactory $expire variable should be changeable for each collection

Maybe the best solution would be to be able to pass along the expire time when you construct a PrivateTempStorage using \Drupal\user\PrivateTempStoreFactory::get. With this you don't need to change the PrivateTempStore, right, aka. don't introduce any kind of muteable changes on that.

Something like this?

Forgot to document parameter in the comment :)

+1 for factory accepting $expire when getting collection!

I've ran into this a few times, wishing to have different expire times per tempstore.

Attached is patch against latest 8.6.x-dev against the Core/TempStore since user version is deprecated.

This also applies it against SharedTempStore and minor comment corrections.

New patch to solve error about being compatible with deprecated user version.

I would rather prefer to set the expire value per item:

$temp_store = \Drupal::service('user.private_tempstore')->get('my_module');
$temp_store->set('key', 'value', 3600);

I think both are valuable. Allowing a default $expire for the entire collection, AND an expire value per key/value item.

I tested the currently passing patch against a Drupal 8.7.5 installation and it worked for me. Thank you - this is a very helpful feature!

There needs to be documentation for how to manually test this.
We also need to add automated tests.

Patch in #11 doesn't apply anymore on HEAD and also because of the dropped deprecations from the user module in #3097445: Remove all @deprecated code in the User module except user:name token.

See reroll with addressed remark from #12. Still needs tests as per #15.

#19 does not apply cleanly to Drupal 9.2.1 for me

Updating the patch from #19. Currently applies cleanly to 9.3.x HEAD and will work on 9.2.x HEAD if using patch utility which can apply with fuzz.

With respect to testing. It looks like the TempStore classes themselves already have tests that cover setting with an expiration parameter:
- https://git.drupalcode.org/project/drupal/-/blob/9.3.x/core/tests/Drupal...
- https://git.drupalcode.org/project/drupal/-/blob/9.3.x/core/tests/Drupal...

So are we looking for additional tests on the TempStoreFactory classes?

I just wanted to comment here that it is in fact really easy to override this in any custom module with little to no overhead. It took me some searching to find out, but I wanted to share this with you while this issue progresses.

The tempstore.private service has a backend_overridable tag, which means that it can be overridden by another service.

tempstore.private:
  class: Drupal\Core\TempStore\PrivateTempStoreFactory
  arguments: ['@keyvalue.expirable', '@lock', '@current_user', '@request_stack', '%tempstore.expire%']
  tags:
    - { name: backend_overridable }

Every custom module can create its 'own' private tempstore with a different expiry time. To have a temp store expire in 10 seconds, add this to your module's services. You can even create multiple for different types of data.

mymodule.tempstore.private:
  class: Drupal\Core\TempStore\PrivateTempStoreFactory
  arguments: ['@keyvalue.expirable', '@lock', '@current_user', '@request_stack', 10]

Obviously you now have to use your own service name instead of tempstore.private when instanciating the temp store:

$container->get('mymodule.tempstore.private')

Thanks @Neograph734, #25 is exactly what I was looking for!

Maybe I am missing something but I was not able to make the expiration time change using #25. I haven't tried the patch yet, but that seems like a good way to go.

Core: Drupal 10
TypeError: Drupal\Core\TempStore\SharedTempStore::__construct(): Argument #5 ($current_user) must be of type Drupal\Core\Session\AccountProxyInterface, int given, called in /core/lib/Drupal/Core/TempStore/SharedTempStoreFactory.php on line 111 in Drupal\Core\TempStore\SharedTempStore->__construct() (line 106 of core/lib/Drupal/Core/TempStore/SharedTempStore.php).

Core: Drupal 10
TypeError: Drupal\Core\TempStore\SharedTempStore::__construct(): Argument #5 ($current_user) must be of type Drupal\Core\Session\AccountProxyInterface, int given, called in /core/lib/Drupal/Core/TempStore/SharedTempStoreFactory.php on line 111 in Drupal\Core\TempStore\SharedTempStore->__construct() (line 106 of core/lib/Drupal/Core/TempStore/SharedTempStore.php).

Core: Drupal 10
TypeError: Drupal\Core\TempStore\SharedTempStore::__construct(): Argument #5 ($current_user) must be of type Drupal\Core\Session\AccountProxyInterface, int given, called in /core/lib/Drupal/Core/TempStore/SharedTempStoreFactory.php on line 111 in Drupal\Core\TempStore\SharedTempStore->__construct() (line 106 of core/lib/Drupal/Core/TempStore/SharedTempStore.php).

Previously tagged for tests which are still needed.

Have not tested

Setting issue back to 11.x as the active development branch and back to Feature request as this is net new functionality and not a bug.

Opened a new MR -- https://git.drupalcode.org/project/drupal/-/merge_requests/5975 -- against 11.x as it wasn't clear how to change the target of the existing MR against 9.3.x

Changes include:
- Starting from the patch state of #36
- Updates to more SharedTempStore::set related methods that are also affected by $expire
- Updated tests for Private/Shared Tempstore classes
- Typehinting for params and returns in affected code

Hiding patches for clarity.

Issue summary looks like it could use some love. I added the standard template but not familiar enough with the issue to fill in the missing pieces. Left TBD for ones that could be filled out, if it doesn't apply just replace with an NA.