"Empty" state (also "filled" as it is derivative from "empty") doesn't work for date field with datepicker plugin, becuase "empty" state has keyup trigger only. But datepicker doesn't invoke keyup, only change only.
So I think we need to add change trigger to "empty" state as it has done for state "value".

CommentFileSizeAuthor
#26 2880338-26.patch552 bytesovanes
#25 2880338-nr-bot.txt144 bytesneeds-review-queue-bot
#20 2880338-20.patch862 byteskostyashupenko
#17 drupal-datepicker_state_empty-2880338-17.patch965 bytesSpadXIII
#3 drupal-datepicker_state_empty-2880338-3.patch562 byteskalistos
#2 drupal-datepicker_state_empty-2880338-2.patch343 byteskalistos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kalistos created an issue. See original summary.

kalistos’s picture

kalistos CreditAttribution: kalistos at Adyax commented
FileSize
drupal-datepicker_state_empty-2880338-2.patch343 bytes
kalistos’s picture

kalistos CreditAttribution: kalistos at Adyax commented
FileSize
drupal-datepicker_state_empty-2880338-3.patch562 bytes

Backport to 8.3

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue tags: +JavaScript, +Needs tests
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Component: theme system » datetime.module
mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio at DiD Agency commented
Status: Active » Needs work
Issue tags: +Needs manual testing

@kalistos, are you seeing this with the native datepicker (eg, Chrome) or the jQuery UI polyfill (eg, Firefox). TBH, I am not sure which JSTB will use off the top of my head, but the other will require manual testing. For the time being, let's just work on the 8.4 version, and then backport when we are done (been seeing confusion on other issues where people post 8.3 and 8.4 intermixed).

kalistos’s picture

kalistos CreditAttribution: kalistos at Adyax commented

@mpdonadio, I have this issue with jQuery UI datepicker, which integrated in Drupal core:
core/assets/vendor/jquery.ui/ui/datepicker-min.js

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

nwoodland’s picture

nwoodland CreditAttribution: nwoodland commented
Issue tags: -JavaScript +JavaScript

The patch in #3 worked great resolving this for a datetime field in Drupal 8.8.1. Thanks kalistos!

tanubansal’s picture

tanubansal CreditAttribution: tanubansal at Salsa Digital commented

Patch #3 works for 9.1 as well.
Tested

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

SpadXIII’s picture

SpadXIII CreditAttribution: SpadXIII at SIM commented
Status: Needs work » Needs review
FileSize
drupal-datepicker_state_empty-2880338-17.patch965 bytes

Quick re-roll for 8.9.9
Seems to work fine functionally :)

edit: looks like I forgot to change the version for the test-bot .. hmm

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
kostyashupenko’s picture

kostyashupenko
Primary language Russian
Location Omsk
CreditAttribution: kostyashupenko at Skilld commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2880338-20.patch862 bytes
colin.eininger’s picture

colin.eininger CreditAttribution: colin.eininger commented
Related issues: +#2445271: #states element empty check not triggered on mouse based paste

I don't know how to handle that correctly but I think this issue will fix #2445271 too

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Needs review » Needs work
FileSize
2880338-nr-bot.txt144 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

ovanes’s picture

ovanes CreditAttribution: ovanes as a volunteer and at FFW commented
FileSize
2880338-26.patch552 bytes

Hello I have rerolled the patch to work for 9.5.7 version.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.