Convert \Drupal\views\Tests\Plugin\StyleOpmlTest and \Drupal\views\Tests\Plugin\DisplayFeedTest to PHPUnit tests

I'm wondering whether really relying on these methods is the right idea. Maybe parsing the XML explicit is the right way to go.

I actually think this is ok (at least for now). If we decide this is not the way to test XML responses we should do a follow-up, we should ask the rest maintainers I think as they deal with non-HTML responses I can imagine.

For this issue: This is about converting it as directly as possible and currently this is the only method to use Mink to get to a non-//html element (that I know of).

Review:

+++ b/core/modules/views/tests/src/Functional/Plugin/StyleOpmlTest.php
@@ -52,10 +54,9 @@ public function testOpmlOutput() {
-    $outline = $this->xpath('//outline[1]');
-    $this->assertEqual($outline[0]['type'], 'rss', 'The correct type attribute is used for rss OPML.');
-    $this->assertEqual($outline[0]['text'], $feed->label(), 'The correct text attribute is used for rss OPML.');
-    $this->assertEqual($outline[0]['xmlurl'], $feed->getUrl(), 'The correct xmlUrl attribute is used for rss OPML.');
+    $this->assertEquals('rss', $this->getSession()->getDriver()->getAttribute('//outline[1]', 'type'));
+    $this->assertEquals($feed->label(), $this->getSession()->getDriver()->getAttribute('//outline[1]', 'text'));
+    $this->assertEquals($feed->getUrl(), $this->getSession()->getDriver()->getAttribute('//outline[1]', 'xmlUrl'));

@@ -66,12 +67,11 @@ public function testOpmlOutput() {
-    $outline = $this->xpath('//outline[1]');
-    $this->assertEqual($outline[0]['type'], 'link', 'The correct type attribute is used for link OPML.');
-    $this->assertEqual($outline[0]['text'], $feed->label(), 'The correct text attribute is used for link OPML.');
-    $this->assertEqual($outline[0]['url'], $feed->getUrl(), 'The correct URL attribute is used for link OPML.');
+    $this->assertEquals('link', $this->getSession()->getDriver()->getAttribute('//outline[1]', 'type'));
+    $this->assertEquals($feed->label(), $this->getSession()->getDriver()->getAttribute('//outline[1]', 'text'));
+    $this->assertEquals($feed->getUrl(), $this->getSession()->getDriver()->getAttribute('//outline[1]', 'url'));

Could we use:
$element = $this->getSession()->getDriver()->find('xpath');

here and getAttribute on the returned NodeElement? Would make it a little more efficient and more similar to what it was.

In general I prefer explicitness over implicitness, so parsing XML explicit rather than relying that it sort of works, feels better.

Discussed with @lendude offline and we agreed that finding out the proper way of testing an XML response is in scope for this issue as it's already a follow-up.

Let's figure it out. Maybe we should talk/borrow from the rest team.

Discussed with @lendude offline and we agreed that finding out the proper way of testing an XML response is in scope for this issue as it's already a follow-up.

Sure, you know, we can always iterate later.

Might this issue be an interesting way to go forward for this?

#2812967: API test base: Provide a test helper to test REST and similar APIs

Might this issue be an interesting way to go forward for this?

You are right, it would be probably a potential usage for it.

+++ b/core/modules/views/tests/src/Functional/Plugin/StyleOpmlTest.php
@@ -66,12 +68,12 @@ public function testOpmlOutput() {
-    $this->assertEqual($outline[0]['url'], $feed->getUrl(), 'The correct URL attribute is used for link OPML.');
...
+    $this->assertEquals($feed->getUrl(), $outline->getAttribute('url'));

I really like the better API

Committed and pushed 5f2605fe4c to 8.7.x and 6ddb9ed89b to 8.6.x. Thanks!

+++ b/core/modules/views/tests/src/Functional/Plugin/DisplayFeedTest.php
@@ -136,8 +134,8 @@ public function testDisabledFeed() {
+    $this->assertTrue(strpos($feed_header[0]->getAttribute('href'), 'test-attached-disabled.xml'), 'Page display contains the correct feed URL.');

FYI This is better written as assertContains() but let's not delay on such improvements.