API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...
This page, which documents the D8 Render API, contains links to D7 pages on Drupal.org. There is already an @todo in the documentation to fix this.
The links in question are:
- https://www.drupal.org/node/930760 - Drupal 7: Render Arrays overview, which is superseded in this case by https://www.drupal.org/docs/8/api/render-api/render-arrays. The docs here already link to https://www.drupal.org/docs/8/api/render-api, so this can probably just be removed
- https://www.drupal.org/node/933976, and https://www.drupal.org/node/722174 - Using the theme layer (Drupal 7.x) should be replaced with a link to https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...
Making the final list:
- https://www.drupal.org/developing/api/8/render
- https://www.drupal.org/docs/8/theming
- @link themable Theme system overview @endlink
Comment | File | Size | Author |
---|---|---|---|
#20 | interdiff.txt | 589 bytes | pritish.kumar |
#20 | remove_d7_links_from_d8-2875443-20.patch | 793 bytes | pritish.kumar |
#17 | remove_d7_links_from_d8-2875443-17.patch | 791 bytes | pankajsachdeva |
#13 | remove_d7_links_from_d8-2875443-13.patch | 806 bytes | pankajsachdeva |
#13 | interdiff-2875443-7.txt | 618 bytes | pankajsachdeva |
Comments
Comment #2
cilefen CreditAttribution: cilefen commentedComment #3
cilefen CreditAttribution: cilefen commentedIt is more like a related issue.
Comment #4
brentgCreated a patch with the changes from eojthebrave
Comment #5
brentgComment #6
eojthebraveThanks @brentgees, this needs a little work still though. This link:
Should use the @link docblock syntax instead. And in the comment you can just put
@link themeable Theme system overview @endlink
. api.drupal.org will automatically convert that to a link to the topic page as needed. This ensures amongst other things that those links link to the version specific topic page. 8.3.x vs 8.2.x for example.Comment #7
pritish.kumar CreditAttribution: pritish.kumar at OpenSense Labs commentedPlease check, if the changes made are correct.
Comment #8
pritish.kumar CreditAttribution: pritish.kumar at OpenSense Labs commentedComment #9
pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at ]init[ AG commentedHi pritish.kumar,
I have applied this patch and its applied successfully. I am attaching the screenshot of it.
Comment #10
pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at ]init[ AG commentedComment #11
Gábor HojtsyLet's not add line ending whitespace.
Comment #12
pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at ]init[ AG commentedComment #13
pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at ]init[ AG commentedHi Gábor,
I removed line ending whitespace.
Comment #14
pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at ]init[ AG commentedComment #15
eojthebraveWe can remove the "api.drupal.org" string from the end of this line. Sorry, that might have been confusing in my earlier comment, but it's not necessary here.
Comment #16
pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at ]init[ AG commentedComment #17
pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at ]init[ AG commentedHi eojthebrave,
I have updated the patch as mentioned in the above comment.
Comment #18
pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at ]init[ AG commentedComment #19
eojthebraveThis line needs a leading "- " to make it part of the list along with the other two links. So the full line should read "* - @link themeable Theme system overview @endlink.". Once that's been added I think this is probably good to go. Thanks.
Comment #20
pritish.kumar CreditAttribution: pritish.kumar at OpenSense Labs commentedApplied as stated in #19
Comment #21
eojthebraveLooks good to me.
Comment #22
pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at ]init[ AG commentedComment #23
alexpottCommitted and pushed 84233ba to 8.4.x and b913e86 to 8.3.x. Thanks!
Comment #27
rajeevku CreditAttribution: rajeevku commentedIts time we add correct links to this instead of just removing D7 URL's.
Comment #28
eojthebraveI believe that by linking to https://www.drupal.org/docs/8/api/render-api, and https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21... we are linking to all the current documentation. There are fewer links than before, but https://www.drupal.org/docs/8/api/render-api is really more of a landing page with a bunch of content underneath it.
If you've got suggestions for other things we could add here to help make this even better though could you maybe provide either a list of links, or suggestions on what you feel is missing? Thanks.