Allow updating lists when switching from allowed values to allowed values function

We don't need to do isset() with !empty() because it does it implicitly but this patch looks good otherwise! Going to give it a try.

#3 could be fixed on commit(or I can roll that in). This works though.

+1 to RTBC

Same here, using this patch in a few places, thanks @odegard.

RTBC++

I have found that this patch does not work for D9 as the list module has been removed. The function has moved to the Options module. I have changed the patch for D9 and would appreciate if anyone can test whether they agree this patch works. I have also added extra information to the error message to notify which keys are causing the import error.

Sorry for reuploading a few times, I have improved the patch to pass the drupal 9.0-dev test.

I can confirm the D9 patch is working for me.

Confirmed that patch #12 works like a charm on Drupal 9.3.13 Therefore I switched version and component to match the requirements.

Note:
If the allowed values are dynamic, based on the entity or should not be cached statically you have to use default parameters for your custom _my_module_allowed_values function to avoid an ArgumentCountError because of the following line:

+++ b/core/modules/options/options.module
@@ -109,11 +109,19 @@ function options_allowed_values(FieldStorageDefinitionInterface $definition, Fie
+      $allowed_values_from_function = $function($field_storage);

Maybe an issue of this patch but you can solve this using:

function _my_module_allowed_values(FieldStorageConfig $definition, FieldableEntityInterface $entity = NULL, &$cacheable = NULL) {
  …
}

This could use some automated test coverage.