Comments

mpdonadio created an issue. See original summary.

mpdonadio’s picture

Status: Active » Needs review
FileSize
12.71 KB

Just the results of the browsertest-convert.php script to see what the starting point is. Some of these pass as-is, but lots of fails to dig into.

Status: Needs review » Needs work

The last submitted patch, 2: 2872059-02.patch, failed testing.

michielnugter’s picture

Issue tags: -phpunit +phpunit initiative
mpdonadio’s picture

Dug into this a bit. I think nearly all of the fails are because the local .po files in the tests are not being picked up, and I am not sure why. Been debugging this for a bit and am stumped :/

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
12.79 KB

Here we go.LocaleConfigTranslationImportTest:: testLocaleRemovalAndConfigOverridePreserve failed when running whole testsuite on local but passed while running explicitly.Let's see at testbot

//Naveen

Status: Needs review » Needs work

The last submitted patch, 6: 2872059-6.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
19.66 KB
8.73 KB

Here we go with fixes.

//Naveen

Status: Needs review » Needs work

The last submitted patch, 8: 2872059-8.patch, failed testing. View results

naveenvalecha’s picture

Here we go with more fixes.

//Naveen

Lendude’s picture

Issue summary: View changes
Status: Needs review » Needs work
+++ b/core/modules/locale/tests/src/Functional/LocaleConfigTranslationImportTest.php
@@ -206,7 +206,7 @@ public function testLocaleRemovalAndConfigOverridePreserve() {
+    $lid = (string) $textarea->getAttribute('name');

+++ b/core/modules/locale/tests/src/Functional/LocaleConfigTranslationTest.php
@@ -76,7 +76,7 @@ public function testConfigTranslation() {
+    $lid = (string) $textarea->getAttribute('name');

@@ -100,7 +100,7 @@ public function testConfigTranslation() {
+    $lid = (string) $textarea->getAttribute('name');

All the (string) casts can be removed, getAttribute returns a string.

The rest looks really nice and clean.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
19.49 KB
6.06 KB

Addressed #11
Also removed the string casts from a couple of other places.

//Naveen

dawehner’s picture

  1. +++ b/core/modules/locale/tests/src/Functional/LocaleJavascriptTranslationTest.php
    @@ -138,8 +138,9 @@ public function testLocaleTranslationJsDependencies() {
    +    $content = $this->getSession()->getPage()->getcontent();
    

    I think the actual method name is getContent, but PHP doesn't care

  2. +++ b/core/modules/locale/tests/src/Functional/LocaleTranslationUiTest.php
    @@ -317,7 +317,7 @@ public function testStringValidation() {
    -      $this->assertNotIdentical(FALSE, strpos($form_class[0], 'error'), 'The string was rejected as unsafe.');
    +      $this->assertNotIdentical(FALSE, strpos($form_class[0]->getText(), 'error'), 'The string was rejected as unsafe.');
    

    I am wondering whether we should use assertContains here instead.

naveenvalecha’s picture

FileSize
19.47 KB
1.87 KB

#13.1
good catch
#13.2
Done

//Naveen

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Thank you!

  • Gábor Hojtsy committed 0f37866 on 8.4.x
    Issue #2872059 by naveenvalecha, mpdonadio, dawehner, Lendude: Convert...

  • Gábor Hojtsy committed a779d66 on 8.3.x
    Issue #2872059 by naveenvalecha, mpdonadio, dawehner, Lendude: Convert...
Gábor Hojtsy’s picture

Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Looks great, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.