Problem/Motivation

#2712647: Update Symfony components to ~3.2 was pinned to Symfony 3.2.6, we should unpin composer.json when 3.2.8 isout.

https://github.com/symfony/symfony/releases/tag/v3.2.8

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 2871253-10.patch20.67 KBmpdonadio
#6 2871253-06.patch20.63 KBmpdonadio
#2 2871253-02.patch91.13 KBmpdonadio
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch created an issue. See original summary.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio at DiD Agency commented
Status: Postponed » Needs review
FileSize
2871253-02.patch91.13 KB

Don't want to disturb the RTBC patch on #2712647: Update Symfony components to ~3.2, but 3.2.8 came out today. Here is that patch with ~3.2 and then `composer update 'symfony/*'`, to get 3.2.8 in the lockfile.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Added this issue to meta issue #2864037: [META] Update core PHP dependencies. #2712647: Update Symfony components to ~3.2 is in so the patch needs a reroll.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Title: Update composer.json when Symfony 3.2.8 is out » Update Symfony components to 3.2.8
Issue summary: View changes
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented

With Symfony 3.3.0 due for release later this month I have opened #2874909: Update Symfony components to 3.3.*.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio at DiD Agency commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2871253-06.patch20.63 KB

OK, fresh start to get back to ~3.2 in core/composer.json and `composer update 'symfony/*'` to get 3.2.8 in the lockfile.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Excerpt of my bash history where I verified this patch:

$ sed -i 's/3.2.6/\~3.2/' core/composer.json
$ composer update symfony/*
...
$ curl https://www.drupal.org/files/issues/2871253-06.patch | git apply -R --check
$ # No output, yay! ;-)
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

Another library update #2874817: Update zendframework/zend-diactoros from 1.3.10 to 1.4.0.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2871253-06.patch, failed testing.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio at DiD Agency commented
Status: Needs work » Needs review
FileSize
2871253-10.patch20.67 KB

Reroll b/c tiny conflict from #2488860: Bring phpunit bridge into drupal and use it for unit tests and simpletest to handle Deprecation.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Related issues: +#2867960: Merge Component composer.json files to account for them during build

Heads up: We're working on how to achieve parity between Components' requirement constraints and changes to core here: #2867960: Merge Component composer.json files to account for them during build

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Steps from #7 still work with #10.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: 2871253-10.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Needs work » Reviewed & tested by the community

  • catch committed 9165b05 on 8.4.x 
    Issue #2871253 by mpdonadio, jibran, tstoeckler, catch: Update Symfony...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +8.4.0 release notes

Committed/pushed to 8.4.x, thanks! (extra thanks getting this RTBC quickly after the main Symfony 3 patch landed).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented

Related change record: https://www.drupal.org/node/2891254

Related to: #2887000: composer.json does not constrain Symfony components to minor and patch versions that are compatible with Drupal