Comments

GoZ created an issue. See original summary.

GoZ’s picture

Status: Active » Postponed
FileSize
1.66 KB

I only add initial convert, we need #2795041: BrowserTestBase: Add drupalPostWithFormat to continue

dawehner’s picture

To be honest I would prefer to use the HTTP client directly here, its clear what goes on then.

michielnugter’s picture

Status: Postponed » Needs work

Setting it back to needs work.

The test can be fixed with one of these options:
- calling drupalPostForm with the proper requirements
- Converting to JavascriptTestBase if it is actually testing Javascript behavior
- Use the HTTP client directly.

michielnugter’s picture

Issue tags: +phpunit initiative

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

nlisgo’s picture

Assigned: Unassigned » nlisgo

I'm going to work on this one to try and address the failing tests.

michaellenahan’s picture

Issue tags: +Vienna2017
nlisgo’s picture

Assigned: nlisgo » Unassigned
Status: Needs work » Needs review
FileSize
6.06 KB
5.46 KB

Following the direction in #3 and #4, I have used HTTP client.

Mile23’s picture

Check out HistoryTest::getHttpClient().

There are a few other examples of doing this kind of thing, which is why I filed #2911915: Add getHttpClient() to BrowserTestBase to address converting tests that need http requests.

nlisgo’s picture

I introduced some whitespace into my last patch. Resupplying.

nlisgo’s picture

Apologises. Ignore patches in #11. Wrong issue.

dawehner’s picture

Let's postpone on the issue linked by @mile23 #2911915: Add getHttpClient() to BrowserTestBase

Status: Needs review » Needs work

The last submitted patch, 11: convert_web_tests_to-2864035-35.patch, failed testing. View results

nlisgo’s picture

Issue summary: View changes
Status: Needs work » Postponed

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.