Comments

GoZ created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, 2: convert_web_tests_to-2864121-2.patch, failed testing.

Lendude’s picture

Status: Needs work » Needs review

#2864257: Convert web tests AssertNoPattern to Browser Test has landed so requeueing the tests, and lets see if this is unblocked

Status: Needs review » Needs work

The last submitted patch, 2: convert_web_tests_to-2864121-2.patch, failed testing.

Lendude’s picture

Status: Needs work » Needs review
FileSize
2.48 KB

Needed a reroll for #2867493: Error: Call to a member function getTotalCount() on boolean in statistics_get().

Also took out the @deprecated for the new base class, not sure why that was added. The base class was moved previously, so that isn't part of this conversion.

One Views test left in the module that can be moved in a follow up when #2863267: Convert web tests of views lands.

dawehner’s picture

+++ b/core/modules/statistics/tests/src/Functional/StatisticsAdminTest.php
@@ -1,15 +1,18 @@
+use Drupal\Tests\BrowserTestBase;
+use \Drupal\Tests\Traits\Core\CronRunTrait;

Nitpick: Let's just use one trailing slash. I guess this is quite a nitpick :)

Lendude’s picture

@dawehner stupid PHPStorm, always collapsing the use statements, makes me miss crucial stuff like that :)

Fixed.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Hehe, thank you @Lendude

timmillwood’s picture

Thank you!

michielnugter’s picture

Issue tags: +phpunit initiative
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 1815dfd to 8.4.x and 8a30f22 to 8.3.x. Thanks!

Backported to 8.3.x because this is a test only change.

  • alexpott committed 1815dfd on 8.4.x
    Issue #2864121 by Lendude, GoZ, dawehner: Convert web tests to browser...

  • alexpott committed 8a30f22 on 8.3.x
    Issue #2864121 by Lendude, GoZ, dawehner: Convert web tests to browser...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.