Entity autocomplete displays default value's entity labels only in the default entity language

I reviewed this patch in #2144377: Entity reference autocomplete lists entity labels only in current content language, which is actually about two different bugs.

This patch correctly solves the part where default value entity labels are not displayed in the correct language.

Nice find and the fix does look good. Just a concern about the changes to the test.

+++ b/core/modules/field/tests/src/Functional/EntityReference/EntityReferenceFieldTranslatedReferenceViewTest.php
@@ -140,17 +140,20 @@ protected function setUp() {
+    $this->drupalLogin($this->rootUser);
...
-    $this->drupalLogin($this->rootUser);

A couple of things here. Moving the login changes what is being tested so we're losing anonymous testing of:

     $this->referrerEntity = $this->createReferrerEntity();
     $this->assertEntityReferenceDisplay();

But also we're using $this->rootUser which means we're logged in as user 1 which sometimes can do and see things no other user can - which magnifies the danger of this change. A simple solution would be to just not do the first $this->assertEntityReferenceFields(); and not move the user login since that would make this concern out-of-scope for this issue.

There should be an issue summary so that people know what is being fixed.

+++ b/core/lib/Drupal/Core/Entity/Element/EntityAutocomplete.php
@@ -320,6 +320,9 @@ protected static function matchEntityByTitle(SelectionInterface $handler, $input
+      // Set the entity in the correct language for display.
+      $entity = \Drupal::service('entity.repository')->getTranslationFromContext($entity);

We're in a loop here we should get the service outside of the loop.

+++ b/core/modules/field/tests/src/Functional/EntityReference/EntityReferenceFieldTranslatedReferenceViewTest.php
@@ -174,19 +183,20 @@
   /**
-   * Assert entity reference form fields.
+   * Assert entity reference form display.
    */
-  protected function assertEntityReferenceFields() {
+  protected function assertEntityReferenceFormDisplay() {

Changing this is not really necessary for the fix - seems unnecessarily disruptive for the fix.

#10.1: Fixed.
#10.2: I think you looked only at the interdiff, the change there is for the new assertion method added by this patch, so there is no disruption :)

Wrote an issue summary and putting back to RTBC because my change is really minor.

RTBC++, thanks @alexpott for your never-failing eagle eyes and @amateescu for the quick fix! Awesome.

Committed and pushed daea0bf to 8.4.x and 5552eef to 8.3.x. Thanks!

I credited myself for review comments that resulted in changes to the patch.

Also backported to 8.3.x because I cannot see any BC implications to this bugfix.