Problem/Motivation

Follow up to #2369119: Fatal error when trying to save a View with grouped filters using other than string values.

When adding a grouped filter that uses the \Drupal\views\Plugin\views\filter\InOperator the generated query contains '0' values for every not selected value.

Steps to reproduce

Steps to reproduce:
- Apply the patch
- Make two content types
- Make a grouped filter for content type
- Add one group 'is one of' for one content type
- Add one group 'is one of' for the second content type
- Save
- Filter using one of these groups and you wil see IN('node_type_1' ,'0', '0') in the query.

Proposed resolution

\Drupal\views\Plugin\views\filter\InOperator::opSimple doesn't clean the values to remove the empty checkboxes. So either the values need to be cleaned then building the query, or the values need to be cleaned when being set.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Problem/Motivation

CommentFileSizeAuthor
#24 interdiff_22-24.txt4.94 KBNitin shrivastava
#24 2857740-24.patch4.94 KBNitin shrivastava
#23 2857740-nr-bot.txt2.97 KBneeds-review-queue-bot
#22 2857740-22.patch4.94 KBLendude
#21 2857740-nr-bot.txt144 bytesneeds-review-queue-bot
#17 2857740-17.patch4.8 KBLendude
#17 2857740-17-TEST_ONLY.patch3.56 KBLendude
#16 reroll_diff_3-16.txt1.76 KBimmaculatexavier
#16 2857740-16.patch1.23 KBimmaculatexavier
#3 2857740-3-group-filter-zero.patch1.25 KBtacituseu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Lendude created an issue. See original summary.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at Noctilaris commented
Title: Views Grouped filter that uses InOperator add '0' to the query for every » Views grouped filters that use InOperator add '0' to the query for every not selected option
tacituseu’s picture

tacituseu CreditAttribution: tacituseu commented
Status: Active » Needs work
FileSize
2857740-3-group-filter-zero.patch1.25 KB

They are added in Drupal\views\Plugin\views\filter\FilterPluginBase::buildGroupSubmit(), there seems to be a provision for filtering empty values, check: Drupal\views\Plugin\views\filter\FilterPluginBase::hasValidGroupedValue():

$actual_values = count(array_filter($group['value'], 'static::arrayFilterZero'));

so it could be as simple as using it in buildGroupSubmit().

Attached, needs tests...

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

tacituseu’s picture

tacituseu CreditAttribution: tacituseu commented
Version: 8.4.x-dev » 8.5.x-dev
Related issues: +#2687773: Using checkboxes with an "is all of" filter fails if any options are selected

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Issue summary: View changes
Issue tags: +Bug Smash Initiative, +Needs reroll, +Needs tests

Tested on Drupal 9.5.x and this is still applicable. The patch does not apply. I did not review the patch.

Adding tags.

immaculatexavier’s picture

immaculatexavier CreditAttribution: immaculatexavier as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
2857740-16.patch1.23 KB
reroll_diff_3-16.txt1.76 KB

Rerolled patch against #3.
Attached reroll diff

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at iO commented
Issue tags: -Needs reroll, -Needs tests
FileSize
2857740-17-TEST_ONLY.patch3.56 KB
2857740-17.patch4.8 KB

Here is a test for this. Test only patch is the interdiff

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at iO commented

The fact that the added code calls $this->operators() which is not defined on the abstract class smells a bit, but it is something that is already done at other points in FilterPluginBase so it's not doing anything new.

The last submitted patch, 17: 2857740-17-TEST_ONLY.patch, failed testing. View results

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Needs review » Needs work
FileSize
2857740-nr-bot.txt144 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at iO commented
Status: Needs work » Needs review
FileSize
2857740-22.patch4.94 KB

Tricky reroll since the new test class is no longer new :)

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Needs review » Needs work
FileSize
2857740-nr-bot.txt2.97 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Nitin shrivastava’s picture

Nitin shrivastava CreditAttribution: Nitin shrivastava at OpenSense Labs commented
FileSize
2857740-24.patch4.94 KB
interdiff_22-24.txt4.94 KB

Fix Custom command failures.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.