Coder 8.2.11 is out, let's upgrade to have better fixers.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klausi created an issue. See original summary.

klausi’s picture

Status: Active » Needs review

Patch. Coder now also checks module files and inc files automatically, so we have to fix a couple of instances.

klausi’s picture

Trying to upload file again.

andypost’s picture

Status: Needs review » Reviewed & tested by the community

Passed for me

xjm’s picture

Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Nummy. I did a composer install after applying the patch to also confirm that the newly enabled rules would pass on the changed files when I committed it. Pushed to 8.4.x.

We will need a separate 8.3.x backport since the hashes will differ, no? Patch-level updates are allowed in RC, and dev dependencies can be updated any time probably.

andypost’s picture

latest corer has issue with info files #2857856: Allow not namespaced dependencies in theme info YAML files
probably install profiles does not pass DrupalPractice sniffer

xjm’s picture

@andypost, I don't think core is affected though?

andypost’s picture

It affects because upgrade caused more strict checking for yml but sure should be solved in coder and #2855026: Installation profiles do not support project:module format for dependencies
I'm using custom install profiles for projects and this upgrade caused me to stick on previous version of coder

@xjm Is upgrade to coder 8.2.12 allowed in patch releases?

andypost’s picture

Status: Patch (to be ported) » Needs review
FileSize
6.5 KB

reroll for 8.3.x (only index changes)

xjm’s picture

Thanks @andypost. Yep, upgrade to patch releases of dependencies can also be done in patch releases.

Mile23’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed #9 as follows:

// fetch, checkout, pull, apply patch...
$ rm -rf vendor/
$ composer install
$ cd core/
$ ../vendor/bin/phpcs -ps

Results in no errors.

Rawk.

Note that since this patch changes the phpcs.xml(.dist) file, the testbot is forced to sniff the whole project. If it weren't changed, it would have only sniffed the files modified by the patch.

We also see this in the log file, which shows us that our patch changed the coder version accurately:

10:40:59 Running Composer within the environment.
10:40:59 COMPOSER_ALLOW_SUPERUSER=TRUE /usr/local/bin/composer install --prefer-dist --no-suggest --no-progress --working-dir /var/www/html
10:40:59 Loading composer repositories with package information
10:40:59 Installing dependencies (including require-dev) from lock file
10:40:59 Package operations: 0 installs, 1 update, 0 removals
10:40:59   - Removing drupal/coder (8.2.10)
10:40:59   - Installing drupal/coder (8.2.11) Loading from cache
10:41:00 > Drupal\Core\Composer\Composer::vendorTestCodeCleanup
xjm’s picture

Status: Reviewed & tested by the community » Fixed

Thanks @Mile23!

Committed and pushed to 8.3.x.

  • xjm committed 2bb7ef3 on 8.3.x
    Issue #2857714 by klausi, andypost, Mile23: Upgrade Coder to 8.2.11
    
klausi’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.