Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Coder 8.2.11 is out, let's upgrade to have better fixers.
Comment | File | Size | Author |
---|---|---|---|
#9 | coder-update-2857714-9.patch | 6.5 KB | andypost |
#3 | coder-update-2857714-2.patch | 6.5 KB | klausi |
Comments
Comment #2
klausiPatch. Coder now also checks module files and inc files automatically, so we have to fix a couple of instances.
Comment #3
klausiTrying to upload file again.
Comment #4
andypostPassed for me
Comment #5
xjmNummy. I did a composer install after applying the patch to also confirm that the newly enabled rules would pass on the changed files when I committed it. Pushed to 8.4.x.
We will need a separate 8.3.x backport since the hashes will differ, no? Patch-level updates are allowed in RC, and dev dependencies can be updated any time probably.
Comment #6
andypostlatest corer has issue with info files #2857856: Allow not namespaced dependencies in theme info YAML files
probably install profiles does not pass DrupalPractice sniffer
Comment #7
xjm@andypost, I don't think core is affected though?
Comment #8
andypostIt affects because upgrade caused more strict checking for yml but sure should be solved in coder and #2855026: Installation profiles do not support project:module format for dependencies
I'm using custom install profiles for projects and this upgrade caused me to stick on previous version of coder
@xjm Is upgrade to coder 8.2.12 allowed in patch releases?
Comment #9
andypostreroll for 8.3.x (only index changes)
Comment #10
xjmThanks @andypost. Yep, upgrade to patch releases of dependencies can also be done in patch releases.
Comment #11
Mile23Reviewed #9 as follows:
Results in no errors.
Rawk.
Note that since this patch changes the phpcs.xml(.dist) file, the testbot is forced to sniff the whole project. If it weren't changed, it would have only sniffed the files modified by the patch.
We also see this in the log file, which shows us that our patch changed the coder version accurately:
Comment #12
xjmThanks @Mile23!
Committed and pushed to 8.3.x.
Comment #14
klausiNext one: #2861793: Upgrade Coder to 8.2.12